Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1583

Remove ServerCallable in RPC client

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Java Client
    • Labels:
      None

      Description

      TAJO-1563 contains retry during invocation internally.
      We should remove it for more clearly. because it invoke repeatedly without reference to an application error

      1. TAJO-1583_2.patch
        116 kB
        Jinho Kim
      2. TAJO-1583_3.patch
        119 kB
        Jinho Kim
      3. TAJO-1583.patch
        115 kB
        Jinho Kim

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jinossy opened a pull request:

          https://github.com/apache/tajo/pull/556

          TAJO-1583: Remove ServerCallable in RPC client

          This patch requires TAJO-1563

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jinossy/tajo TAJO-1583

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/556.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #556


          commit b7b45ea3a8fa67cb2f12915f9ee3d543440c9430
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-21T14:12:27Z

          TAJO-1563

          commit 19d1516de620e901b15a315ecb31e44d567a767f
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-22T03:29:35Z

          add connection retry in rpc client

          commit 035e45a57b1adbe7d2fb374a6a9de23d3e2e9891
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-22T03:30:30Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563

          commit b19680e806b79298e0a33f1c371a71606b5c8e2c
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-23T06:58:42Z

          cleanup codes and add comments

          commit 7b76c9dbdeb2215ab69e7df58c61f9657fc7ac4f
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-23T07:05:45Z

          fix compilation error

          commit d4c47d1ce3ff5b333317a84498e22df4df34ce36
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-23T08:58:31Z

          fix infinite loop of async future

          commit 43d7df7046e787b1bf3d1e453132fd40dbdb3144
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-23T11:33:45Z

          fix worker heartbeat when tajo startup

          commit b9a0035541b26e01c0e57ab7777e24533b655c04
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-23T16:59:07Z

          add more test case

          commit d9d9de6a2297b4fa686eea8037227944f97b3aad
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-24T07:43:39Z

          cleanup the duplicate codes

          commit d43fb24363a83b728c853cb04e00446e85c7c138
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-24T07:44:14Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563

          commit 630fed62adadc6809ba2774ab8afebff8e3503f2
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-24T07:49:35Z

          remove atomicUpdater

          commit 24f5c90e5a5a4eda916158d7bcd68a5010f477ac
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-24T07:58:49Z

          fix missing sequence id

          commit b7722989c06920d896d33d893da2ac61cbb31ad2
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-24T09:51:03Z

          add default configs

          commit 12f4218a96fd06b501ca9bd4beec98f01a681c1c
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-24T18:25:04Z

          change test timeout

          commit cb89cdb4074d498a8a75f46767d4c6a59645d599
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T03:36:07Z

          fix wrong lock

          commit 76c2b8fc3cb010c4f26ef2e97f09d743e1378098
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T06:21:58Z

          fix callback lost

          commit ad076c260a987fb5f5cd2611843e5fb3faf98823
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T07:55:57Z

          enable request timeout

          commit ef000419cef93c40373991619a289aaa9f37403e
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T08:36:42Z

          add handlerRemoved event

          commit a6961e9f6fd0942a9e851f4c1b9bf70a75f483a2
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T09:25:03Z

          fix race condition for register callback

          commit 0019e92b861f2950314273ff6d94a5827e7d7dcc
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T11:47:12Z

          change to ChannelPromise

          commit fa91ce4f84306e0dc931843ab16351f522791337
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T13:55:08Z

          cleanup client event listener

          commit 5c23c124f7606be0d6a0c854b99861779b8c95bd
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-25T15:07:11Z

          add throwable get()

          commit 1f401df3fbbf93bf73020afe9f57460ec34378df
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T03:06:08Z

          remove duplicate code

          commit ea35635714afb4cb7b5402ce5b9edd8c1a0c9159
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T05:24:22Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563

          commit 7c97214605f8c85be4f0ab6159ab84a7772c8d55
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T05:51:17Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563

          commit 8f27acfa42d6eeaf184a1d749139fefcc1119f2a
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T06:00:59Z

          remove findbug warning

          commit 16839e472c166580601f11f7d3eb6a88a7307490
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T10:32:20Z

          remove findbug warnings

          commit 8a3e9c9ca5cf3760d8b473b2ba925425cd430c7b
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T10:33:10Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563

          commit 04da1db8f9a487b8c4bd7ffc8832e5f27571aa9b
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T12:59:00Z

          fix remain warnings

          commit 7ea397325a687a5bb91c999b2f32f589e4861a9b
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-27T13:51:47Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/556 TAJO-1583 : Remove ServerCallable in RPC client This patch requires TAJO-1563 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1583 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #556 commit b7b45ea3a8fa67cb2f12915f9ee3d543440c9430 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-21T14:12:27Z TAJO-1563 commit 19d1516de620e901b15a315ecb31e44d567a767f Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-22T03:29:35Z add connection retry in rpc client commit 035e45a57b1adbe7d2fb374a6a9de23d3e2e9891 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-22T03:30:30Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563 commit b19680e806b79298e0a33f1c371a71606b5c8e2c Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-23T06:58:42Z cleanup codes and add comments commit 7b76c9dbdeb2215ab69e7df58c61f9657fc7ac4f Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-23T07:05:45Z fix compilation error commit d4c47d1ce3ff5b333317a84498e22df4df34ce36 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-23T08:58:31Z fix infinite loop of async future commit 43d7df7046e787b1bf3d1e453132fd40dbdb3144 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-23T11:33:45Z fix worker heartbeat when tajo startup commit b9a0035541b26e01c0e57ab7777e24533b655c04 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-23T16:59:07Z add more test case commit d9d9de6a2297b4fa686eea8037227944f97b3aad Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T07:43:39Z cleanup the duplicate codes commit d43fb24363a83b728c853cb04e00446e85c7c138 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T07:44:14Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563 commit 630fed62adadc6809ba2774ab8afebff8e3503f2 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T07:49:35Z remove atomicUpdater commit 24f5c90e5a5a4eda916158d7bcd68a5010f477ac Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T07:58:49Z fix missing sequence id commit b7722989c06920d896d33d893da2ac61cbb31ad2 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T09:51:03Z add default configs commit 12f4218a96fd06b501ca9bd4beec98f01a681c1c Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T18:25:04Z change test timeout commit cb89cdb4074d498a8a75f46767d4c6a59645d599 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T03:36:07Z fix wrong lock commit 76c2b8fc3cb010c4f26ef2e97f09d743e1378098 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T06:21:58Z fix callback lost commit ad076c260a987fb5f5cd2611843e5fb3faf98823 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T07:55:57Z enable request timeout commit ef000419cef93c40373991619a289aaa9f37403e Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T08:36:42Z add handlerRemoved event commit a6961e9f6fd0942a9e851f4c1b9bf70a75f483a2 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T09:25:03Z fix race condition for register callback commit 0019e92b861f2950314273ff6d94a5827e7d7dcc Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T11:47:12Z change to ChannelPromise commit fa91ce4f84306e0dc931843ab16351f522791337 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T13:55:08Z cleanup client event listener commit 5c23c124f7606be0d6a0c854b99861779b8c95bd Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-25T15:07:11Z add throwable get() commit 1f401df3fbbf93bf73020afe9f57460ec34378df Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T03:06:08Z remove duplicate code commit ea35635714afb4cb7b5402ce5b9edd8c1a0c9159 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T05:24:22Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563 commit 7c97214605f8c85be4f0ab6159ab84a7772c8d55 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T05:51:17Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563 commit 8f27acfa42d6eeaf184a1d749139fefcc1119f2a Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T06:00:59Z remove findbug warning commit 16839e472c166580601f11f7d3eb6a88a7307490 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T10:32:20Z remove findbug warnings commit 8a3e9c9ca5cf3760d8b473b2ba925425cd430c7b Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T10:33:10Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563 commit 04da1db8f9a487b8c4bd7ffc8832e5f27571aa9b Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T12:59:00Z fix remain warnings commit 7ea397325a687a5bb91c999b2f32f589e4861a9b Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-27T13:51:47Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1563
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/556#issuecomment-96972034

          Travis maven version is 3.3.1. it needs JDK 1.7.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/556#issuecomment-96972034 Travis maven version is 3.3.1. it needs JDK 1.7.
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12729040/TAJO-1583.patch
          against master revision release-0.9.0-rc0-279-g9540f16.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server tajo-client tajo-core tajo-rpc/tajo-rpc-protobuf.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/764//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/764//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12729040/TAJO-1583.patch against master revision release-0.9.0-rc0-279-g9540f16. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server tajo-client tajo-core tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/764//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/764//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/556#discussion_r29338127

          — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
          @@ -19,6 +19,7 @@
          package org.apache.tajo.catalog;

          import com.google.protobuf.ServiceException;
          +import org.apache.avro.generic.GenericData;
          — End diff –

          Looks unused.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/556#discussion_r29338127 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -19,6 +19,7 @@ package org.apache.tajo.catalog; import com.google.protobuf.ServiceException; +import org.apache.avro.generic.GenericData; — End diff – Looks unused.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/556#discussion_r29338237

          — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
          @@ -64,32 +69,44 @@ public AbstractCatalogClient(TajoConf conf, InetSocketAddress catalogServerAddr)
          }

          private InetSocketAddress getCatalogServerAddr() {

          • if (catalogServerAddr == null) {
          • return null;
            + if (!conf.getBoolVar(TajoConf.ConfVars.TAJO_MASTER_HA_ENABLE)) { + return catalogServerAddr; }

            else

            { + return serviceTracker.getCatalogAddress(); + }

            + }

          • if (!conf.getBoolVar(TajoConf.ConfVars.TAJO_MASTER_HA_ENABLE)) { - return catalogServerAddr; - }

            else {

          • return serviceTracker.getCatalogAddress();
            + public synchronized NettyClientBase getCatalogConnection() throws ServiceException {
            + if (client == null || !client.isConnected())
            Unknown macro: { + try { + RpcClientManager.cleanup(client); + + int retry = conf.getInt(RpcConstants.RPC_CLIENT_RETRY_MAX, RpcConstants.DEFAULT_RPC_RETRIES); + int timeout = conf.getInt(RpcConstants.RPC_CLIENT_TIMEOUT_SECS, 0); + this.client = manager.newClient(getCatalogServerAddr(), CatalogProtocol.class, false, retry, timeout, + TimeUnit.SECONDS, false); + } catch (Exception e) { + throw new ServiceException(e); } }

            + return client;
            + }
            +
            + @Override
            + public void close()

            { + RpcClientManager.cleanup(client); }

          @Override
          public final Boolean createTablespace(final String tablespaceName, final String tablespaceUri) {
          try {

          • return new ServerCallable<Boolean>(manager, getCatalogServerAddr(), CatalogProtocol.class, false) {
          • public Boolean call(NettyClientBase client) throws ServiceException { - CatalogProtocolService.BlockingInterface stub = getStub(client); + CatalogProtocolService.BlockingInterface stub = getStub(); - CreateTablespaceRequest.Builder builder = CreateTablespaceRequest.newBuilder(); - builder.setTablespaceName(tablespaceName); - builder.setTablespaceUri(tablespaceUri); - return stub.createTablespace(null, builder.build()).getValue(); - }
          • }.withRetries();
          • } catch (ServiceException e) { + CreateTablespaceRequest.Builder builder = CreateTablespaceRequest.newBuilder(); + builder.setTablespaceName(tablespaceName); + builder.setTablespaceUri(tablespaceUri); + return stub.createTablespace(null, builder.build()).getValue(); + }

            catch (Exception e) {

              • End diff –

          Exception seems too broad. How about catching ServiceException?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/556#discussion_r29338237 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -64,32 +69,44 @@ public AbstractCatalogClient(TajoConf conf, InetSocketAddress catalogServerAddr) } private InetSocketAddress getCatalogServerAddr() { if (catalogServerAddr == null) { return null; + if (!conf.getBoolVar(TajoConf.ConfVars.TAJO_MASTER_HA_ENABLE)) { + return catalogServerAddr; } else { + return serviceTracker.getCatalogAddress(); + } + } if (!conf.getBoolVar(TajoConf.ConfVars.TAJO_MASTER_HA_ENABLE)) { - return catalogServerAddr; - } else { return serviceTracker.getCatalogAddress(); + public synchronized NettyClientBase getCatalogConnection() throws ServiceException { + if (client == null || !client.isConnected()) Unknown macro: { + try { + RpcClientManager.cleanup(client); + + int retry = conf.getInt(RpcConstants.RPC_CLIENT_RETRY_MAX, RpcConstants.DEFAULT_RPC_RETRIES); + int timeout = conf.getInt(RpcConstants.RPC_CLIENT_TIMEOUT_SECS, 0); + this.client = manager.newClient(getCatalogServerAddr(), CatalogProtocol.class, false, retry, timeout, + TimeUnit.SECONDS, false); + } catch (Exception e) { + throw new ServiceException(e); } } + return client; + } + + @Override + public void close() { + RpcClientManager.cleanup(client); } @Override public final Boolean createTablespace(final String tablespaceName, final String tablespaceUri) { try { return new ServerCallable<Boolean>(manager, getCatalogServerAddr(), CatalogProtocol.class, false) { public Boolean call(NettyClientBase client) throws ServiceException { - CatalogProtocolService.BlockingInterface stub = getStub(client); + CatalogProtocolService.BlockingInterface stub = getStub(); - CreateTablespaceRequest.Builder builder = CreateTablespaceRequest.newBuilder(); - builder.setTablespaceName(tablespaceName); - builder.setTablespaceUri(tablespaceUri); - return stub.createTablespace(null, builder.build()).getValue(); - } }.withRetries(); } catch (ServiceException e) { + CreateTablespaceRequest.Builder builder = CreateTablespaceRequest.newBuilder(); + builder.setTablespaceName(tablespaceName); + builder.setTablespaceUri(tablespaceUri); + return stub.createTablespace(null, builder.build()).getValue(); + } catch (Exception e) { End diff – Exception seems too broad. How about catching ServiceException?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/556#discussion_r29339013

          — Diff: tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java —
          @@ -416,119 +387,86 @@ public TajoMemoryResultSet fetchNextQueryResult(final QueryId queryId, final int
          @Override
          public boolean updateQuery(final String sql) throws ServiceException {

          • return new ServerCallable<Boolean>(connection.manager, connection.getTajoMasterAddr(),
          • TajoMasterClientProtocol.class, false) {
            + NettyClientBase client = connection.getTajoMasterConnection();
            + connection.checkSessionAndGet(client);
            + TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub();
          • public Boolean call(NettyClientBase client) throws ServiceException {
            + QueryRequest.Builder builder = QueryRequest.newBuilder();
            + builder.setSessionId(connection.sessionId);
            + builder.setQuery(sql);
            + builder.setIsJson(false);
            + ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build());
          • connection.checkSessionAndGet(client);
          • TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub();
            -
          • QueryRequest.Builder builder = QueryRequest.newBuilder();
          • builder.setSessionId(connection.sessionId);
          • builder.setQuery(sql);
          • builder.setIsJson(false);
          • ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build());
            -
          • if (response.getResultCode() == ClientProtos.ResultCode.OK) { - connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); - return true; - }

            else {

          • if (response.hasErrorMessage()) { - System.err.println("ERROR: " + response.getErrorMessage()); - }
          • return false;
          • }
            + if (response.getResultCode() == ClientProtos.ResultCode.OK) { + connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); + return true; + }

            else {
            + if (response.hasErrorMessage()) {
            + System.err.println("ERROR: " + response.getErrorMessage());

              • End diff –

          Even though you just move this line, it would be nice if you change to use LOG.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/556#discussion_r29339013 — Diff: tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java — @@ -416,119 +387,86 @@ public TajoMemoryResultSet fetchNextQueryResult(final QueryId queryId, final int @Override public boolean updateQuery(final String sql) throws ServiceException { return new ServerCallable<Boolean>(connection.manager, connection.getTajoMasterAddr(), TajoMasterClientProtocol.class, false) { + NettyClientBase client = connection.getTajoMasterConnection(); + connection.checkSessionAndGet(client); + TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub(); public Boolean call(NettyClientBase client) throws ServiceException { + QueryRequest.Builder builder = QueryRequest.newBuilder(); + builder.setSessionId(connection.sessionId); + builder.setQuery(sql); + builder.setIsJson(false); + ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build()); connection.checkSessionAndGet(client); TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub(); - QueryRequest.Builder builder = QueryRequest.newBuilder(); builder.setSessionId(connection.sessionId); builder.setQuery(sql); builder.setIsJson(false); ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build()); - if (response.getResultCode() == ClientProtos.ResultCode.OK) { - connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); - return true; - } else { if (response.hasErrorMessage()) { - System.err.println("ERROR: " + response.getErrorMessage()); - } return false; } + if (response.getResultCode() == ClientProtos.ResultCode.OK) { + connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); + return true; + } else { + if (response.hasErrorMessage()) { + System.err.println("ERROR: " + response.getErrorMessage()); End diff – Even though you just move this line, it would be nice if you change to use LOG.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/556#discussion_r29339034

          — Diff: tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java —
          @@ -416,119 +387,86 @@ public TajoMemoryResultSet fetchNextQueryResult(final QueryId queryId, final int
          @Override
          public boolean updateQuery(final String sql) throws ServiceException {

          • return new ServerCallable<Boolean>(connection.manager, connection.getTajoMasterAddr(),
          • TajoMasterClientProtocol.class, false) {
            + NettyClientBase client = connection.getTajoMasterConnection();
            + connection.checkSessionAndGet(client);
            + TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub();
          • public Boolean call(NettyClientBase client) throws ServiceException {
            + QueryRequest.Builder builder = QueryRequest.newBuilder();
            + builder.setSessionId(connection.sessionId);
            + builder.setQuery(sql);
            + builder.setIsJson(false);
            + ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build());
          • connection.checkSessionAndGet(client);
          • TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub();
            -
          • QueryRequest.Builder builder = QueryRequest.newBuilder();
          • builder.setSessionId(connection.sessionId);
          • builder.setQuery(sql);
          • builder.setIsJson(false);
          • ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build());
            -
          • if (response.getResultCode() == ClientProtos.ResultCode.OK) { - connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); - return true; - }

            else {

          • if (response.hasErrorMessage()) { - System.err.println("ERROR: " + response.getErrorMessage()); - }
          • return false;
          • }
            + if (response.getResultCode() == ClientProtos.ResultCode.OK) { + connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); + return true; + }

            else {
            + if (response.hasErrorMessage())

            { + System.err.println("ERROR: " + response.getErrorMessage()); }
          • }.withRetries();
            + return false;
            + }
            }

          @Override
          public boolean updateQueryWithJson(final String json) throws ServiceException {

          • return new ServerCallable<Boolean>(connection.manager, connection.getTajoMasterAddr(),
          • TajoMasterClientProtocol.class, false) {
            -
          • public Boolean call(NettyClientBase client) throws ServiceException {
            -
          • connection.checkSessionAndGet(client);
          • TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub();
            -
          • QueryRequest.Builder builder = QueryRequest.newBuilder();
          • builder.setSessionId(connection.sessionId);
          • builder.setQuery(json);
          • builder.setIsJson(true);
          • ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build());
          • if (response.getResultCode() == ClientProtos.ResultCode.OK) { - return true; - }

            else {

          • if (response.hasErrorMessage()) { - System.err.println("ERROR: " + response.getErrorMessage()); - }
          • return false;
          • }
            + NettyClientBase client = connection.getTajoMasterConnection();
            + connection.checkSessionAndGet(client);
            + TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub();
            +
            + QueryRequest.Builder builder = QueryRequest.newBuilder();
            + builder.setSessionId(connection.sessionId);
            + builder.setQuery(json);
            + builder.setIsJson(true);
            + ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build());
            + if (response.getResultCode() == ClientProtos.ResultCode.OK) { + return true; + }

            else {
            + if (response.hasErrorMessage()) {
            + System.err.println("ERROR: " + response.getErrorMessage());

              • End diff –

          Even though you just move this line, it would be nice if you change to use LOG.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/556#discussion_r29339034 — Diff: tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java — @@ -416,119 +387,86 @@ public TajoMemoryResultSet fetchNextQueryResult(final QueryId queryId, final int @Override public boolean updateQuery(final String sql) throws ServiceException { return new ServerCallable<Boolean>(connection.manager, connection.getTajoMasterAddr(), TajoMasterClientProtocol.class, false) { + NettyClientBase client = connection.getTajoMasterConnection(); + connection.checkSessionAndGet(client); + TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub(); public Boolean call(NettyClientBase client) throws ServiceException { + QueryRequest.Builder builder = QueryRequest.newBuilder(); + builder.setSessionId(connection.sessionId); + builder.setQuery(sql); + builder.setIsJson(false); + ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build()); connection.checkSessionAndGet(client); TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub(); - QueryRequest.Builder builder = QueryRequest.newBuilder(); builder.setSessionId(connection.sessionId); builder.setQuery(sql); builder.setIsJson(false); ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build()); - if (response.getResultCode() == ClientProtos.ResultCode.OK) { - connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); - return true; - } else { if (response.hasErrorMessage()) { - System.err.println("ERROR: " + response.getErrorMessage()); - } return false; } + if (response.getResultCode() == ClientProtos.ResultCode.OK) { + connection.updateSessionVarsCache(ProtoUtil.convertToMap(response.getSessionVars())); + return true; + } else { + if (response.hasErrorMessage()) { + System.err.println("ERROR: " + response.getErrorMessage()); } }.withRetries(); + return false; + } } @Override public boolean updateQueryWithJson(final String json) throws ServiceException { return new ServerCallable<Boolean>(connection.manager, connection.getTajoMasterAddr(), TajoMasterClientProtocol.class, false) { - public Boolean call(NettyClientBase client) throws ServiceException { - connection.checkSessionAndGet(client); TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub(); - QueryRequest.Builder builder = QueryRequest.newBuilder(); builder.setSessionId(connection.sessionId); builder.setQuery(json); builder.setIsJson(true); ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build()); if (response.getResultCode() == ClientProtos.ResultCode.OK) { - return true; - } else { if (response.hasErrorMessage()) { - System.err.println("ERROR: " + response.getErrorMessage()); - } return false; } + NettyClientBase client = connection.getTajoMasterConnection(); + connection.checkSessionAndGet(client); + TajoMasterClientProtocolService.BlockingInterface tajoMasterService = client.getStub(); + + QueryRequest.Builder builder = QueryRequest.newBuilder(); + builder.setSessionId(connection.sessionId); + builder.setQuery(json); + builder.setIsJson(true); + ClientProtos.UpdateQueryResponse response = tajoMasterService.updateQuery(null, builder.build()); + if (response.getResultCode() == ClientProtos.ResultCode.OK) { + return true; + } else { + if (response.hasErrorMessage()) { + System.err.println("ERROR: " + response.getErrorMessage()); End diff – Even though you just move this line, it would be nice if you change to use LOG.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/556#discussion_r29339908

          — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java —
          @@ -95,20 +96,29 @@ public SessionConnection(ServiceTracker tracker, @Nullable String baseDatabase,
          this.baseDatabase = baseDatabase != null ? baseDatabase : null;

          this.serviceTracker = tracker;
          + try

          { + this.client = getTajoMasterConnection(); + }

          catch (Exception e)

          { + throw new IOException(e); + }

          }

          public Map<String, String> getClientSideSessionVars()

          { return Collections.unmodifiableMap(sessionVarsCache); }
          • public NettyClientBase getTajoMasterConnection(boolean asyncMode) throws NoSuchMethodException,
          • ConnectException, ClassNotFoundException { - return manager.getClient(getTajoMasterAddr(), TajoMasterClientProtocol.class, asyncMode); - }

            + public synchronized NettyClientBase getTajoMasterConnection() throws ServiceException {

              • End diff –

          As I know, SessionConnection is created for each client. Do we need to declare synchronized for this method?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/556#discussion_r29339908 — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java — @@ -95,20 +96,29 @@ public SessionConnection(ServiceTracker tracker, @Nullable String baseDatabase, this.baseDatabase = baseDatabase != null ? baseDatabase : null; this.serviceTracker = tracker; + try { + this.client = getTajoMasterConnection(); + } catch (Exception e) { + throw new IOException(e); + } } public Map<String, String> getClientSideSessionVars() { return Collections.unmodifiableMap(sessionVarsCache); } public NettyClientBase getTajoMasterConnection(boolean asyncMode) throws NoSuchMethodException, ConnectException, ClassNotFoundException { - return manager.getClient(getTajoMasterAddr(), TajoMasterClientProtocol.class, asyncMode); - } + public synchronized NettyClientBase getTajoMasterConnection() throws ServiceException { End diff – As I know, SessionConnection is created for each client. Do we need to declare synchronized for this method?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/556#issuecomment-97447448

          Nice work!
          I left trivial comments and a question.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/556#issuecomment-97447448 Nice work! I left trivial comments and a question.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/556#discussion_r29343681

          — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java —
          @@ -95,20 +96,29 @@ public SessionConnection(ServiceTracker tracker, @Nullable String baseDatabase,
          this.baseDatabase = baseDatabase != null ? baseDatabase : null;

          this.serviceTracker = tracker;
          + try

          { + this.client = getTajoMasterConnection(); + }

          catch (Exception e)

          { + throw new IOException(e); + }

          }

          public Map<String, String> getClientSideSessionVars()

          { return Collections.unmodifiableMap(sessionVarsCache); }
          • public NettyClientBase getTajoMasterConnection(boolean asyncMode) throws NoSuchMethodException,
          • ConnectException, ClassNotFoundException { - return manager.getClient(getTajoMasterAddr(), TajoMasterClientProtocol.class, asyncMode); - }

            + public synchronized NettyClientBase getTajoMasterConnection() throws ServiceException {

              • End diff –

          Nice finding!
          The client is created in constructor.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/556#discussion_r29343681 — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java — @@ -95,20 +96,29 @@ public SessionConnection(ServiceTracker tracker, @Nullable String baseDatabase, this.baseDatabase = baseDatabase != null ? baseDatabase : null; this.serviceTracker = tracker; + try { + this.client = getTajoMasterConnection(); + } catch (Exception e) { + throw new IOException(e); + } } public Map<String, String> getClientSideSessionVars() { return Collections.unmodifiableMap(sessionVarsCache); } public NettyClientBase getTajoMasterConnection(boolean asyncMode) throws NoSuchMethodException, ConnectException, ClassNotFoundException { - return manager.getClient(getTajoMasterAddr(), TajoMasterClientProtocol.class, asyncMode); - } + public synchronized NettyClientBase getTajoMasterConnection() throws ServiceException { End diff – Nice finding! The client is created in constructor.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/556#issuecomment-97463294

          Thank you for the review!
          I've update the PR that reflects your comments

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/556#issuecomment-97463294 Thank you for the review! I've update the PR that reflects your comments
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12729187/TAJO-1583_2.patch
          against master revision release-0.9.0-rc0-279-g9540f16.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server tajo-client tajo-core tajo-rpc/tajo-rpc-protobuf.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/767//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/767//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12729187/TAJO-1583_2.patch against master revision release-0.9.0-rc0-279-g9540f16. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server tajo-client tajo-core tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/767//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/767//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/556#issuecomment-97489493

          +1 thanks for quick fix!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/556#issuecomment-97489493 +1 thanks for quick fix!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/556#issuecomment-97649943

          @jihoonson
          I missed the HA. If master address is changed. client should newly create.
          When I refactor the HA, I will improve the synchronization

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/556#issuecomment-97649943 @jihoonson I missed the HA. If master address is changed. client should newly create. When I refactor the HA, I will improve the synchronization
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12729387/TAJO-1583_3.patch
          against master revision release-0.9.0-rc0-279-g9540f16.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server tajo-client tajo-core tajo-rpc/tajo-rpc-protobuf.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/768//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/768//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12729387/TAJO-1583_3.patch against master revision release-0.9.0-rc0-279-g9540f16. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server tajo-client tajo-core tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/768//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/768//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/556#issuecomment-97693105

          @jinossy, you are right. It is currently required for HA of master.
          +1 ship it!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/556#issuecomment-97693105 @jinossy, you are right. It is currently required for HA of master. +1 ship it!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/556

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/556
          Hide
          jhkim Jinho Kim added a comment -

          committed it.
          Thanks

          Show
          jhkim Jinho Kim added a comment - committed it. Thanks
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #331 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/331/)
          TAJO-1583: Remove ServerCallable in RPC client. (jinho) (jhkim: rev 475541057891518e08e5a18ebbbf916c1ad60c10)

          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RetriesExhaustedException.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • CHANGES
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #331 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/331/ ) TAJO-1583 : Remove ServerCallable in RPC client. (jinho) (jhkim: rev 475541057891518e08e5a18ebbbf916c1ad60c10) tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RetriesExhaustedException.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java CHANGES tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogClient.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #692 (See https://builds.apache.org/job/Tajo-master-build/692/)
          TAJO-1583: Remove ServerCallable in RPC client. (jinho) (jhkim: rev 475541057891518e08e5a18ebbbf916c1ad60c10)

          • tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RetriesExhaustedException.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogClient.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • CHANGES
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
          • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #692 (See https://builds.apache.org/job/Tajo-master-build/692/ ) TAJO-1583 : Remove ServerCallable in RPC client. (jinho) (jhkim: rev 475541057891518e08e5a18ebbbf916c1ad60c10) tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RetriesExhaustedException.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogClient.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java CHANGES tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development