Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1570

CatalogUtil newSimpleDataTypeArray should use newSimpleDataType

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      It is better CatalogUtil's newSimpleDataTypeArray method use newSimpleDataType. Because their purpose is the same.
      and it is efficient when someone change newSimpleDataType method.

      ```java
      public static DataType [] newSimpleDataTypeArray(Type... types) {
      DataType [] dataTypes = new DataType[types.length];
      for (int i = 0; i < types.length; i++)

      { dataTypes[i] = DataType.newBuilder().setType(types[i]).build(); }

      return dataTypes;
      }
      ```

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/542

        TAJO-1570 CatalogUtil newSimpleDataTypeArray should use newSimpleDataType

        It is better CatalogUtil's newSimpleDataTypeArray method use newSimpleDataType. Because their purpose is the same.
        and it is efficient when someone change newSimpleDataType method.
        ```java
        public static DataType [] newSimpleDataTypeArray(Type... types) {
        DataType [] dataTypes = new DataType[types.length];
        for (int i = 0; i < types.length; i++)

        { dataTypes[i] = DataType.newBuilder().setType(types[i]).build(); }

        return dataTypes;
        }
        ```

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/refactoring-1

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/542.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #542


        commit 539069dab0c94b40c5d603059f1964b47a2c8d3f
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-04-18T06:44:44Z

        refactoring


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/542 TAJO-1570 CatalogUtil newSimpleDataTypeArray should use newSimpleDataType It is better CatalogUtil's newSimpleDataTypeArray method use newSimpleDataType. Because their purpose is the same. and it is efficient when someone change newSimpleDataType method. ```java public static DataType [] newSimpleDataTypeArray(Type... types) { DataType [] dataTypes = new DataType [types.length] ; for (int i = 0; i < types.length; i++) { dataTypes[i] = DataType.newBuilder().setType(types[i]).build(); } return dataTypes; } ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/refactoring-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/542.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #542 commit 539069dab0c94b40c5d603059f1964b47a2c8d3f Author: clark.kang <clark.kang@kakao.com> Date: 2015-04-18T06:44:44Z refactoring
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/542#issuecomment-94263436

        This change is trivial, but will reduce many mistakes.
        Would you trigger Travis or Jenkins again after rebasing?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/542#issuecomment-94263436 This change is trivial, but will reduce many mistakes. Would you trigger Travis or Jenkins again after rebasing?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam commented on the pull request:

        https://github.com/apache/tajo/pull/542#issuecomment-94270314

        @jihoonson I rebased it. and it passed

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam commented on the pull request: https://github.com/apache/tajo/pull/542#issuecomment-94270314 @jihoonson I rebased it. and it passed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/542#issuecomment-94270352

        +1 thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/542#issuecomment-94270352 +1 thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/542

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/542
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to the master.
        Thanks DaeMyung Kang!

        Show
        jihoonson Jihoon Son added a comment - Committed to the master. Thanks DaeMyung Kang !
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #316 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/316/)
        TAJO-1570: CatalogUtil newSimpleDataTypeArray should use newSimpleDataType. (jihoonson: rev 1bceb0e11ae6626e0aa2a603fab984d16105c849)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #316 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/316/ ) TAJO-1570 : CatalogUtil newSimpleDataTypeArray should use newSimpleDataType. (jihoonson: rev 1bceb0e11ae6626e0aa2a603fab984d16105c849) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #678 (See https://builds.apache.org/job/Tajo-master-build/678/)
        TAJO-1570: CatalogUtil newSimpleDataTypeArray should use newSimpleDataType. (jihoonson: rev 1bceb0e11ae6626e0aa2a603fab984d16105c849)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #678 (See https://builds.apache.org/job/Tajo-master-build/678/ ) TAJO-1570 : CatalogUtil newSimpleDataTypeArray should use newSimpleDataType. (jihoonson: rev 1bceb0e11ae6626e0aa2a603fab984d16105c849) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java CHANGES

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development