Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1568

Apply UnpooledByteBufAllocator when a tajo.test.enabled is set to enable

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Offheap, Unit Test
    • Labels:
      None

      Description

      We are investigating the frequent failures of Travis CI.
      My guess, It may be OOM.

      1. TAJO-1568_2.patch
        8 kB
        Jinho Kim
      2. TAJO-1568.patch
        4 kB
        Jinho Kim

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jinossy opened a pull request:

          https://github.com/apache/tajo/pull/540

          TAJO-1568: Reduce the size of the storage buffer for testing.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jinossy/tajo TAJO-1568

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/540.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #540


          commit 379cb68ce357aeaaf147632aebd1f44733340873
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-17T15:37:34Z

          TAJO-1568: Reduce the size of the storage buffer for testing.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/540 TAJO-1568 : Reduce the size of the storage buffer for testing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1568 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/540.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #540 commit 379cb68ce357aeaaf147632aebd1f44733340873 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-17T15:37:34Z TAJO-1568 : Reduce the size of the storage buffer for testing.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726178/TAJO-1568.patch
          against master revision release-0.9.0-rc0-259-g14a1e53.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 26 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-core tajo-storage/tajo-storage-common.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/742//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/742//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/742//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/742//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726178/TAJO-1568.patch against master revision release-0.9.0-rc0-259-g14a1e53. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 26 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-storage/tajo-storage-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/742//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/742//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/742//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/742//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/540#issuecomment-94274961

          BufferPool allocator is to be UnpooledByteBufAllocator when a tajo.test.enabled is set to enable.
          IMO, we don’t need pooling for testing.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/540#issuecomment-94274961 BufferPool allocator is to be UnpooledByteBufAllocator when a tajo.test.enabled is set to enable. IMO, we don’t need pooling for testing.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726438/TAJO-1568_2.patch
          against master revision release-0.9.0-rc0-265-g1bceb0e.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 26 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-common tajo-core tajo-storage/tajo-storage-common.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/748//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/748//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/748//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/748//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726438/TAJO-1568_2.patch against master revision release-0.9.0-rc0-265-g1bceb0e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 26 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core tajo-storage/tajo-storage-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/748//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/748//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/748//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/748//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/540#issuecomment-94335153

          +1 thanks for your nice work!
          This patch will fix the problem of jvm crash!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/540#issuecomment-94335153 +1 thanks for your nice work! This patch will fix the problem of jvm crash!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/540#issuecomment-94335805

          Thank you for quick review!!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/540#issuecomment-94335805 Thank you for quick review!!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/540

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/540
          Hide
          jhkim Jinho Kim added a comment -

          committed it

          Show
          jhkim Jinho Kim added a comment - committed it
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/524#issuecomment-94342826

          resolved by TAJO-1568

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/524#issuecomment-94342826 resolved by TAJO-1568
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #318 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/318/)
          TAJO-1568: Apply UnpooledByteBufAllocator when a tajo.test.enabled is set to enable. (jinho) (jhkim: rev 0a1a41d258b083810601fb5790d423a5763f5051)

          • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java
          • CHANGES
          • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/BufferPool.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #318 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/318/ ) TAJO-1568 : Apply UnpooledByteBufAllocator when a tajo.test.enabled is set to enable. (jinho) (jhkim: rev 0a1a41d258b083810601fb5790d423a5763f5051) tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java CHANGES tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/BufferPool.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-build #680 (See https://builds.apache.org/job/Tajo-master-build/680/)
          TAJO-1568: Apply UnpooledByteBufAllocator when a tajo.test.enabled is set to enable. (jinho) (jhkim: rev 0a1a41d258b083810601fb5790d423a5763f5051)

          • tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java
          • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/BufferPool.java
          • CHANGES
          • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #680 (See https://builds.apache.org/job/Tajo-master-build/680/ ) TAJO-1568 : Apply UnpooledByteBufAllocator when a tajo.test.enabled is set to enable. (jinho) (jhkim: rev 0a1a41d258b083810601fb5790d423a5763f5051) tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/BufferPool.java CHANGES tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development