Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.0, 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Unit Test
    • Labels:
      None

      Description

      The problem is that channel is closed before state is changed.

      Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.859 sec <<< FAILURE! - in org.apache.tajo.worker.TestFetcher
      testNoContentFetch(org.apache.tajo.worker.TestFetcher)  Time elapsed: 0.531 sec  <<< FAILURE!
      java.lang.AssertionError: expected:<FETCH_FINISHED> but was:<FETCH_FETCHING>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:743)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:144)
      	at org.apache.tajo.worker.TestFetcher.testNoContentFetch(TestFetcher.java:172)
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #674 (See https://builds.apache.org/job/Tajo-master-build/674/)
        TAJO-1564: TestFetcher fails occasionally. (jinho) (jhkim: rev 048af99fdd765fdcd0d3ab100a4773e89ca4efb2)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #674 (See https://builds.apache.org/job/Tajo-master-build/674/ ) TAJO-1564 : TestFetcher fails occasionally. (jinho) (jhkim: rev 048af99fdd765fdcd0d3ab100a4773e89ca4efb2) CHANGES tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #312 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/312/)
        TAJO-1564: TestFetcher fails occasionally. (jinho) (jhkim: rev 048af99fdd765fdcd0d3ab100a4773e89ca4efb2)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #312 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/312/ ) TAJO-1564 : TestFetcher fails occasionally. (jinho) (jhkim: rev 048af99fdd765fdcd0d3ab100a4773e89ca4efb2) CHANGES tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        Hide
        jhkim Jinho Kim added a comment -

        Committed it.
        Thanks

        Show
        jhkim Jinho Kim added a comment - Committed it. Thanks
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/537

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/537
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/537#issuecomment-93957178

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/537#issuecomment-93957178 +1 LGTM!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726099/TAJO-1564.patch
        against master revision release-0.9.0-rc0-258-gd2a4f9b.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/738//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/738//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/738//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726099/TAJO-1564.patch against master revision release-0.9.0-rc0-258-gd2a4f9b. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/738//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/738//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/738//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/537

        TAJO-1564: TestFetcher fails occasionally.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1564

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/537.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #537


        commit 857e34fdd8718680ded398dcf10e7a1e6cce03bb
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-04-17T07:52:51Z

        TAJO-1564: TestFetcher fails occasionally.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/537 TAJO-1564 : TestFetcher fails occasionally. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1564 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/537.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #537 commit 857e34fdd8718680ded398dcf10e7a1e6cce03bb Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-17T07:52:51Z TAJO-1564 : TestFetcher fails occasionally.

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development