Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1510

Change a function name from getFileCunks to getFileChunks

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      I think the following function name should be changed:

      -  public static FileChunk getFileCunks(Path outDir,
      -                                      String startKey,
      -                                      String endKey,
      -                                      boolean last) throws IOException {
      +  public static FileChunk getFileChunks(Path outDir,
      +                                        String startKey,
      +                                        String endKey,
      +                                        boolean last) throws IOException {
      1. TAJO-1510.patch
        3 kB
        Soonwoong Lee

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #654 (See https://builds.apache.org/job/Tajo-master-build/654/)
        TAJO-1510: Change a function name from getFileCunks to getFileChunks. (blrunner: rev 4eb8713326d5f049df577e49c1a2e629b3ee8096)

        • CHANGES
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #654 (See https://builds.apache.org/job/Tajo-master-build/654/ ) TAJO-1510 : Change a function name from getFileCunks to getFileChunks. (blrunner: rev 4eb8713326d5f049df577e49c1a2e629b3ee8096) CHANGES tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #292 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/292/)
        TAJO-1510: Change a function name from getFileCunks to getFileChunks. (blrunner: rev 4eb8713326d5f049df577e49c1a2e629b3ee8096)

        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • CHANGES
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #292 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/292/ ) TAJO-1510 : Change a function name from getFileCunks to getFileChunks. (blrunner: rev 4eb8713326d5f049df577e49c1a2e629b3ee8096) tajo-core/src/main/java/org/apache/tajo/worker/Task.java CHANGES tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        Hide
        blrunner Jaehwa Jung added a comment -

        I've just committed this to the master branch.

        Show
        blrunner Jaehwa Jung added a comment - I've just committed this to the master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/499

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/499
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/499#issuecomment-89899405

        +1

        Thanks for your contribution.
        I'll ship it soon.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/499#issuecomment-89899405 +1 Thanks for your contribution. I'll ship it soon.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user swlsw opened a pull request:

        https://github.com/apache/tajo/pull/499

        TAJO-1510: Change a function name from getFileCunks to getFileChunks

        Trivial changes.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/swlsw/tajo TAJO-1510

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/499.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #499


        commit 76918ef14881d81b6dd1109c1b833e15d9485e79
        Author: swlsw <soonwoong.lee@gmail.com>
        Date: 2015-04-02T11:15:19Z

        TAJO-1510: Change a function name from getFileCunks to getFileChunks


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user swlsw opened a pull request: https://github.com/apache/tajo/pull/499 TAJO-1510 : Change a function name from getFileCunks to getFileChunks Trivial changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swlsw/tajo TAJO-1510 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/499.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #499 commit 76918ef14881d81b6dd1109c1b833e15d9485e79 Author: swlsw <soonwoong.lee@gmail.com> Date: 2015-04-02T11:15:19Z TAJO-1510 : Change a function name from getFileCunks to getFileChunks
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12708968/TAJO-1510.patch
        against master revision release-0.9.0-rc0-234-gf4c9e54.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-pullserver.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/692//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/692//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/692//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708968/TAJO-1510.patch against master revision release-0.9.0-rc0-234-gf4c9e54. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-pullserver. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/692//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/692//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/692//console This message is automatically generated.

          People

          • Assignee:
            swlsw Soonwoong Lee
            Reporter:
            swlsw Soonwoong Lee
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development