Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1509

Use dedicated thread to release resource allocated to container

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Resource Manager
    • Labels:
      None

      Description

      Currently, it uses thread pool, which is used for launching tasks. But it can make dead-lock situation.

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        It was merged. so I close this

        Show
        jhkim Jinho Kim added a comment - It was merged. so I close this
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-92588526

        I think it doesn't matter how you record it. You can use the ```--signoff``` option or just write by hand in the log.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-92588526 I think it doesn't matter how you record it. You can use the ```--signoff``` option or just write by hand in the log.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-92585739

        @jihoonson Do you mean I should use "--signoff" git option when commit?

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-92585739 @jihoonson Do you mean I should use "--signoff" git option when commit?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-92362502

        @babokim, it seems that the commit log does not include who committed this patch. Please add it from the next commit.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-92362502 @babokim, it seems that the commit log does not include who committed this patch. Please add it from the next commit.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #665 (See https://builds.apache.org/job/Tajo-master-build/665/)
        TAJO-1509 Use dedicated thread to release resource allocated to container (babokim: rev d57b16fe68986d42a143da87162d89a672aec792)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
        • tajo-core/src/main/java/org/apache/tajo/master/ContainerProxy.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NullCallback.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #665 (See https://builds.apache.org/job/Tajo-master-build/665/ ) TAJO-1509 Use dedicated thread to release resource allocated to container (babokim: rev d57b16fe68986d42a143da87162d89a672aec792) tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-core/src/main/java/org/apache/tajo/master/ContainerProxy.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NullCallback.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #303 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/303/)
        TAJO-1509 Use dedicated thread to release resource allocated to container (babokim: rev d57b16fe68986d42a143da87162d89a672aec792)

        • tajo-core/src/main/java/org/apache/tajo/master/ContainerProxy.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
        • CHANGES
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NullCallback.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #303 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/303/ ) TAJO-1509 Use dedicated thread to release resource allocated to container (babokim: rev d57b16fe68986d42a143da87162d89a672aec792) tajo-core/src/main/java/org/apache/tajo/master/ContainerProxy.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java CHANGES tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NullCallback.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/501

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/501
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user navis commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-92216211

        Sure, I'm busy on learning the greatness of SK group till next week.

        2015년 4월 13일 월요일, Hyoungjun Kim<notifications@github.com>님이 작성한 메시지:

        > @navis <https://github.com/navis> I think you may very busy to resolve
        > other issues. If you don't mind I will reflect what I commented before
        > committing.
        >
        > —
        > Reply to this email directly or view it on GitHub
        > <https://github.com/apache/tajo/pull/501#issuecomment-92215138>.
        >

        Show
        githubbot ASF GitHub Bot added a comment - Github user navis commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-92216211 Sure, I'm busy on learning the greatness of SK group till next week. 2015년 4월 13일 월요일, Hyoungjun Kim<notifications@github.com>님이 작성한 메시지: > @navis < https://github.com/navis > I think you may very busy to resolve > other issues. If you don't mind I will reflect what I commented before > committing. > > — > Reply to this email directly or view it on GitHub > < https://github.com/apache/tajo/pull/501#issuecomment-92215138 >. >
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-92215138

        @navis I think you may very busy to resolve other issues. If you don't mind I will reflect what I commented before committing.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-92215138 @navis I think you may very busy to resolve other issues. If you don't mind I will reflect what I commented before committing.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-91199211

        @navis, thank you for your contribution. This patch looks good to me except one trivial variable name concern.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-91199211 @navis, thank you for your contribution. This patch looks good to me except one trivial variable name concern.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/501#discussion_r28053517

        — Diff: tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java —
        @@ -68,6 +73,7 @@
        private TajoConf tajoConf;
        private QueryMasterTask.QueryMasterTaskContext queryTaskContext;
        private final ExecutorService executorService;
        — End diff –

        "allocationExecutor" is to be more appropriate than "executorService".

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on a diff in the pull request: https://github.com/apache/tajo/pull/501#discussion_r28053517 — Diff: tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java — @@ -68,6 +73,7 @@ private TajoConf tajoConf; private QueryMasterTask.QueryMasterTaskContext queryTaskContext; private final ExecutorService executorService; — End diff – "allocationExecutor" is to be more appropriate than "executorService".
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-90823322

        @navis I'll review this patch tonight.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-90823322 @navis I'll review this patch tonight.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user navis commented on the pull request:

        https://github.com/apache/tajo/pull/501#issuecomment-90821113

        Can anyone review this?

        Show
        githubbot ASF GitHub Bot added a comment - Github user navis commented on the pull request: https://github.com/apache/tajo/pull/501#issuecomment-90821113 Can anyone review this?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/501

        TAJO-1509 Use dedicated thread to release resource allocated to container

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1509

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/501.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #501


        commit 972f46242727d54c5c9937bc81ad1088ab847b94
        Author: navis.ryu <navis@apache.org>
        Date: 2015-04-03T00:07:54Z

        TAJO-1509 Use dedicated thread to release resource allocated to container


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/501 TAJO-1509 Use dedicated thread to release resource allocated to container You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1509 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/501.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #501 commit 972f46242727d54c5c9937bc81ad1088ab847b94 Author: navis.ryu <navis@apache.org> Date: 2015-04-03T00:07:54Z TAJO-1509 Use dedicated thread to release resource allocated to container

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development