Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      Currently, NPE occurs during startup MySQLStore on initial state as following:

      Caused by: java.lang.NullPointerException
      	at org.apache.tajo.util.FileUtil.readTextFromStream(FileUtil.java:99)
      	at org.apache.tajo.util.FileUtil.readTextFileFromResource(FileUtil.java:90)
      	at org.apache.tajo.catalog.store.AbstractDBStore.readSchemaFile(AbstractDBStore.java:174)
      	at org.apache.tajo.catalog.store.AbstractMySQLMariaDBStore.readSchemaFile(AbstractMySQLMariaDBStore.java:68)
      	at org.apache.tajo.catalog.store.MySQLStore.readSchemaFile(MySQLStore.java:52)
      	at org.apache.tajo.catalog.store.AbstractMySQLMariaDBStore.createBaseTable(AbstractMySQLMariaDBStore.java:209)
      	at org.apache.tajo.catalog.store.AbstractDBStore.<init>(AbstractDBStore.java:152)
      

      For the reference, there are similar situations at other CatalogStores, such as, MariaDB, Oracle, PostgreSQL.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user blrunner opened a pull request:

          https://github.com/apache/tajo/pull/481

          TAJO-1479: NPE during startup AbstractMySQLMariaDBStore

          I succeed to startup MySQLStore on my local cluster. For the reference, I fixed some typos about partition tables.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/blrunner/tajo TAJO-1479

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/481.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #481


          commit daed3524b3f6a00a58348170fd501d05247ffc13
          Author: JaeHwa Jung <blrunner@apache.org>
          Date: 2015-03-30T13:40:40Z

          TAJO-1479: NPE during startup AbstractMySQLMariaDBStore


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/481 TAJO-1479 : NPE during startup AbstractMySQLMariaDBStore I succeed to startup MySQLStore on my local cluster. For the reference, I fixed some typos about partition tables. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1479 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/481.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #481 commit daed3524b3f6a00a58348170fd501d05247ffc13 Author: JaeHwa Jung <blrunner@apache.org> Date: 2015-03-30T13:40:40Z TAJO-1479 : NPE during startup AbstractMySQLMariaDBStore
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/481#issuecomment-87945969

          +1
          ship it!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/481#issuecomment-87945969 +1 ship it!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/481#issuecomment-87946495

          Thanks @jihoonson

          I'll ship it soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/481#issuecomment-87946495 Thanks @jihoonson I'll ship it soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/481#issuecomment-87960922

          @jihoonson

          I've just fixed other typos for postgresql.
          Could you check it again?

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/481#issuecomment-87960922 @jihoonson I've just fixed other typos for postgresql. Could you check it again?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/481#issuecomment-87978841

          +1
          The patch LGTM.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/481#issuecomment-87978841 +1 The patch LGTM.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708353/TAJO-1479.patch
          against master revision release-0.9.0-rc0-226-g652e4db.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/681//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/681//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/681//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708353/TAJO-1479.patch against master revision release-0.9.0-rc0-226-g652e4db. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/681//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/681//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/681//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/481

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/481
          Hide
          blrunner Jaehwa Jung added a comment -

          Thanks Jihoon Son

          I've just committed it to the master branch.

          Show
          blrunner Jaehwa Jung added a comment - Thanks Jihoon Son I've just committed it to the master branch.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-CODEGEN-build #276 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/276/)
          TAJO-1479: NPE during startup CatalogStore. (jaehwa) (blrunner: rev 487a0e51af980eda1b00476cdc999f29b28cc8e3)

          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml
          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractMySQLMariaDBStore.java
          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_keys.sql
          • CHANGES
          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partition_keys.sql
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #276 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/276/ ) TAJO-1479 : NPE during startup CatalogStore. (jaehwa) (blrunner: rev 487a0e51af980eda1b00476cdc999f29b28cc8e3) tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractMySQLMariaDBStore.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_keys.sql CHANGES tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partition_keys.sql
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #639 (See https://builds.apache.org/job/Tajo-master-build/639/)
          TAJO-1479: NPE during startup CatalogStore. (jaehwa) (blrunner: rev 487a0e51af980eda1b00476cdc999f29b28cc8e3)

          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractMySQLMariaDBStore.java
          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_keys.sql
          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partition_keys.sql
          • CHANGES
          • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #639 (See https://builds.apache.org/job/Tajo-master-build/639/ ) TAJO-1479 : NPE during startup CatalogStore. (jaehwa) (blrunner: rev 487a0e51af980eda1b00476cdc999f29b28cc8e3) tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractMySQLMariaDBStore.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_keys.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partition_keys.sql CHANGES tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml

            People

            • Assignee:
              blrunner Jaehwa Jung
              Reporter:
              blrunner Jaehwa Jung
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development