Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1454

Comparing two date or two timestamp need not normalizing

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      date and timestamp types are converted to normalized form (TimeMeta) for comparing even between datum with same type.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/467

        TAJO-1454 Comparing two date or two timestamp need not normalizing

        Simplified compare logic & fixed some bugs

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1454

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/467.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #467


        commit b914fc54c868e1004e80b557ac44369e0cc8f883
        Author: navis.ryu <navis@apache.org>
        Date: 2015-03-27T02:37:16Z

        TAJO-1454 Comparing two date or two timestamp need not normalizing


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/467 TAJO-1454 Comparing two date or two timestamp need not normalizing Simplified compare logic & fixed some bugs You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1454 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/467.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #467 commit b914fc54c868e1004e80b557ac44369e0cc8f883 Author: navis.ryu <navis@apache.org> Date: 2015-03-27T02:37:16Z TAJO-1454 Comparing two date or two timestamp need not normalizing
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user navis commented on the pull request:

        https://github.com/apache/tajo/pull/467#issuecomment-87584147

        Included jdk-7 method by mistake. Sorry

        Show
        githubbot ASF GitHub Bot added a comment - Github user navis commented on the pull request: https://github.com/apache/tajo/pull/467#issuecomment-87584147 Included jdk-7 method by mistake. Sorry
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/467#issuecomment-91549207

        This patch looks good to me. Here is my +1.
        I'll commit this soon.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/467#issuecomment-91549207 This patch looks good to me. Here is my +1. I'll commit this soon.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/467

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/467
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #301 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/301/)
        TAJO-1454 Comparing two date or two timestamp need not normalizing (babokim: rev 6136142e370d9fba88c88379f67033312621c10f)

        • tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToDate.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/datum/IntervalDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #301 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/301/ ) TAJO-1454 Comparing two date or two timestamp need not normalizing (babokim: rev 6136142e370d9fba88c88379f67033312621c10f) tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToDate.java tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java CHANGES tajo-common/src/main/java/org/apache/tajo/datum/IntervalDatum.java tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #663 (See https://builds.apache.org/job/Tajo-master-build/663/)
        TAJO-1454 Comparing two date or two timestamp need not normalizing (babokim: rev 6136142e370d9fba88c88379f67033312621c10f)

        • tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToDate.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        • tajo-common/src/main/java/org/apache/tajo/datum/IntervalDatum.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #663 (See https://builds.apache.org/job/Tajo-master-build/663/ ) TAJO-1454 Comparing two date or two timestamp need not normalizing (babokim: rev 6136142e370d9fba88c88379f67033312621c10f) tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java CHANGES tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToDate.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-common/src/main/java/org/apache/tajo/datum/IntervalDatum.java

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development