Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      Currently, Hive has been released to 1.1.0. Also from Hive 0.14.0, it changed hcatalog package name. But Tajo just provides hive 0.12.0 and hive 0.13.1. Thus, we need to improve hive compatibility. For this issue, I’ll remove hcatalog dependency. It’s not problem because hcatalog just has been used to find hive data types and Tajo can find right data types with Hive serdeConstants.

      1. TAJO-1442_2.patch
        249 kB
        Jaehwa Jung
      2. TAJO-1442.patch
        259 kB
        Jaehwa Jung

        Issue Links

          Activity

          Hide
          jihoonson Jihoon Son added a comment -

          Right. It was due to the remaining generated codes.
          Thanks for sharing your solution.

          Show
          jihoonson Jihoon Son added a comment - Right. It was due to the remaining generated codes. Thanks for sharing your solution.
          Hide
          sirpkt Keuntae Park added a comment - - edited

          I also experienced the same test failure as Jihoon Son.
          But, failure is removed after manually deleting the directory 'tajo-catalog/tajo-hcatalog'.
          I think it is because of the generated files from previous source code.
          If someone else experiences the same,
          please check the directory I mentioned above.

          Show
          sirpkt Keuntae Park added a comment - - edited I also experienced the same test failure as Jihoon Son . But, failure is removed after manually deleting the directory 'tajo-catalog/tajo-hcatalog'. I think it is because of the generated files from previous source code. If someone else experiences the same, please check the directory I mentioned above.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #671 (See https://builds.apache.org/job/Tajo-master-build/671/)
          TAJO-1442: Improve Hive Compatibility. (missing file) (blrunner: rev d2a4f9b3d668010d2adfddc9693efe4ef7d5bcb6)

          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #671 (See https://builds.apache.org/job/Tajo-master-build/671/ ) TAJO-1442 : Improve Hive Compatibility. (missing file) (blrunner: rev d2a4f9b3d668010d2adfddc9693efe4ef7d5bcb6) CHANGES
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #309 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/309/)
          TAJO-1442: Improve Hive Compatibility. (missing file) (blrunner: rev d2a4f9b3d668010d2adfddc9693efe4ef7d5bcb6)

          • CHANGES
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #309 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/309/ ) TAJO-1442 : Improve Hive Compatibility. (missing file) (blrunner: rev d2a4f9b3d668010d2adfddc9693efe4ef7d5bcb6) CHANGES
          Hide
          blrunner Jaehwa Jung added a comment -

          I've just committed this to the master branch.

          Show
          blrunner Jaehwa Jung added a comment - I've just committed this to the master branch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-build #670 (See https://builds.apache.org/job/Tajo-master-build/670/)
          TAJO-1442: Improve Hive Compatibility (blrunner: rev 955a7bf84ec44e2ae301cd5775760166da5fbcc2)

          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java
          • tajo-docs/src/main/sphinx/hcatalog_integration.rst
          • tajo-dist/src/main/conf/tajo-env.sh
          • tajo-docs/src/main/sphinx/configuration/catalog_configuration.rst
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStoreClientPool.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java
          • tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hcatalog.sql
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
          • tajo-core/pom.xml
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
          • tajo-docs/src/main/sphinx/index.rst
          • .travis.yml
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java
          • tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hive_catalog.sql
          • tajo-docs/src/main/sphinx/hive_integration.rst
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
          • tajo-dist/src/main/conf/catalog-site.xml.template
          • tajo-dist/src/main/bin/tajo
          • tajo-project/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
          • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/test/java/org/apache/tajo/catalog/store/TestHiveCatalogStore.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
          • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml
          • tajo-catalog/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
          • tajo-catalog/tajo-catalog-drivers/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          • tajo-dist/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
          • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #670 (See https://builds.apache.org/job/Tajo-master-build/670/ ) TAJO-1442 : Improve Hive Compatibility (blrunner: rev 955a7bf84ec44e2ae301cd5775760166da5fbcc2) tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java tajo-docs/src/main/sphinx/hcatalog_integration.rst tajo-dist/src/main/conf/tajo-env.sh tajo-docs/src/main/sphinx/configuration/catalog_configuration.rst tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStoreClientPool.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hcatalog.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-core/pom.xml tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml tajo-core/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java tajo-docs/src/main/sphinx/index.rst .travis.yml tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hive_catalog.sql tajo-docs/src/main/sphinx/hive_integration.rst tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java tajo-dist/src/main/conf/catalog-site.xml.template tajo-dist/src/main/bin/tajo tajo-project/pom.xml tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/test/java/org/apache/tajo/catalog/store/TestHiveCatalogStore.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml tajo-catalog/pom.xml tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java tajo-catalog/tajo-catalog-drivers/pom.xml tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-dist/pom.xml tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #308 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/308/)
          TAJO-1442: Improve Hive Compatibility (blrunner: rev 955a7bf84ec44e2ae301cd5775760166da5fbcc2)

          • tajo-docs/src/main/sphinx/hcatalog_integration.rst
          • tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hive_catalog.sql
          • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/test/java/org/apache/tajo/catalog/store/TestHiveCatalogStore.java
          • tajo-docs/src/main/sphinx/index.rst
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStoreClientPool.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
          • tajo-catalog/tajo-catalog-drivers/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java
          • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          • .travis.yml
          • tajo-dist/src/main/conf/catalog-site.xml.template
          • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-dist/src/main/conf/tajo-env.sh
          • tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hcatalog.sql
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
          • tajo-catalog/pom.xml
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
          • tajo-dist/pom.xml
          • tajo-project/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
          • tajo-docs/src/main/sphinx/hive_integration.rst
          • tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml
          • tajo-core/pom.xml
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
          • tajo-docs/src/main/sphinx/configuration/catalog_configuration.rst
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
          • tajo-dist/src/main/bin/tajo
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #308 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/308/ ) TAJO-1442 : Improve Hive Compatibility (blrunner: rev 955a7bf84ec44e2ae301cd5775760166da5fbcc2) tajo-docs/src/main/sphinx/hcatalog_integration.rst tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hive_catalog.sql tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/test/java/org/apache/tajo/catalog/store/TestHiveCatalogStore.java tajo-docs/src/main/sphinx/index.rst tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStoreClientPool.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-catalog/tajo-catalog-drivers/pom.xml tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java .travis.yml tajo-dist/src/main/conf/catalog-site.xml.template tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-dist/src/main/conf/tajo-env.sh tajo-core/src/test/resources/queries/TestCreateTable/create_table_various_types_for_hcatalog.sql tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java tajo-catalog/pom.xml tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java tajo-dist/pom.xml tajo-project/pom.xml tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-docs/src/main/sphinx/hive_integration.rst tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml tajo-core/pom.xml tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-docs/src/main/sphinx/configuration/catalog_configuration.rst tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-dist/src/main/bin/tajo tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/453

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/453
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-93883531

          Thanks @jihoonson

          I'll commit this soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-93883531 Thanks @jihoonson I'll commit this soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-93756256

          +1
          It seems that there are some problems in my machine. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-93756256 +1 It seems that there are some problems in my machine. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-92215371

          @jihoonson

          The time delay was caused by source sync. After rebasing to the master branch, the build time took as follows.

          1. Apply TAJO-1442 patch

          • Total time: 19:13 min

          2. Apache Trunk code

          • Total time: 19:58 min
          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-92215371 @jihoonson The time delay was caused by source sync. After rebasing to the master branch, the build time took as follows. 1. Apply TAJO-1442 patch Total time: 19:13 min 2. Apache Trunk code Total time: 19:58 min
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-92157494

          @jihoonson

          Thank you for your review. I'll check it soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-92157494 @jihoonson Thank you for your review. I'll check it soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-92067696

          Hi @blrunner.
          With my laptop, ```mvn clean install -Pparallel-test -DLOG_LEVEL=WARN -Dmaven.fork.count=2``` is failed due to missing licences while testing on ```Tajo Catalog Drivers```. This seems due to some generated files.
          In addition, I found that the test time on ```Tajo Core``` is significantly increased from 13:58 min to 53:34 min.
          Would you check it?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-92067696 Hi @blrunner. With my laptop, ```mvn clean install -Pparallel-test -DLOG_LEVEL=WARN -Dmaven.fork.count=2``` is failed due to missing licences while testing on ```Tajo Catalog Drivers```. This seems due to some generated files. In addition, I found that the test time on ```Tajo Core``` is significantly increased from 13:58 min to 53:34 min. Would you check it?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-89677109

          Rebasing commits against the master branch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-89677109 Rebasing commits against the master branch.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707689/TAJO-1442_2.patch
          against master revision release-0.9.0-rc0-222-gb1e174e.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 17 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 5 release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-drivers/tajo-hive tajo-catalog/tajo-catalog-server tajo-core tajo-dist.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/664//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/664//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/664//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/664//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707689/TAJO-1442_2.patch against master revision release-0.9.0-rc0-222-gb1e174e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 5 release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-drivers/tajo-hive tajo-catalog/tajo-catalog-server tajo-core tajo-dist. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/664//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/664//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/664//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/664//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/453#issuecomment-86823979

          I removed old hive profiles. Because I had already removed hcatalog dependencies.
          For the reference, I found that Tajo had run successfully with hive, such as, hive-0.13.1, hive-0.14.0, hive-1.0.0, hive-1.1.0.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/453#issuecomment-86823979 I removed old hive profiles. Because I had already removed hcatalog dependencies. For the reference, I found that Tajo had run successfully with hive, such as, hive-0.13.1, hive-0.14.0, hive-1.0.0, hive-1.1.0.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12706509/TAJO-1442.patch
          against master revision release-0.9.0-rc0-214-g8d0146b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 17 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail.

          -1 release audit. The applied patch generated 5 release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-drivers/tajo-hive tajo-catalog/tajo-catalog-server tajo-core tajo-dist.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/644//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/644//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/644//findbugsResult
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/644//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706509/TAJO-1442.patch against master revision release-0.9.0-rc0-214-g8d0146b. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. -1 release audit. The applied patch generated 5 release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-drivers/tajo-hive tajo-catalog/tajo-catalog-server tajo-core tajo-dist. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/644//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/644//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/644//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/644//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user blrunner opened a pull request:

          https://github.com/apache/tajo/pull/453

          TAJO-1442: Improve Hive Compatibility

          I refactored HCatalogStore to HiveCatalogStore. And I added more hive profiles as follows: hive 0.14.0, hive 1.0.0, hive 1.1.0.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/blrunner/tajo TAJO-1442

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/453.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #453


          commit 7eab015c7471866d89a79057fc750332072c2f0a
          Author: JaeHwa Jung <blrunner@apache.org>
          Date: 2015-03-23T07:22:41Z

          TAJO-1442: Improve Hive Compatibility


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/453 TAJO-1442 : Improve Hive Compatibility I refactored HCatalogStore to HiveCatalogStore. And I added more hive profiles as follows: hive 0.14.0, hive 1.0.0, hive 1.1.0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1442 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/453.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #453 commit 7eab015c7471866d89a79057fc750332072c2f0a Author: JaeHwa Jung <blrunner@apache.org> Date: 2015-03-23T07:22:41Z TAJO-1442 : Improve Hive Compatibility

            People

            • Assignee:
              blrunner Jaehwa Jung
              Reporter:
              blrunner Jaehwa Jung
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development