Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1422

Investigate the case where fragments == null in SeqScanExec

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      See the following part in SeqScanExec. Intuitively, we don't need to make and execute Task if fragments is null. But, the current code requires null check. We need to investigate its essential cause, and we should remove this case if possible.

      SeqScanExec.java
          if (fragments != null) {
            if (fragments.length > 1) {
              this.scanner = new MergeScanner(context.getConf(), plan.getPhysicalSchema(), meta,
                  FragmentConvertor.convert(context.getConf(), fragments), projected
              );
      

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Thanks for your investigation. I'll close this issue as fixed, and then I'll make another jira in order to make this code better.

        Show
        hyunsik Hyunsik Choi added a comment - Thanks for your investigation. I'll close this issue as fixed, and then I'll make another jira in order to make this code better.
        Hide
        navis Navis added a comment -

        I've seen that in LeftOuter-Hash join case.

        Show
        navis Navis added a comment - I've seen that in LeftOuter-Hash join case.

          People

          • Assignee:
            Unassigned
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development