Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1405

Fix some illegal way of usages on connection pool

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: RPC
    • Labels:
      None

      Description

      As a follow-up of TAJO-1391, fix some invalid usages on connection pool.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/425

        TAJO-1405 Fix some illegal way of usages on connection pool

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1405

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/425.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #425


        commit f35eb1572a6960f379b2c1f468576b5262c24021
        Author: navis.ryu <navis@apache.org>
        Date: 2015-03-16T09:01:47Z

        TAJO-1405 Fix some illegal way of usages on connection pool


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/425 TAJO-1405 Fix some illegal way of usages on connection pool You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1405 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/425.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #425 commit f35eb1572a6960f379b2c1f468576b5262c24021 Author: navis.ryu <navis@apache.org> Date: 2015-03-16T09:01:47Z TAJO-1405 Fix some illegal way of usages on connection pool
        Hide
        sirpkt Keuntae Park added a comment -

        +1

        I experienced 'mvn clean install' failure with TAJO-1391 but this patch resolves that problem

        2015-03-16 16:11:41,618 INFO: org.apache.tajo.worker.TajoWorkerManagerService (stop(97)) - TajoWorkerManagerService stopped
        2015-03-16 16:11:41,619 INFO: org.apache.tajo.worker.TajoWorker (serviceStop(420)) - TajoWorker main thread exiting
        
        Results :
        
        Failed tests: 
          TestTajoClient.testCurrentDatabase:119 expected:<[default]> but was:<[testdropcurrentdatabase]>
        
        Tests in error: 
          TestTajoClient.testDropCurrentDatabase:163 ? Service org.apache.tajo.rpc.TajoS...
          TestTajoClient.testSelectDatabaseToInvalidOne:145 ? Service org.apache.tajo.rp...
          TestTajoClient.testGetQueryStatusAndResultAfterFinish:642 ?  test timed out af...
          TestTajoClient.testGetQueryInfoAndHistory:748 ?  test timed out after 30000 mi...
          TestTajoClient.testNullCharSessionInCTAS:694 ? Service relation "testdropcurre...
        
        Tests run: 1374, Failures: 1, Errors: 5, Skipped: 0
        
        [INFO] ------------------------------------------------------------------------
        
        Show
        sirpkt Keuntae Park added a comment - +1 I experienced 'mvn clean install' failure with TAJO-1391 but this patch resolves that problem 2015-03-16 16:11:41,618 INFO: org.apache.tajo.worker.TajoWorkerManagerService (stop(97)) - TajoWorkerManagerService stopped 2015-03-16 16:11:41,619 INFO: org.apache.tajo.worker.TajoWorker (serviceStop(420)) - TajoWorker main thread exiting Results : Failed tests: TestTajoClient.testCurrentDatabase:119 expected:<[ default ]> but was:<[testdropcurrentdatabase]> Tests in error: TestTajoClient.testDropCurrentDatabase:163 ? Service org.apache.tajo.rpc.TajoS... TestTajoClient.testSelectDatabaseToInvalidOne:145 ? Service org.apache.tajo.rp... TestTajoClient.testGetQueryStatusAndResultAfterFinish:642 ? test timed out af... TestTajoClient.testGetQueryInfoAndHistory:748 ? test timed out after 30000 mi... TestTajoClient.testNullCharSessionInCTAS:694 ? Service relation "testdropcurre... Tests run: 1374, Failures: 1, Errors: 5, Skipped: 0 [INFO] ------------------------------------------------------------------------
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/425

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/425
        Hide
        sirpkt Keuntae Park added a comment -

        Committed to the master branch.
        Thank you, Navis

        Show
        sirpkt Keuntae Park added a comment - Committed to the master branch. Thank you, Navis
        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        Hi Keuntae Park,

        Did you finish any review? I cannot see any +1. You must comply RTC (review then commit) rule. Also, you should share the test results or must wait for jenkins ci or Travis CI.

        Show
        hyunsik Hyunsik Choi added a comment - - edited Hi Keuntae Park , Did you finish any review? I cannot see any +1. You must comply RTC (review then commit) rule. Also, you should share the test results or must wait for jenkins ci or Travis CI.
        Hide
        jhkim Jinho Kim added a comment -

        Currently, master branch is failed. so I’ve change to blocker

        Show
        jhkim Jinho Kim added a comment - Currently, master branch is failed. so I’ve change to blocker
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi,

        I saw +1 later. That's no problem. But, you still should share your test results or wait for jenkins or travis CI results.

        Show
        hyunsik Hyunsik Choi added a comment - Hi, I saw +1 later. That's no problem. But, you still should share your test results or wait for jenkins or travis CI results.
        Hide
        sirpkt Keuntae Park added a comment -

        Sorry for my ambiguous comment.
        I posted +1 (as above comment) after I checked 'mvn clean install' pass with this patch.

        Show
        sirpkt Keuntae Park added a comment - Sorry for my ambiguous comment. I posted +1 (as above comment) after I checked 'mvn clean install' pass with this patch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #618 (See https://builds.apache.org/job/Tajo-master-build/618/)
        TAJO-1405: Fix some illegal way of usages on connection pool. (Contributed by navis, Committed by Keuntae Park) (sirpkt: rev 286b956795a4dc2efb72c97896d86ed1049485e3)

        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #618 (See https://builds.apache.org/job/Tajo-master-build/618/ ) TAJO-1405 : Fix some illegal way of usages on connection pool. (Contributed by navis, Committed by Keuntae Park) (sirpkt: rev 286b956795a4dc2efb72c97896d86ed1049485e3) tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #255 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/255/)
        TAJO-1405: Fix some illegal way of usages on connection pool. (Contributed by navis, Committed by Keuntae Park) (sirpkt: rev 286b956795a4dc2efb72c97896d86ed1049485e3)

        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #255 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/255/ ) TAJO-1405 : Fix some illegal way of usages on connection pool. (Contributed by navis, Committed by Keuntae Park) (sirpkt: rev 286b956795a4dc2efb72c97896d86ed1049485e3) tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java CHANGES
        Hide
        sirpkt Keuntae Park added a comment -

        Actually, I saw 'mvn clean install' failure before this patch.

        Show
        sirpkt Keuntae Park added a comment - Actually, I saw 'mvn clean install' failure before this patch.
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Hi, Jinho Kim. Could you share your failure result here, please?

        Show
        dongjoon Dongjoon Hyun added a comment - Hi, Jinho Kim . Could you share your failure result here, please?
        Show
        jhkim Jinho Kim added a comment - Dongjoon Hyun You can find our CI https://builds.apache.org/job/PreCommit-TAJO-Build/ https://travis-ci.org/apache/tajo/pull_requests https://travis-ci.org/apache/tajo/builds
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Thank you, Jinho Kim! I will check there from now.

        Show
        dongjoon Dongjoon Hyun added a comment - Thank you, Jinho Kim ! I will check there from now.
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Hi, Jinho Kim, the build of this patch seems to be succeeded now. Could you close this issue?

        https://travis-ci.org/apache/tajo/builds/54674072

        Show
        dongjoon Dongjoon Hyun added a comment - Hi, Jinho Kim , the build of this patch seems to be succeeded now. Could you close this issue? https://travis-ci.org/apache/tajo/builds/54674072
        Hide
        jhkim Jinho Kim added a comment -

        Dongjoon Hyun Sure, It looks good to me.
        Navis Thank you for your quick fix

        Show
        jhkim Jinho Kim added a comment - Dongjoon Hyun Sure, It looks good to me. Navis Thank you for your quick fix

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development