Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1395

Remove deprecated sql files for Oracle and PostgreSQL

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: None
    • Labels:
      None

      Description

      SQL files and statements are removed from Java files for extensibility (TAJO-1109), however, some deprecated sql files are remained. These files will give users some confusion, and it would be better to remove.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/415

        TAJO-1395: Remove deprecated sql files for Oracle and PostgreSQL

        These sql files are still remained, and users can be confused. These files could be better to remove.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1395

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/415.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #415


        commit 1c7bd9617014e5607034394586bf63e7ca5505b0
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-03-12T03:53:36Z

        Removed deprecated sql files

        commit eb562402960fdc8235a6c5e4f13c6944c65b0671
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-03-12T03:54:29Z

        Merge remote-tracking branch 'upstream/master' into TAJO-1395


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/415 TAJO-1395 : Remove deprecated sql files for Oracle and PostgreSQL These sql files are still remained, and users can be confused. These files could be better to remove. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1395 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #415 commit 1c7bd9617014e5607034394586bf63e7ca5505b0 Author: Jihun Kang <jihun@apache.org> Date: 2015-03-12T03:53:36Z Removed deprecated sql files commit eb562402960fdc8235a6c5e4f13c6944c65b0671 Author: Jihun Kang <jihun@apache.org> Date: 2015-03-12T03:54:29Z Merge remote-tracking branch 'upstream/master' into TAJO-1395
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/415#issuecomment-78447388

        +1
        I've manually tested this patch with PostgreSQL. It works well.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/415#issuecomment-78447388 +1 I've manually tested this patch with PostgreSQL. It works well.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/415

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/415
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #249 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/249/)
        TAJO-1395: Remove deprecated sql files for Oracle and PostgreSQL (jihun: rev 6defbda966912ee2dd42197c2a82e94439b25bd8)

        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tables.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tables.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/columns.sql
        • CHANGES
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/table_properties.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/databases.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tablespaces.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tablespaces.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/databases.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partition_methods.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partitions.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/stats.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/table_properties.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partition_methods.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/columns.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partitions.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/indexes.sql
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #249 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/249/ ) TAJO-1395 : Remove deprecated sql files for Oracle and PostgreSQL (jihun: rev 6defbda966912ee2dd42197c2a82e94439b25bd8) tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tables.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tables.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/columns.sql CHANGES tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/table_properties.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/databases.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tablespaces.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tablespaces.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/databases.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partition_methods.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partitions.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/stats.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/table_properties.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partition_methods.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/columns.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partitions.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/indexes.sql
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #611 (See https://builds.apache.org/job/Tajo-master-build/611/)
        TAJO-1395: Remove deprecated sql files for Oracle and PostgreSQL (jihun: rev 6defbda966912ee2dd42197c2a82e94439b25bd8)

        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tablespaces.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/databases.sql
        • CHANGES
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/stats.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/table_properties.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/columns.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partition_methods.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/indexes.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partitions.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/columns.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tablespaces.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partition_methods.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/databases.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partitions.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/table_properties.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tables.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tables.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #611 (See https://builds.apache.org/job/Tajo-master-build/611/ ) TAJO-1395 : Remove deprecated sql files for Oracle and PostgreSQL (jihun: rev 6defbda966912ee2dd42197c2a82e94439b25bd8) tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tablespaces.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/databases.sql CHANGES tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/stats.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/table_properties.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/columns.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partition_methods.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/indexes.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partitions.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/columns.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tablespaces.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partition_methods.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/databases.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/partitions.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/table_properties.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/tables.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/tables.sql

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            ykrips Jihun Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development