Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1387

Correct error message for EXISTS clause

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Expression
    • Labels:
      None
    • Environment:

      Tajo 0.11.0-SNAPSHOT (rev. 69fd8d2 source checksum 2d2e9d2 compiled by dongjoon 2015-03-10T13:27Z)

      Description

      TSQL prints a wrong error message related `InPredicate` when EXISTS clause is used like following statement.


      default> select * from t1 where exists (select * from t1);
      ERROR: Can not set boolean field org.apache.tajo.algebra.InPredicate.not to org.apache.tajo.algebra.ExistsPredicate

      It should be like the following.

      default> select * from t1 where exists (select * from t1);
      select * from t1 where exists (select * from t1);
      ERROR: Cannot support EXISTS clause yet

      1. TAJO-1387.patch
        0.6 kB
        Dongjoon Hyun

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dongjoon-hyun opened a pull request:

        https://github.com/apache/tajo/pull/409

        TAJO-1387: Correct error message for EXISTS clause

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1387

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/409.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #409


        commit baf844973db9a48d61ebbe57281f3b6b227971dd
        Author: Dongjoon Hyun <dongjoon@apache.org>
        Date: 2015-03-10T13:41:50Z

        TAJO-1387: Correct error message for EXISTS clause


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/409 TAJO-1387 : Correct error message for EXISTS clause You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit baf844973db9a48d61ebbe57281f3b6b227971dd Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-03-10T13:41:50Z TAJO-1387 : Correct error message for EXISTS clause
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12703657/TAJO-1387.patch
        against master revision release-0.9.0-rc0-193-g69fd8d2.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-algebra.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/607//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/607//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703657/TAJO-1387.patch against master revision release-0.9.0-rc0-193-g69fd8d2. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-algebra. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/607//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/607//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/409#issuecomment-78128000

        +1

        The fix is straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/409#issuecomment-78128000 +1 The fix is straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/409

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/409
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #244 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/244/)
        TAJO-1387: Correct error message for EXISTS clause. (hyunsik: rev 13316bd26cbd7eedcc97c74f317ca743bd2eba5b)

        • CHANGES
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/ExistsPredicate.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #244 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/244/ ) TAJO-1387 : Correct error message for EXISTS clause. (hyunsik: rev 13316bd26cbd7eedcc97c74f317ca743bd2eba5b) CHANGES tajo-algebra/src/main/java/org/apache/tajo/algebra/ExistsPredicate.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #606 (See https://builds.apache.org/job/Tajo-master-build/606/)
        TAJO-1387: Correct error message for EXISTS clause. (hyunsik: rev 13316bd26cbd7eedcc97c74f317ca743bd2eba5b)

        • CHANGES
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/ExistsPredicate.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #606 (See https://builds.apache.org/job/Tajo-master-build/606/ ) TAJO-1387 : Correct error message for EXISTS clause. (hyunsik: rev 13316bd26cbd7eedcc97c74f317ca743bd2eba5b) CHANGES tajo-algebra/src/main/java/org/apache/tajo/algebra/ExistsPredicate.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.

          People

          • Assignee:
            dongjoon Dongjoon Hyun
            Reporter:
            dongjoon Dongjoon Hyun
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development