Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0, 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: Physical Operator
    • Labels:

      Description

      Currently, broadcast implementation keep a tuples on scan operator and It create a duplicated table cache in memory.
      We should improve it

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/404

        TAJO-1383: Improve broadcast table cache

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1383

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/404.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #404


        commit fabf69400df28e4badf283c1c3dd5f393fba2364
        Author: jhkim <jhkim@apache.org>
        Date: 2015-03-10T02:47:38Z

        TAJO-1383: Improve broadcast table cache


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/404 TAJO-1383 : Improve broadcast table cache You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1383 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #404 commit fabf69400df28e4badf283c1c3dd5f393fba2364 Author: jhkim <jhkim@apache.org> Date: 2015-03-10T02:47:38Z TAJO-1383 : Improve broadcast table cache
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12703579/TAJO-1383.patch
        against master revision release-0.9.0-rc0-193-g69fd8d2.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 56 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-plan.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/605//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/605//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/605//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/605//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703579/TAJO-1383.patch against master revision release-0.9.0-rc0-193-g69fd8d2. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 56 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/605//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/605//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/605//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/605//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78131199

        It causes severe memory consumption problem and performance degradation if queries involve broadcast, especially in high-end servers which allow many task concurrency. I'll review it today night.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78131199 It causes severe memory consumption problem and performance degradation if queries involve broadcast, especially in high-end servers which allow many task concurrency. I'll review it today night.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78246763

        The patch looks good in overall. However, it is difficult to understand details of some changes.
        Would you mind to give me a brief summarization of the changes?
        In addition, it would be great if you add some comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78246763 The patch looks good in overall. However, it is difficult to understand details of some changes. Would you mind to give me a brief summarization of the changes? In addition, it would be great if you add some comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78409742

        @jihoonson Sure,
        If a right table can broadcast, it does not share memory. so I’ve change to share the right table
        In addition, I’ve fix a hidden bugs.

        • Fix memory leak
        • Add missing property in protobuf idl

        Can you tell me lines ? I will be easy to add comments

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78409742 @jihoonson Sure, If a right table can broadcast, it does not share memory. so I’ve change to share the right table In addition, I’ve fix a hidden bugs. Fix memory leak Add missing property in protobuf idl Can you tell me lines ? I will be easy to add comments
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/404#discussion_r26273284

        — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ScanExec.java —
        @@ -0,0 +1,70 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.engine.planner.physical;
        +
        +import org.apache.tajo.catalog.Schema;
        +import org.apache.tajo.catalog.proto.CatalogProtos;
        +import org.apache.tajo.engine.planner.enforce.Enforcer;
        +import org.apache.tajo.ipc.TajoWorkerProtocol;
        +import org.apache.tajo.worker.TaskAttemptContext;
        +
        +import java.io.IOException;
        +import java.util.List;
        +
        +public abstract class ScanExec extends PhysicalExec {
        + private boolean canBroadcast;
        — End diff –

        Would you add some descriptions on this variable?
        It makes me confusing.
        Does it mean this scan is broadcasted or is a broadcast candidate?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/404#discussion_r26273284 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ScanExec.java — @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.engine.planner.physical; + +import org.apache.tajo.catalog.Schema; +import org.apache.tajo.catalog.proto.CatalogProtos; +import org.apache.tajo.engine.planner.enforce.Enforcer; +import org.apache.tajo.ipc.TajoWorkerProtocol; +import org.apache.tajo.worker.TaskAttemptContext; + +import java.io.IOException; +import java.util.List; + +public abstract class ScanExec extends PhysicalExec { + private boolean canBroadcast; — End diff – Would you add some descriptions on this variable? It makes me confusing. Does it mean this scan is broadcasted or is a broadcast candidate?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/404#discussion_r26273382

        — Diff: tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java —
        @@ -0,0 +1,81 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.engine.utils;
        +
        +import com.google.common.collect.Maps;
        +import org.apache.tajo.catalog.proto.CatalogProtos;
        +import org.apache.tajo.catalog.statistics.TableStats;
        +import org.apache.tajo.storage.Tuple;
        +import org.apache.tajo.storage.fragment.Fragment;
        +import org.apache.tajo.storage.fragment.FragmentConvertor;
        +import org.apache.tajo.util.Deallocatable;
        +import org.apache.tajo.worker.TaskAttemptContext;
        +
        +import java.io.IOException;
        +import java.util.List;
        +import java.util.Map;
        +
        +public interface CacheHolder<T> {
        +
        + T getData();
        + TableStats getTableStats();
        + void release();
        +
        + public static class BroadcastCacheHolder implements CacheHolder<Map<Tuple, List<Tuple>>> {
        — End diff –

        Would you add some descriptions for this class?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/404#discussion_r26273382 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java — @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.engine.utils; + +import com.google.common.collect.Maps; +import org.apache.tajo.catalog.proto.CatalogProtos; +import org.apache.tajo.catalog.statistics.TableStats; +import org.apache.tajo.storage.Tuple; +import org.apache.tajo.storage.fragment.Fragment; +import org.apache.tajo.storage.fragment.FragmentConvertor; +import org.apache.tajo.util.Deallocatable; +import org.apache.tajo.worker.TaskAttemptContext; + +import java.io.IOException; +import java.util.List; +import java.util.Map; + +public interface CacheHolder<T> { + + T getData(); + TableStats getTableStats(); + void release(); + + public static class BroadcastCacheHolder implements CacheHolder<Map<Tuple, List<Tuple>>> { — End diff – Would you add some descriptions for this class?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/404#discussion_r26273518

        — Diff: tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java —
        @@ -0,0 +1,81 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.engine.utils;
        +
        +import com.google.common.collect.Lists;
        +import com.google.common.collect.Maps;
        +import org.apache.commons.logging.Log;
        +import org.apache.commons.logging.LogFactory;
        +import org.apache.tajo.ExecutionBlockId;
        +
        +import java.util.List;
        +import java.util.Map;
        +
        +public class TableCache {
        — End diff –

        Would you add some descriptions on this class?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/404#discussion_r26273518 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java — @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.engine.utils; + +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.apache.tajo.ExecutionBlockId; + +import java.util.List; +import java.util.Map; + +public class TableCache { — End diff – Would you add some descriptions on this class?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78411489

        @jinossy thanks for your comment. It is very helpful.
        I left some comments for descriptions on classes and a variable.
        If a table is broadcasted, it seems that all tasks in a node share the same cache. It would be great if you can give detailed descriptions on this cache mechanism.
        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78411489 @jinossy thanks for your comment. It is very helpful. I left some comments for descriptions on classes and a variable. If a table is broadcasted, it seems that all tasks in a node share the same cache. It would be great if you can give detailed descriptions on this cache mechanism. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78455542

        I will add comments.
        Thanks

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78455542 I will add comments. Thanks
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78768311

        @jihoonson
        I've add some comments. Could you review again?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78768311 @jihoonson I've add some comments. Could you review again?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78813128

        +1
        Thanks for great work!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78813128 +1 Thanks for great work!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78837086

        This seems to be a performance improved issue. Intuitively, the changes look better than before. Nevertheless, it would be great if you share the benchmark results.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78837086 This seems to be a performance improved issue. Intuitively, the changes look better than before. Nevertheless, it would be great if you share the benchmark results.
        Hide
        githubbot ASF GitHub Bot added a comment - - edited

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78846800

        I was ran simple benchmark

        • Cluster : 1Master + 4Worker
        • TPC-H 100GB part of Q16
            select 
              p_brand, p_type, p_size, ps_suppkey
            from 
              partsupp ps join part p 
              on 
                p.p_partkey = ps.ps_partkey and p.p_brand <> 'Brand#45' 
                and not p.p_type like 'MEDIUM POLISHED%'
              join supplier_tmp s 
              on 
                ps.ps_suppkey = s.s_suppkey;
            
        • This is only join benchmark (broadcast table is "supplier_tmp")
        Broadcast execution time
        false 45 sec
        true 33 sec
        improved 22 sec
        Show
        githubbot ASF GitHub Bot added a comment - - edited Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78846800 I was ran simple benchmark Cluster : 1Master + 4Worker TPC-H 100GB part of Q16 select p_brand, p_type, p_size, ps_suppkey from partsupp ps join part p on p.p_partkey = ps.ps_partkey and p.p_brand <> 'Brand#45' and not p.p_type like 'MEDIUM POLISHED%' join supplier_tmp s on ps.ps_suppkey = s.s_suppkey; This is only join benchmark (broadcast table is "supplier_tmp") Broadcast execution time false 45 sec true 33 sec improved 22 sec
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78850741

        Here is my +1. The results look nice.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78850741 Here is my +1. The results look nice.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/404#issuecomment-78854246

        The evaluation result looks great!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/404#issuecomment-78854246 The evaluation result looks great!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/404

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/404
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks!

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #616 (See https://builds.apache.org/job/Tajo-master-build/616/)
        TAJO-1383: Improve broadcast table cache. (jinho) (jhkim: rev e1e38e231867e4f6f953a7ec41f5f9d5ad242580)

        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-core/src/test/java/org/apache/tajo/engine/util/TestTupleCache.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCacheKey.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockSharedResource.java
        • tajo-core/src/test/java/org/apache/tajo/engine/util/TestTableCache.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCache.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCacheKey.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java
        • tajo-plan/src/main/proto/Plan.proto
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #616 (See https://builds.apache.org/job/Tajo-master-build/616/ ) TAJO-1383 : Improve broadcast table cache. (jinho) (jhkim: rev e1e38e231867e4f6f953a7ec41f5f9d5ad242580) tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-core/src/test/java/org/apache/tajo/engine/util/TestTupleCache.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCacheKey.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockSharedResource.java tajo-core/src/test/java/org/apache/tajo/engine/util/TestTableCache.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCache.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCacheKey.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java tajo-plan/src/main/proto/Plan.proto tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #253 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/253/)
        TAJO-1383: Improve broadcast table cache. (jinho) (jhkim: rev e1e38e231867e4f6f953a7ec41f5f9d5ad242580)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockSharedResource.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java
        • tajo-plan/src/main/proto/Plan.proto
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCacheKey.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCache.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCacheKey.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/util/TestTableCache.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java
        • tajo-core/src/test/java/org/apache/tajo/engine/util/TestTupleCache.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #253 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/253/ ) TAJO-1383 : Improve broadcast table cache. (jinho) (jhkim: rev e1e38e231867e4f6f953a7ec41f5f9d5ad242580) tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockSharedResource.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java tajo-plan/src/main/proto/Plan.proto tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCacheKey.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCache.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleCacheKey.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java tajo-core/src/test/java/org/apache/tajo/engine/util/TestTableCache.java tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java tajo-core/src/test/java/org/apache/tajo/engine/util/TestTupleCache.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development