Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1370

TUtils.checkEquals() is not consistent with description in javadoc

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      It's saying "It will return true even if they are all null" but it's not.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/397

        TAJO-1370 TUtils.checkEquals() is not consistent with description in jav...

        IntelliJ said it's strange.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1370

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/397.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #397


        commit 71e3ebf9fe32846a5ea03d93916a79cb23f396bc
        Author: navis.ryu <navis@apache.org>
        Date: 2015-03-05T05:23:09Z

        TAJO-1370 TUtils.checkEquals() is not consistent with description in javadoc


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/397 TAJO-1370 TUtils.checkEquals() is not consistent with description in jav... IntelliJ said it's strange. You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1370 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/397.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #397 commit 71e3ebf9fe32846a5ea03d93916a79cb23f396bc Author: navis.ryu <navis@apache.org> Date: 2015-03-05T05:23:09Z TAJO-1370 TUtils.checkEquals() is not consistent with description in javadoc
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/396#issuecomment-77520848

        +1
        The change looks straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/396#issuecomment-77520848 +1 The change looks straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/396#issuecomment-77521438

        This patch is for TAJO-1369 rather than TAJO-1370. So, I'll change the commit log before committing it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/396#issuecomment-77521438 This patch is for TAJO-1369 rather than TAJO-1370 . So, I'll change the commit log before committing it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/396

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/396
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/397#issuecomment-77776998

        +1

        The change looks straightforward. Thank you for nice finding.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/397#issuecomment-77776998 +1 The change looks straightforward. Thank you for nice finding.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/397

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/397
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #600 (See https://builds.apache.org/job/Tajo-master-build/600/)
        TAJO-1370: TUtils.checkEquals() is not consistent with description in javadoc. (hyunsik: rev 6ba51c3cd3f20ce9c7e945d78b0cd2c4eaefc362)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #600 (See https://builds.apache.org/job/Tajo-master-build/600/ ) TAJO-1370 : TUtils.checkEquals() is not consistent with description in javadoc. (hyunsik: rev 6ba51c3cd3f20ce9c7e945d78b0cd2c4eaefc362) CHANGES tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #238 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/238/)
        TAJO-1370: TUtils.checkEquals() is not consistent with description in javadoc. (hyunsik: rev 6ba51c3cd3f20ce9c7e945d78b0cd2c4eaefc362)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #238 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/238/ ) TAJO-1370 : TUtils.checkEquals() is not consistent with description in javadoc. (hyunsik: rev 6ba51c3cd3f20ce9c7e945d78b0cd2c4eaefc362) CHANGES tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development