Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1313

Tajo-dump creates DDLs for information_schema tables

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: Catalog, SQL Shell
    • Labels:
      None

      Description

      Tajo-dump cli command creates DDLs for tables on 'information_schema' database. However, these tables are virtual tables and they could not be created on Tajo cluster. We need to skip creating table definitions for 'information_schema'.

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        I totally agree with you. tajo-dump must omit the virtual tables.

        Show
        hyunsik Hyunsik Choi added a comment - - edited I totally agree with you. tajo-dump must omit the virtual tables.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/365

        TAJO-1313: Tajo-dump creates DDLs for information_schema tables

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1313

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/365.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #365


        commit e1fb1d7df65202fb718d94591dc6adb7f832a8d0
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-01-29T02:06:11Z

        TAJO-1313: Tajo-dump creates DDLs for information_schema tables


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/365 TAJO-1313 : Tajo-dump creates DDLs for information_schema tables You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1313 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #365 commit e1fb1d7df65202fb718d94591dc6adb7f832a8d0 Author: Jihun Kang <jihun@apache.org> Date: 2015-01-29T02:06:11Z TAJO-1313 : Tajo-dump creates DDLs for information_schema tables
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/365#discussion_r23907667

        — Diff: tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java —
        @@ -116,6 +118,10 @@ public static void main(String [] args) throws ParseException, IOException, Serv

        System.exit(0);
        }
        +
        + private static boolean isAcceptableDumpingDatabase(String databaseName) {
        + return (databaseName == null || !databaseName.equalsIgnoreCase("information_schema"));
        — End diff –

        Could you change the ā€¯information_schema" to constants ?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/365#discussion_r23907667 — Diff: tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java — @@ -116,6 +118,10 @@ public static void main(String [] args) throws ParseException, IOException, Serv System.exit(0); } + + private static boolean isAcceptableDumpingDatabase(String databaseName) { + return (databaseName == null || !databaseName.equalsIgnoreCase("information_schema")); — End diff – Could you change the ā€¯information_schema" to constants ?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user ykrips commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/365#discussion_r23908869

        — Diff: tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java —
        @@ -116,6 +118,10 @@ public static void main(String [] args) throws ParseException, IOException, Serv

        System.exit(0);
        }
        +
        + private static boolean isAcceptableDumpingDatabase(String databaseName) {
        + return (databaseName == null || !databaseName.equalsIgnoreCase("information_schema"));
        — End diff –

        No problems.

        Show
        githubbot ASF GitHub Bot added a comment - Github user ykrips commented on a diff in the pull request: https://github.com/apache/tajo/pull/365#discussion_r23908869 — Diff: tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java — @@ -116,6 +118,10 @@ public static void main(String [] args) throws ParseException, IOException, Serv System.exit(0); } + + private static boolean isAcceptableDumpingDatabase(String databaseName) { + return (databaseName == null || !databaseName.equalsIgnoreCase("information_schema")); — End diff – No problems.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/365#issuecomment-72415502

        +1
        Looks good to me. Thank you for your contribution!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/365#issuecomment-72415502 +1 Looks good to me. Thank you for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/365

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/365
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #211 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/211/)
        TAJO-1313: Tajo-dump creates DDLs for information_schema tables (jihun: rev 1e007595dc4ebbcab42d8e32e9d519e7cbf6f96b)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #211 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/211/ ) TAJO-1313 : Tajo-dump creates DDLs for information_schema tables (jihun: rev 1e007595dc4ebbcab42d8e32e9d519e7cbf6f96b) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java CHANGES tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #572 (See https://builds.apache.org/job/Tajo-master-build/572/)
        TAJO-1313: Tajo-dump creates DDLs for information_schema tables (jihun: rev 1e007595dc4ebbcab42d8e32e9d519e7cbf6f96b)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #572 (See https://builds.apache.org/job/Tajo-master-build/572/ ) TAJO-1313 : Tajo-dump creates DDLs for information_schema tables (jihun: rev 1e007595dc4ebbcab42d8e32e9d519e7cbf6f96b) CHANGES tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            ykrips Jihun Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development