Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1309

Add missing break point in physical operator

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0, 0.8.1
    • Fix Version/s: 0.10.0
    • Component/s: Physical Operator
    • Labels:
      None

      Description

      Some physical operator does not immediately stopped task in loop when task is killed for aborted.
      We should add break point in order to task termination

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        github pull request link :
        https://github.com/apache/tajo/pull/355

        Show
        jhkim Jinho Kim added a comment - github pull request link : https://github.com/apache/tajo/pull/355
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/355#issuecomment-71039129

        +1

        It looks good overall and all unit test cases finished successfully.
        Push it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/355#issuecomment-71039129 +1 It looks good overall and all unit test cases finished successfully. Push it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/355

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/355
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks!

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #201 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/201/)
        TAJO-1309: Add missing break point in physical operator. (jinho) (jhkim: rev 17c6dff4e258d93e0ffaa1cc07368b2b5d8b8aa4)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SelectionExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeFullOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HavingExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BNLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MemSortExec.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #201 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/201/ ) TAJO-1309 : Add missing break point in physical operator. (jinho) (jhkim: rev 17c6dff4e258d93e0ffaa1cc07368b2b5d8b8aa4) tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SelectionExec.java tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeFullOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HavingExec.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BNLJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MemSortExec.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #562 (See https://builds.apache.org/job/Tajo-master-build/562/)
        TAJO-1309: Add missing break point in physical operator. (jinho) (jhkim: rev 17c6dff4e258d93e0ffaa1cc07368b2b5d8b8aa4)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BNLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MemSortExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeFullOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SelectionExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java
        • tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HavingExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #562 (See https://builds.apache.org/job/Tajo-master-build/562/ ) TAJO-1309 : Add missing break point in physical operator. (jinho) (jhkim: rev 17c6dff4e258d93e0ffaa1cc07368b2b5d8b8aa4) tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BNLJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLJoinExec.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MemSortExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeFullOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/MergeJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SelectionExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HavingExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development