Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1296

Remove obsolete classes from tajo.master.container package.

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      TajoRecord, TajoRecordFactory, and TajoRecordFactoryProvider are lightly used, but its codes are heavy. They can be removed if TajoContainerId directly creates TajoContainerIdPBImpl without using TajoRecord.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/346

        TAJO-1296: Remove obsolete classes from tajo.master.container package.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1296

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/346.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #346


        commit 60e3f3d63ecb33abcc5fc854cd3768b9dcf82caf
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-01-09T19:14:58Z

        TAJO-1296: Remove obsolete classes from tajo.master.container package.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/346 TAJO-1296 : Remove obsolete classes from tajo.master.container package. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1296 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit 60e3f3d63ecb33abcc5fc854cd3768b9dcf82caf Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-09T19:14:58Z TAJO-1296 : Remove obsolete classes from tajo.master.container package.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/346#issuecomment-69446890

        +1
        ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/346#issuecomment-69446890 +1 ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/346

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/346
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #550 (See https://builds.apache.org/job/Tajo-master-build/550/)
        TAJO-1296: Remove obsolete classes from tajo.master.container package. (hyunsik: rev 5d5b152008d25d2605008cd896871b69fd472833)

        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerIdPBImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactory.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryProvider.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerId.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoConverterUtils.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/impl/pb/TajoContainerIdPBImpl.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryPBImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecords.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #550 (See https://builds.apache.org/job/Tajo-master-build/550/ ) TAJO-1296 : Remove obsolete classes from tajo.master.container package. (hyunsik: rev 5d5b152008d25d2605008cd896871b69fd472833) tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerIdPBImpl.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactory.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryProvider.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerId.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoConverterUtils.java tajo-core/src/main/java/org/apache/tajo/master/container/impl/pb/TajoContainerIdPBImpl.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryPBImpl.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecords.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #189 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/189/)
        TAJO-1296: Remove obsolete classes from tajo.master.container package. (hyunsik: rev 5d5b152008d25d2605008cd896871b69fd472833)

        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryPBImpl.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryProvider.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoConverterUtils.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerIdPBImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/impl/pb/TajoContainerIdPBImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerId.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactory.java
        • tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecords.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #189 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/189/ ) TAJO-1296 : Remove obsolete classes from tajo.master.container package. (hyunsik: rev 5d5b152008d25d2605008cd896871b69fd472833) tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryPBImpl.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactoryProvider.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoConverterUtils.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerIdPBImpl.java tajo-core/src/main/java/org/apache/tajo/master/container/impl/pb/TajoContainerIdPBImpl.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoContainerId.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecordFactory.java tajo-core/src/main/java/org/apache/tajo/master/container/TajoRecords.java CHANGES

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development