Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1295

Remove legacy worker.dataserver package and its unit tests.

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Worker
    • Labels:
      None

      Description

      worker.dataserver is not used anymore. We need to remove obsolete codes.

      1. TAJO-1295.patch
        71 kB
        Hyunsik Choi

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/345

        TAJO-1295: Remove legacy worker.dataserver package and its unit tests.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1295

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/345.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #345


        commit 63a6d418e0e9b624d5fd6026aacbdf6925400d3b
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-01-09T18:59:37Z

        TAJO-1295: Remove legacy worker.dataserver package and its unit tests.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/345 TAJO-1295 : Remove legacy worker.dataserver package and its unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1295 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 63a6d418e0e9b624d5fd6026aacbdf6925400d3b Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-09T18:59:37Z TAJO-1295 : Remove legacy worker.dataserver package and its unit tests.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/345#issuecomment-69443452

        Would you check some failures during tests?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/345#issuecomment-69443452 Would you check some failures during tests?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/345#issuecomment-69447703

        I believe that the failure is a occasionally happened problem that we are still finding in another jira. It seems to be not related to my patch because all unit tests are passed in my machine. So, I just rebased and trigger the TravisCI.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/345#issuecomment-69447703 I believe that the failure is a occasionally happened problem that we are still finding in another jira. It seems to be not related to my patch because all unit tests are passed in my machine. So, I just rebased and trigger the TravisCI.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/345#issuecomment-69451861

        +1
        You are right. Ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/345#issuecomment-69451861 +1 You are right. Ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/345

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/345
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #552 (See https://builds.apache.org/job/Tajo-master-build/552/)
        TAJO-1295: Remove legacy worker.dataserver package and its unit tests. (hyunsik: rev bc478ba834e9bba768155faa53f918e495a74671)

        • tajo-core/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DirectoryRetriever.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/RetrieverHandler.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerHandler.java
        • tajo-core/src/main/java/org/apache/tajo/worker/PartitionRetrieverHandler.java
        • tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpUtil.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/AdvancedDataRetriever.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/FileAccessForbiddenException.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DataRetriever.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/FileChunk.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpUtil.java
        • tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpDataServer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerPipelineFactory.java
        • tajo-core/src/main/java/org/apache/tajo/worker/InterDataRetriever.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #552 (See https://builds.apache.org/job/Tajo-master-build/552/ ) TAJO-1295 : Remove legacy worker.dataserver package and its unit tests. (hyunsik: rev bc478ba834e9bba768155faa53f918e495a74671) tajo-core/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServer.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DirectoryRetriever.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/RetrieverHandler.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerHandler.java tajo-core/src/main/java/org/apache/tajo/worker/PartitionRetrieverHandler.java tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpUtil.java tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/AdvancedDataRetriever.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/FileAccessForbiddenException.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DataRetriever.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/FileChunk.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpUtil.java tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpDataServer.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerPipelineFactory.java tajo-core/src/main/java/org/apache/tajo/worker/InterDataRetriever.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #191 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/191/)
        TAJO-1295: Remove legacy worker.dataserver package and its unit tests. (hyunsik: rev bc478ba834e9bba768155faa53f918e495a74671)

        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpUtil.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/FileChunk.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/AdvancedDataRetriever.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/RetrieverHandler.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DataRetriever.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerHandler.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerPipelineFactory.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/FileAccessForbiddenException.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServer.java
        • tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpDataServer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DirectoryRetriever.java
        • tajo-core/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpUtil.java
        • tajo-core/src/main/java/org/apache/tajo/worker/InterDataRetriever.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/PartitionRetrieverHandler.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #191 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/191/ ) TAJO-1295 : Remove legacy worker.dataserver package and its unit tests. (hyunsik: rev bc478ba834e9bba768155faa53f918e495a74671) tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpUtil.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/FileChunk.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/AdvancedDataRetriever.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/RetrieverHandler.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DataRetriever.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerHandler.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerPipelineFactory.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/FileAccessForbiddenException.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServer.java tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpDataServer.java tajo-core/src/main/java/org/apache/tajo/worker/dataserver/retriever/DirectoryRetriever.java tajo-core/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/test/java/org/apache/tajo/worker/dataserver/TestHttpUtil.java tajo-core/src/main/java/org/apache/tajo/worker/InterDataRetriever.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/PartitionRetrieverHandler.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development