Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1291

Rename TajoMasterProtocol to QueryCoordinatorProtocol

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      TajoMaster mainly has three roles:

      • query coordination (including query scheduler)
      • cluster resource management
      • client endpoint

      TajoMasterProtocol has played a role of query coordinator. But, its name is not expressive in terms of its purpose. This patch proposes the rename from TajoMasterProtocol to QueryCoordinatorProtocol.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-CODEGEN-build #190 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/190/)
          TAJO-1297: Tajo Web UI does not work after TAJO-1291. (jihoon) (jihoonson: rev c45d0ef02df1aa59bb54e0da0205890cc050fcff)

          • tajo-core/src/main/resources/webapps/worker/querytasks.jsp
          • tajo-core/src/main/resources/webapps/admin/index.jsp
          • CHANGES
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #190 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/190/ ) TAJO-1297 : Tajo Web UI does not work after TAJO-1291 . (jihoon) (jihoonson: rev c45d0ef02df1aa59bb54e0da0205890cc050fcff) tajo-core/src/main/resources/webapps/worker/querytasks.jsp tajo-core/src/main/resources/webapps/admin/index.jsp CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #551 (See https://builds.apache.org/job/Tajo-master-build/551/)
          TAJO-1297: Tajo Web UI does not work after TAJO-1291. (jihoon) (jihoonson: rev c45d0ef02df1aa59bb54e0da0205890cc050fcff)

          • CHANGES
          • tajo-core/src/main/resources/webapps/admin/index.jsp
          • tajo-core/src/main/resources/webapps/worker/querytasks.jsp
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #551 (See https://builds.apache.org/job/Tajo-master-build/551/ ) TAJO-1297 : Tajo Web UI does not work after TAJO-1291 . (jihoon) (jihoonson: rev c45d0ef02df1aa59bb54e0da0205890cc050fcff) CHANGES tajo-core/src/main/resources/webapps/admin/index.jsp tajo-core/src/main/resources/webapps/worker/querytasks.jsp
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-CODEGEN-build #186 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/186/)
          TAJO-1291: Rename TajoMasterProtocol to QueryCoordinatorProtocol. (hyunsik: rev 807868bd4d1ca1c8bd3aee33d31cca3d43dd2273)

          • tajo-core/src/main/resources/webapps/admin/query.jsp
          • tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java
          • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java
          • tajo-core/src/main/java/org/apache/tajo/master/scheduler/Scheduler.java
          • tajo-core/src/main/proto/TajoMasterProtocol.proto
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
          • tajo-core/pom.xml
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryJobManager.java
          • CHANGES
          • tajo-core/src/main/resources/webapps/admin/index.jsp
          • tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          • tajo-core/src/main/proto/QueryCoordinatorProtocol.proto
          • tajo-core/src/main/java/org/apache/tajo/util/JSPUtil.java
          • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterService.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
          • tajo-core/src/main/proto/ResourceTrackerProtocol.proto
          • tajo-core/src/main/java/org/apache/tajo/master/scheduler/SimpleFifoScheduler.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryInProgress.java
          • tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResourceManager.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
          • tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java
          • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #186 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/186/ ) TAJO-1291 : Rename TajoMasterProtocol to QueryCoordinatorProtocol. (hyunsik: rev 807868bd4d1ca1c8bd3aee33d31cca3d43dd2273) tajo-core/src/main/resources/webapps/admin/query.jsp tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java tajo-core/src/main/java/org/apache/tajo/master/scheduler/Scheduler.java tajo-core/src/main/proto/TajoMasterProtocol.proto tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-core/pom.xml tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/master/QueryJobManager.java CHANGES tajo-core/src/main/resources/webapps/admin/index.jsp tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/proto/QueryCoordinatorProtocol.proto tajo-core/src/main/java/org/apache/tajo/util/JSPUtil.java tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterService.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core/src/main/proto/ResourceTrackerProtocol.proto tajo-core/src/main/java/org/apache/tajo/master/scheduler/SimpleFifoScheduler.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResourceManager.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #547 (See https://builds.apache.org/job/Tajo-master-build/547/)
          TAJO-1291: Rename TajoMasterProtocol to QueryCoordinatorProtocol. (hyunsik: rev 807868bd4d1ca1c8bd3aee33d31cca3d43dd2273)

          • tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResourceManager.java
          • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
          • tajo-core/src/main/resources/webapps/admin/query.jsp
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
          • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
          • tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java
          • tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java
          • CHANGES
          • tajo-core/src/main/proto/ResourceTrackerProtocol.proto
          • tajo-core/src/main/java/org/apache/tajo/util/JSPUtil.java
          • tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java
          • tajo-core/pom.xml
          • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryInProgress.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryJobManager.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
          • tajo-core/src/main/java/org/apache/tajo/master/scheduler/SimpleFifoScheduler.java
          • tajo-core/src/main/proto/QueryCoordinatorProtocol.proto
          • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
          • tajo-core/src/main/java/org/apache/tajo/master/scheduler/Scheduler.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          • tajo-core/src/main/resources/webapps/admin/index.jsp
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
          • tajo-core/src/main/proto/TajoMasterProtocol.proto
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterService.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #547 (See https://builds.apache.org/job/Tajo-master-build/547/ ) TAJO-1291 : Rename TajoMasterProtocol to QueryCoordinatorProtocol. (hyunsik: rev 807868bd4d1ca1c8bd3aee33d31cca3d43dd2273) tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResourceManager.java tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java tajo-core/src/main/resources/webapps/admin/query.jsp tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java CHANGES tajo-core/src/main/proto/ResourceTrackerProtocol.proto tajo-core/src/main/java/org/apache/tajo/util/JSPUtil.java tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java tajo-core/pom.xml tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/master/QueryJobManager.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core/src/main/java/org/apache/tajo/master/scheduler/SimpleFifoScheduler.java tajo-core/src/main/proto/QueryCoordinatorProtocol.proto tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/master/scheduler/Scheduler.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/resources/webapps/admin/index.jsp tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/proto/TajoMasterProtocol.proto tajo-core/src/main/java/org/apache/tajo/master/TajoMasterService.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/342

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/342
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed.

          Show
          hyunsik Hyunsik Choi added a comment - committed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/342#issuecomment-69324021

          +1 Looks great to me.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/342#issuecomment-69324021 +1 Looks great to me.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/342

          TAJO-1291: Rename TajoMasterProtocol to QueryCoordinatorProtocol

          See

          This patch renames TajoMasterProtocol to QueryCoordinatorProtocol. In addition, it moves QueryInfo from org.apache.tajo.querymaster into org.apache.tajo.master.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1291

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/342.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #342


          commit b90387d6894493ebbfdfd949e1cd28924cfccdfa
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-01-08T18:08:37Z

          TAJO-1282: Cleanup the relationship of QueryInProgress and QueryJobManager.

          commit 3b5901c4dfbe28641464e68eed97961f49d0d012
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-01-08T18:15:03Z

          Simplify events in QueryJobEvent.

          • Remove the following event types in QueryJobEvent:
          • QUERY_JOB_START
          • QUERY_JOB_FINISH
          • QUERY_MASTER_START
          • QUERY_MASTER_STOP

          commit 21d9ea1c39ab014559247240b6609bdd5db161bb
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-01-09T07:39:01Z

          TAJO-1291: Rename TajoMasterProtocol to QueryCoordinatorProtocol.

          commit 06dc6d9be798f730b95e39eca135ac45abfb4c4a
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-01-09T07:57:41Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1282

          Conflicts:
          tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
          tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java

          commit b40eb401f20e7ecb7044dc9d7980d60fe3661f11
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-01-09T08:01:43Z

          Rename TajoMasterUmbilicalService to QueryCoordinatorService.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/342 TAJO-1291 : Rename TajoMasterProtocol to QueryCoordinatorProtocol See https://issues.apache.org/jira/browse/TAJO-1292 https://issues.apache.org/jira/browse/TAJO-1291 This patch renames TajoMasterProtocol to QueryCoordinatorProtocol. In addition, it moves QueryInfo from org.apache.tajo.querymaster into org.apache.tajo.master. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1291 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/342.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #342 commit b90387d6894493ebbfdfd949e1cd28924cfccdfa Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-08T18:08:37Z TAJO-1282 : Cleanup the relationship of QueryInProgress and QueryJobManager. commit 3b5901c4dfbe28641464e68eed97961f49d0d012 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-08T18:15:03Z Simplify events in QueryJobEvent. Remove the following event types in QueryJobEvent: QUERY_JOB_START QUERY_JOB_FINISH QUERY_MASTER_START QUERY_MASTER_STOP commit 21d9ea1c39ab014559247240b6609bdd5db161bb Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-09T07:39:01Z TAJO-1291 : Rename TajoMasterProtocol to QueryCoordinatorProtocol. commit 06dc6d9be798f730b95e39eca135ac45abfb4c4a Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-09T07:57:41Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1282 Conflicts: tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java commit b40eb401f20e7ecb7044dc9d7980d60fe3661f11 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-09T08:01:43Z Rename TajoMasterUmbilicalService to QueryCoordinatorService.

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development