Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1285

Refactoring Magic Number to HAConstants

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      HAConstants defines types.
      But in HAServiceUtil, just using Magic Numbers 1,2,3,4,5
      so this patch just changed them as HAConstants.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/336

        TAJO-1285 Refactoring Magic Number to HAConstants

        HAConstants defines types.
        But in HAServiceUtil, just using Magic Numbers 1,2,3,4,5
        so this patch just changed them as HAConstants.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/TAJO-1285

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/336.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #336


        commit 70cced815a5d294204563fe2494c9e3caf80485b
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-01-07T15:23:06Z

        change magic number to constants


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/336 TAJO-1285 Refactoring Magic Number to HAConstants HAConstants defines types. But in HAServiceUtil, just using Magic Numbers 1,2,3,4,5 so this patch just changed them as HAConstants. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/ TAJO-1285 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit 70cced815a5d294204563fe2494c9e3caf80485b Author: clark.kang <clark.kang@kakao.com> Date: 2015-01-07T15:23:06Z change magic number to constants
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/336#issuecomment-69124243

        Hi @charsyam

        +1
        Thanks for your contribution.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/336#issuecomment-69124243 Hi @charsyam +1 Thanks for your contribution.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/336

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/336
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #177 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/177/)
        TAJO-1285: Refactoring Magic Number to HAConstants. (DaeMyung Kang via jaehwa) (blrunner: rev 7615b7576d2d40758f55cae3f4ea3346322cef0f)

        • tajo-common/src/main/java/org/apache/tajo/ha/HAServiceUtil.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #177 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/177/ ) TAJO-1285 : Refactoring Magic Number to HAConstants. (DaeMyung Kang via jaehwa) (blrunner: rev 7615b7576d2d40758f55cae3f4ea3346322cef0f) tajo-common/src/main/java/org/apache/tajo/ha/HAServiceUtil.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #538 (See https://builds.apache.org/job/Tajo-master-build/538/)
        TAJO-1285: Refactoring Magic Number to HAConstants. (DaeMyung Kang via jaehwa) (blrunner: rev 7615b7576d2d40758f55cae3f4ea3346322cef0f)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/ha/HAServiceUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #538 (See https://builds.apache.org/job/Tajo-master-build/538/ ) TAJO-1285 : Refactoring Magic Number to HAConstants. (DaeMyung Kang via jaehwa) (blrunner: rev 7615b7576d2d40758f55cae3f4ea3346322cef0f) CHANGES tajo-common/src/main/java/org/apache/tajo/ha/HAServiceUtil.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development