Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1268

tajo-client module should not use UserGroupInformation

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      TajoClient uses UserGroupInformation in order to just get a user name. It's trivial, yet it forces TajoClient to depend on Hadoop. We need to replace UserGroupInformation by our own implementation.

      1. TAJO-1268.patch
        12 kB
        Hyunsik Choi

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/318

          TAJO-1268: tajo-client module should not use UserGroupInformation.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1268

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/318.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #318


          commit 734d65f592318edb51945d66757a8e67dfe21e05
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2014-12-24T05:20:53Z

          TAJO-1268: tajo-client module should not use UserGroupInformation.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/318 TAJO-1268 : tajo-client module should not use UserGroupInformation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1268 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/318.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #318 commit 734d65f592318edb51945d66757a8e67dfe21e05 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-12-24T05:20:53Z TAJO-1268 : tajo-client module should not use UserGroupInformation.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688994/TAJO-1268.patch
          against master revision release-0.9.0-rc0-106-g3c833e2.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 201 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 298 release audit warnings.

          -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core:
          org.apache.tajo.engine.query.TestJoinBroadcast

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/553//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/553//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688994/TAJO-1268.patch against master revision release-0.9.0-rc0-106-g3c833e2. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 201 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 298 release audit warnings. -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core: org.apache.tajo.engine.query.TestJoinBroadcast Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/553//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/553//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/553//console This message is automatically generated.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688994/TAJO-1268.patch
          against master revision release-0.9.0-rc0-108-g09cad22.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 201 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 229 release audit warnings.

          -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core:
          org.apache.tajo.engine.function.TestBuiltinFunctions

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/556//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/556//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688994/TAJO-1268.patch against master revision release-0.9.0-rc0-108-g09cad22. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 201 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 229 release audit warnings. -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core: org.apache.tajo.engine.function.TestBuiltinFunctions Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/556//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/556//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/556//console This message is automatically generated.
          Hide
          jhkim Jinho Kim added a comment -

          +1
          Currently, we did not implement tajo security feature. so this patch looks good to me.
          We should consider the java security when we add the own security feature.

          Show
          jhkim Jinho Kim added a comment - +1 Currently, we did not implement tajo security feature. so this patch looks good to me. We should consider the java security when we add the own security feature.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/318

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/318
          Hide
          hyunsik Hyunsik Choi added a comment -

          Thank you Jinho Kim for the quick review. I just committed the patch to master branch.

          Show
          hyunsik Hyunsik Choi added a comment - Thank you Jinho Kim for the quick review. I just committed the patch to master branch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-build #520 (See https://builds.apache.org/job/Tajo-master-build/520/)
          TAJO-1268: tajo-client module should not use UserGroupInformation. (hyunsik: rev db549655034c1eb79d8f5785bc00aeecfc53a593)

          • tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          • CHANGES
          • tajo-common/src/main/java/org/apache/tajo/auth/UserRoleInfo.java
          • tajo-common/src/main/java/org/apache/tajo/util/PlatformUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #520 (See https://builds.apache.org/job/Tajo-master-build/520/ ) TAJO-1268 : tajo-client module should not use UserGroupInformation. (hyunsik: rev db549655034c1eb79d8f5785bc00aeecfc53a593) tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java CHANGES tajo-common/src/main/java/org/apache/tajo/auth/UserRoleInfo.java tajo-common/src/main/java/org/apache/tajo/util/PlatformUtil.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #160 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/160/)
          TAJO-1268: tajo-client module should not use UserGroupInformation. (hyunsik: rev db549655034c1eb79d8f5785bc00aeecfc53a593)

          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          • CHANGES
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-common/src/main/java/org/apache/tajo/auth/UserRoleInfo.java
          • tajo-common/src/main/java/org/apache/tajo/util/PlatformUtil.java
          • tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #160 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/160/ ) TAJO-1268 : tajo-client module should not use UserGroupInformation. (hyunsik: rev db549655034c1eb79d8f5785bc00aeecfc53a593) tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java CHANGES tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-common/src/main/java/org/apache/tajo/auth/UserRoleInfo.java tajo-common/src/main/java/org/apache/tajo/util/PlatformUtil.java tajo-client/src/main/java/org/apache/tajo/cli/tools/TajoDump.java tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development