Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Tajo has two types of task scheduler, DefaultTaskScheduler and LazyTaskScheduler.
      However, LazyTaskScheduler is not practically used, and its code is also not maintained anymore.
      Thus, we need to remove it.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user charsyam opened a pull request:

          https://github.com/apache/tajo/pull/319

          TAJO-1267: Remove LazyTaskScheduler

          I removed LazyTaskScheduler and its related class and settings.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/charsyam/tajo feature/TAJO-1267

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/319.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #319


          commit b98bd6e1ce498e0d18c4d5ead65c3960eb7e38d4
          Author: clark.kang <clark.kang@kakao.com>
          Date: 2014-12-24T16:48:27Z

          TAJO-1267


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/319 TAJO-1267 : Remove LazyTaskScheduler I removed LazyTaskScheduler and its related class and settings. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/ TAJO-1267 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/319.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #319 commit b98bd6e1ce498e0d18c4d5ead65c3960eb7e38d4 Author: clark.kang <clark.kang@kakao.com> Date: 2014-12-24T16:48:27Z TAJO-1267
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68068244

          @jihoonson ,

          Could you review this? You may be the best reviewer for this patch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68068244 @jihoonson , Could you review this? You may be the best reviewer for this patch.
          Hide
          jihoonson Jihoon Son added a comment -

          I will happily review it.

          Show
          jihoonson Jihoon Son added a comment - I will happily review it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user charsyam commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68086635

          @jihoonson in my mistake, I merged some other code into TAJO-1267 now. I will recover it. sorry

          Show
          githubbot ASF GitHub Bot added a comment - Github user charsyam commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68086635 @jihoonson in my mistake, I merged some other code into TAJO-1267 now. I will recover it. sorry
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user charsyam commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68086755

          @jihoonson I recovered it. Sorry.

          Show
          githubbot ASF GitHub Bot added a comment - Github user charsyam commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68086755 @jihoonson I recovered it. Sorry.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68088459

          No problem. Thank you for quick updating.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68088459 No problem. Thank you for quick updating.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68089284

          I have read the patch. It looks good to me.
          I'll commit after unit test.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68089284 I have read the patch. It looks good to me. I'll commit after unit test.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68096953

          +1
          Travis CI build is failed due to a test failure at TestHistory, but it seems a temporal misbehavior.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68096953 +1 Travis CI build is failed due to a test failure at TestHistory, but it seems a temporal misbehavior.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/319#issuecomment-68097224

          @charsyam, thanks for your contribution.
          I've committed the patch against the master branch, but forgot closing this PR.
          Would you please close it?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/319#issuecomment-68097224 @charsyam, thanks for your contribution. I've committed the patch against the master branch, but forgot closing this PR. Would you please close it?
          Hide
          jihoonson Jihoon Son added a comment -

          Committed.

          Show
          jihoonson Jihoon Son added a comment - Committed.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #161 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/161/)
          TAJO-1267: Remove LazyTaskScheduler. (DaeMyung Kang via jihoon) (jihoonson: rev 533e709b75ab7cf8bc8a06b48870dcf2ebc8fe11)

          • tajo-core/src/main/resources/tajo-default.xml
          • tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithm.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
          • tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithmFactory.java
          • tajo-core/src/main/java/org/apache/tajo/master/GreedyFragmentScheduleAlgorithm.java
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java
          • tajo-core/src/main/java/org/apache/tajo/master/DefaultFragmentScheduleAlgorithm.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #161 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/161/ ) TAJO-1267 : Remove LazyTaskScheduler. (DaeMyung Kang via jihoon) (jihoonson: rev 533e709b75ab7cf8bc8a06b48870dcf2ebc8fe11) tajo-core/src/main/resources/tajo-default.xml tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithm.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithmFactory.java tajo-core/src/main/java/org/apache/tajo/master/GreedyFragmentScheduleAlgorithm.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java tajo-core/src/main/java/org/apache/tajo/master/DefaultFragmentScheduleAlgorithm.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #521 (See https://builds.apache.org/job/Tajo-master-build/521/)
          TAJO-1267: Remove LazyTaskScheduler. (DaeMyung Kang via jihoon) (jihoonson: rev 533e709b75ab7cf8bc8a06b48870dcf2ebc8fe11)

          • tajo-core/src/main/java/org/apache/tajo/master/GreedyFragmentScheduleAlgorithm.java
          • tajo-core/src/main/resources/tajo-default.xml
          • tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java
          • tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithm.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
          • tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithmFactory.java
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/master/DefaultFragmentScheduleAlgorithm.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #521 (See https://builds.apache.org/job/Tajo-master-build/521/ ) TAJO-1267 : Remove LazyTaskScheduler. (DaeMyung Kang via jihoon) (jihoonson: rev 533e709b75ab7cf8bc8a06b48870dcf2ebc8fe11) tajo-core/src/main/java/org/apache/tajo/master/GreedyFragmentScheduleAlgorithm.java tajo-core/src/main/resources/tajo-default.xml tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithm.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java tajo-core/src/main/java/org/apache/tajo/master/FragmentScheduleAlgorithmFactory.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/DefaultFragmentScheduleAlgorithm.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user charsyam closed the pull request at:

          https://github.com/apache/tajo/pull/319

          Show
          githubbot ASF GitHub Bot added a comment - Github user charsyam closed the pull request at: https://github.com/apache/tajo/pull/319

            People

            • Assignee:
              charsyam DaeMyung Kang
              Reporter:
              jihoonson Jihoon Son
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development