Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1252

PathValidator should allow hdfs paths which contain IP addresses

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      See the title.
      Currently, PathValidator returns false for the following cases.

      <property>
        <name>tajo.rootdir</name>
        <value>hdfs://127.0.0.1:7020/tajo</value>
      </property>
      

        Activity

        Hide
        jihoonson Jihoon Son added a comment -

        This is my first patch.
        Actually, I'm not much familiar with regex, so I cannot assure that this is a valid change.
        Please review carefully, and let me know what I should improve on.
        Thanks.

        Show
        jihoonson Jihoon Son added a comment - This is my first patch. Actually, I'm not much familiar with regex, so I cannot assure that this is a valid change. Please review carefully, and let me know what I should improve on. Thanks.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12687509/TAJO-1252.patch
        against master revision release-0.9.0-rc0-96-g82dfb17.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 26 new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 540 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/546//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/546//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/546//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/546//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687509/TAJO-1252.patch against master revision release-0.9.0-rc0-96-g82dfb17. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 26 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 540 release audit warnings. +1 core tests. The patch passed unit tests in tajo-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/546//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/546//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/546//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/546//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        +1 LGTM!
        Ship it!

        Show
        jhkim Jinho Kim added a comment - +1 LGTM! Ship it!
        Hide
        jihoonson Jihoon Son added a comment -

        Jinho Kim thanks for your review!!

        Show
        jihoonson Jihoon Son added a comment - Jinho Kim thanks for your review!!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #148 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/148/)
        TAJO-1252: PathValidator should allow hdfs paths which contain IP addresses. (jihoon) (jihoonson: rev e025e3cbe80ab39ca963333a7d4d71edea22ce0b)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java
        • tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #148 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/148/ ) TAJO-1252 : PathValidator should allow hdfs paths which contain IP addresses. (jihoon) (jihoonson: rev e025e3cbe80ab39ca963333a7d4d71edea22ce0b) CHANGES tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #507 (See https://builds.apache.org/job/Tajo-master-build/507/)
        TAJO-1252: PathValidator should allow hdfs paths which contain IP addresses. (jihoon) (jihoonson: rev e025e3cbe80ab39ca963333a7d4d71edea22ce0b)

        • tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java
        • tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #507 (See https://builds.apache.org/job/Tajo-master-build/507/ ) TAJO-1252 : PathValidator should allow hdfs paths which contain IP addresses. (jihoon) (jihoonson: rev e025e3cbe80ab39ca963333a7d4d71edea22ce0b) tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java CHANGES

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development