Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1247

Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Recently, we added TEXTFILE for all kinds line-delimited plan text files. But, its name is long and is different to naming convention that we've used. So, I propose renaming it to TEXT. But, TEXT is equivalent to the data domain 'TEXT', so we should keep its enum type in CatalogProtos.proto.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user charsyam opened a pull request:

          https://github.com/apache/tajo/pull/302

          TAJO-1247: Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf

          Recently, we added TEXTFILE for all kinds line-delimited plan text files. But, its name is long and is different to naming convention that we've used. So, I propose renaming it to TEXT. But, TEXT is equivalent to the data domain 'TEXT', so we should keep its enum type in CatalogProtos.proto.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/charsyam/tajo feature/TAJO-1247

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/302.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #302


          commit eb7370e3e4ae79104f9a98d890c0f0a3747c7523
          Author: clark.kang <clark.kang@kakao.com>
          Date: 2014-12-15T21:35:19Z

          TAJO-1247 using text in only sql


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/302 TAJO-1247 : Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf Recently, we added TEXTFILE for all kinds line-delimited plan text files. But, its name is long and is different to naming convention that we've used. So, I propose renaming it to TEXT. But, TEXT is equivalent to the data domain 'TEXT', so we should keep its enum type in CatalogProtos.proto. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/ TAJO-1247 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/302.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #302 commit eb7370e3e4ae79104f9a98d890c0f0a3747c7523 Author: clark.kang <clark.kang@kakao.com> Date: 2014-12-15T21:35:19Z TAJO-1247 using text in only sql
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/302#issuecomment-67584456

          +1
          The patch looks nice to me. I'll commit it shortly.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/302#issuecomment-67584456 +1 The patch looks nice to me. I'll commit it shortly.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/302

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/302
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed to master branch. Thank you for your contribution.

          Show
          hyunsik Hyunsik Choi added a comment - committed to master branch. Thank you for your contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #153 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/153/)
          TAJO-1247: Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf. (DaeMyung Kang via hyunsik) (hyunsik: rev b7c8cf7239483c6b44925175658f21dbbf252665)

          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
          • tajo-docs/src/main/sphinx/table_management/table_overview.rst
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
          • tajo-docs/src/main/sphinx/table_management/csv.rst
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
          • tajo-docs/src/main/sphinx/time_zone.rst
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
          • CHANGES
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #153 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/153/ ) TAJO-1247 : Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf. (DaeMyung Kang via hyunsik) (hyunsik: rev b7c8cf7239483c6b44925175658f21dbbf252665) tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-docs/src/main/sphinx/table_management/csv.rst tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-docs/src/main/sphinx/time_zone.rst tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #513 (See https://builds.apache.org/job/Tajo-master-build/513/)
          TAJO-1247: Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf. (DaeMyung Kang via hyunsik) (hyunsik: rev b7c8cf7239483c6b44925175658f21dbbf252665)

          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
          • tajo-docs/src/main/sphinx/time_zone.rst
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
          • CHANGES
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
          • tajo-docs/src/main/sphinx/table_management/table_overview.rst
          • tajo-docs/src/main/sphinx/table_management/csv.rst
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #513 (See https://builds.apache.org/job/Tajo-master-build/513/ ) TAJO-1247 : Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf. (DaeMyung Kang via hyunsik) (hyunsik: rev b7c8cf7239483c6b44925175658f21dbbf252665) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-docs/src/main/sphinx/time_zone.rst tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java CHANGES tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-docs/src/main/sphinx/table_management/csv.rst

            People

            • Assignee:
              charsyam DaeMyung Kang
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development