Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1244

tajo.worker.tmpdir.locations should use a validator for a list of paths.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      2014-12-11 14:47:17,887 INFO org.apache.hadoop.service.AbstractService: Service org.apache.tajo.worker.TajoWorker failed in state INITED; cause: org.apache.tajo.rule.Evaluation
      FailedException: Validation Test has been failed on tajo.worker.tmpdir.locations. Actual value is /data01/tajo/data,/data02/tajo/data,/data03/tajo/data,/data04/tajo/data,/data0
      5/tajo/data,/data06/tajo/data,/data07/tajo/data,/data08/tajo/data,/data09/tajo/data,/data10/tajo/data
      org.apache.tajo.rule.EvaluationFailedException: Validation Test has been failed on tajo.worker.tmpdir.locations. Actual value is /data01/tajo/data,/data02/tajo/data,/data03/taj
      o/data,/data04/tajo/data,/data05/tajo/data,/data06/tajo/data,/data07/tajo/data,/data08/tajo/data,/data09/tajo/data,/data10/tajo/data
              at org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:66)
              at org.apache.tajo.worker.TajoWorker.diagnoseTajoWorker(TajoWorker.java:333)
              at org.apache.tajo.worker.TajoWorker.serviceInit(TajoWorker.java:271)
              at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
              at org.apache.tajo.worker.TajoWorker.startWorker(TajoWorker.java:149)
              at org.apache.tajo.worker.TajoWorker.main(TajoWorker.java:706)
      Caused by: org.apache.tajo.validation.ConstraintViolationException: ConstraintViolationException [/data01/tajo/data,/data02/tajo/data,/data03/tajo/data,/data04/tajo/data,/data0
      5/tajo/data,/data06/tajo/data,/data07/tajo/data,/data08/tajo/data,/data09/tajo/data,/data10/tajo/data is not valid path.]
              at org.apache.tajo.rule.base.TajoConfValidationRule.evaluate(TajoConfValidationRule.java:81)
              at org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:63)
              ... 5 more
      2014-12-11 14:47:18,011 INFO org.apache.hadoop.service.AbstractService: Service WorkerHeartbeatService failed in state STOPPED; cause: java.lang.NullPointerException
      $ df -h
      Filesystem      Size  Used Avail Use% Mounted on
      /dev/sdb1       2.7T  730G  1.9T  28% /data01
      /dev/sdc1       2.7T  734G  1.9T  29% /data02
      /dev/sdd1       2.7T  726G  1.9T  28% /data03
      /dev/sde1       2.7T  728G  1.9T  28% /data04
      /dev/sdf1       2.7T  732G  1.9T  29% /data05
      /dev/sdg1       2.7T  732G  1.9T  29% /data06
      /dev/sdh1       2.7T  727G  1.9T  28% /data07
      /dev/sdi1       2.7T  727G  1.9T  28% /data08
      /dev/sdj1       2.7T  732G  1.9T  29% /data09
      /dev/sdk1       2.7T  726G  1.9T  28% /data10
      
      1. TAJO-1244.patch
        10 kB
        Hyunsik Choi

        Activity

        Hide
        jihoonson Jihoon Son added a comment -

        I met the same error, but cannot reproduce it.
        Would you tell me how I can reproduce?

        Show
        jihoonson Jihoon Son added a comment - I met the same error, but cannot reproduce it. Would you tell me how I can reproduce?
        Hide
        jhkim Jinho Kim added a comment -

        I heard bug from Hyunsik. Currently the path validator does not allow the list of directories.

        Show
        jhkim Jinho Kim added a comment - I heard bug from Hyunsik. Currently the path validator does not allow the list of directories.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I'll fix it soon.

        Show
        hyunsik Hyunsik Choi added a comment - I'll fix it soon.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/298#issuecomment-66605300

        I'm reviewing the patch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/298#issuecomment-66605300 I'm reviewing the patch.
        Hide
        jihoonson Jihoon Son added a comment -

        Jinho Kim, thanks for your reply.
        However, I didn't configure my machine to use multiple directories.
        So, I guess that the error I met is another one. I'll further investigate it.

        Show
        jihoonson Jihoon Son added a comment - Jinho Kim , thanks for your reply. However, I didn't configure my machine to use multiple directories. So, I guess that the error I met is another one. I'll further investigate it.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12686583/TAJO-1244.patch
        against master revision release-0.9.0-rc0-84-ga0d67bb.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail.

        -1 release audit. The applied patch generated 536 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/542//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/542//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/542//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/542//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686583/TAJO-1244.patch against master revision release-0.9.0-rc0-84-ga0d67bb. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. -1 release audit. The applied patch generated 536 release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/542//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/542//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/542//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/542//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/298#issuecomment-66624110

        +1!
        This patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/298#issuecomment-66624110 +1! This patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/298

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/298
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. Thank you for the quick review!

        Show
        hyunsik Hyunsik Choi added a comment - committed. Thank you for the quick review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #136 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/136/)
        TAJO-1244: tajo.worker.tmpdir.locations should use a validator for a list of Path. (hyunsik: rev adb34bdf84299228037d7706bf0c0209c3577846)

        • tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java
        • tajo-common/src/main/java/org/apache/tajo/validation/PathListValidator.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleDefinition.java
        • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
        • tajo-common/src/main/java/org/apache/tajo/validation/Validators.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #136 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/136/ ) TAJO-1244 : tajo.worker.tmpdir.locations should use a validator for a list of Path. (hyunsik: rev adb34bdf84299228037d7706bf0c0209c3577846) tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java CHANGES tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java tajo-common/src/main/java/org/apache/tajo/validation/PathListValidator.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleDefinition.java tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java tajo-common/src/main/java/org/apache/tajo/validation/Validators.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #495 (See https://builds.apache.org/job/Tajo-master-build/495/)
        TAJO-1244: tajo.worker.tmpdir.locations should use a validator for a list of Path. (hyunsik: rev adb34bdf84299228037d7706bf0c0209c3577846)

        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java
        • tajo-common/src/main/java/org/apache/tajo/validation/Validators.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-common/src/main/java/org/apache/tajo/validation/PathListValidator.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleDefinition.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
        • tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java
        • tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #495 (See https://builds.apache.org/job/Tajo-master-build/495/ ) TAJO-1244 : tajo.worker.tmpdir.locations should use a validator for a list of Path. (hyunsik: rev adb34bdf84299228037d7706bf0c0209c3577846) tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java tajo-common/src/main/java/org/apache/tajo/validation/Validators.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-common/src/main/java/org/apache/tajo/validation/PathListValidator.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleDefinition.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java tajo-common/src/main/java/org/apache/tajo/validation/PathValidator.java tajo-common/src/test/java/org/apache/tajo/validation/TestValidators.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development