Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1243

*-site.xml.template should have default configs commented out.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, catalog-site.xml.template and tajo-site.xml.template are empty. It gives users some burden to find manual for configuration.

      I propose that *-site.xml.template should default configs which are minimum and necessary to startup a Tajo cluster.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/297

          TAJO-1243: *-site.xml.template should have default configs commented.

          This is an update of documentation.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1243

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/297.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #297


          commit b783977249b0becda1d5f1dcec79bf7af120d556
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2014-12-11T05:35:48Z

          initial work

          commit cc56fae0a36167ae64feb4c12bab23ed4941755e
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2014-12-11T07:34:53Z

          TAJO-1243: *-site.xml.template should have default configs commented out.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/297 TAJO-1243 : *-site.xml.template should have default configs commented. This is an update of documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1243 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #297 commit b783977249b0becda1d5f1dcec79bf7af120d556 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-12-11T05:35:48Z initial work commit cc56fae0a36167ae64feb4c12bab23ed4941755e Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-12-11T07:34:53Z TAJO-1243 : *-site.xml.template should have default configs commented out.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/297#issuecomment-66619184

          Hi @hyunsik

          Thanks for your contribution. It will be very useful for tajo beginners.
          And if you possible, could you add a comment for HCatalogStore at catalog-site.xml.template?

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/297#issuecomment-66619184 Hi @hyunsik Thanks for your contribution. It will be very useful for tajo beginners. And if you possible, could you add a comment for HCatalogStore at catalog-site.xml.template?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/297#issuecomment-66619564

          Sorry @hyunsik .
          I missed a comment for HCatalogStore.
          Push it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/297#issuecomment-66619564 Sorry @hyunsik . I missed a comment for HCatalogStore. Push it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/297#issuecomment-66626670

          Thanks a lot. I'll commit it shortly.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/297#issuecomment-66626670 Thanks a lot. I'll commit it shortly.
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed.

          Show
          hyunsik Hyunsik Choi added a comment - committed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/297

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/297
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #137 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/137/)
          TAJO-1243: *-site.xml.template should have default configs commented out. (hyunsik: rev 876adcfbe358c6d91d9a50ba81847ebba1f0184d)

          • tajo-dist/src/main/conf/catalog-site.xml.template
          • CHANGES
          • tajo-dist/src/main/conf/tajo-site.xml.template
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #137 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/137/ ) TAJO-1243 : *-site.xml.template should have default configs commented out. (hyunsik: rev 876adcfbe358c6d91d9a50ba81847ebba1f0184d) tajo-dist/src/main/conf/catalog-site.xml.template CHANGES tajo-dist/src/main/conf/tajo-site.xml.template
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #496 (See https://builds.apache.org/job/Tajo-master-build/496/)
          TAJO-1243: *-site.xml.template should have default configs commented out. (hyunsik: rev 876adcfbe358c6d91d9a50ba81847ebba1f0184d)

          • tajo-dist/src/main/conf/tajo-site.xml.template
          • tajo-dist/src/main/conf/catalog-site.xml.template
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #496 (See https://builds.apache.org/job/Tajo-master-build/496/ ) TAJO-1243 : *-site.xml.template should have default configs commented out. (hyunsik: rev 876adcfbe358c6d91d9a50ba81847ebba1f0184d) tajo-dist/src/main/conf/tajo-site.xml.template tajo-dist/src/main/conf/catalog-site.xml.template CHANGES

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development