Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1231

Implicit table properties in session are not stored in table property.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      Tajo provides session variables. Some session variables can affect implicitly table properties. For example, NULL_CHAR will be applied to table properties in TEXT based file formats.

      But, CTAS does not store such an implicitly applied property to table properties of tables even though the property is already used for the table.

      1. TAJO-1231.patch
        6 kB
        Hyunsik Choi

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/287

        TAJO-1231: Implicit table properties in session is not stored in table p...

        ...roperty.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1231

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/287.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #287


        commit d4c60df86143834f9b95698262bb6c50da9b7527
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-12-05T02:43:15Z

        TAJO-1231: Implicit table properties in session is not stored in table property.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/287 TAJO-1231 : Implicit table properties in session is not stored in table p... ...roperty. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1231 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #287 commit d4c60df86143834f9b95698262bb6c50da9b7527 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-12-05T02:43:15Z TAJO-1231 : Implicit table properties in session is not stored in table property.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12685232/TAJO-1231.patch
        against master revision release-0.9.0-rc0-72-g2a69bcc.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 222 new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 392 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-plan.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/526//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/526//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/526//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/526//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/526//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685232/TAJO-1231.patch against master revision release-0.9.0-rc0-72-g2a69bcc. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 222 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 392 release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/526//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/526//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/526//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/526//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/526//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        +1 LGTM

        Show
        jhkim Jinho Kim added a comment - +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/287

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/287
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. Thanks for the quick review!

        Show
        hyunsik Hyunsik Choi added a comment - committed. Thanks for the quick review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #483 (See https://builds.apache.org/job/Tajo-master-build/483/)
        TAJO-1231: Implicit table properties in session is not stored in table property. (hyunsik: rev ab2efce8fb4015523a9a818f0e03fa57c6366585)

        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #483 (See https://builds.apache.org/job/Tajo-master-build/483/ ) TAJO-1231 : Implicit table properties in session is not stored in table property. (hyunsik: rev ab2efce8fb4015523a9a818f0e03fa57c6366585) tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java CHANGES tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #124 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/124/)
        TAJO-1231: Implicit table properties in session is not stored in table property. (hyunsik: rev ab2efce8fb4015523a9a818f0e03fa57c6366585)

        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #124 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/124/ ) TAJO-1231 : Implicit table properties in session is not stored in table property. (hyunsik: rev ab2efce8fb4015523a9a818f0e03fa57c6366585) tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development