Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1223

Wrong query verification against asterisk and more expressions in select list

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Reproduction

      create table lineitem_year_month (
       l_orderkey bigint,
       l_partkey bigint,
       l_suppkey bigint,
       l_linenumber int,
       l_quantity float8,
       l_extendedprice float8,
       l_discount float8,
       l_tax float8,
       l_returnflag text,
       l_linestatus text,
       l_shipdate text,
       l_commitdate text,
       l_receiptdate text,
       l_shipinstruct text,
       l_shipmode text,
       l_comment text
      ) PARTITION BY COLUMN (year TEXT, MONTH TEXT);
      
      $ INSERT INTO lineitem_year_month 
        SELECT *, SUBSTR(l_shipdate, 1,4) as year, SUBSTR(l_shipdate, 6, 2) as month 
        FROM 
        default.lineitem;
      
      ERROR: INSERT has smaller expressions than target columns
      
      1. TAJO-1223.patch
        9 kB
        Hyunsik Choi

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/279

        TAJO-1223: Wrong query verification against asterisk and more expression...

        ...s in select list.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1223

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/279.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #279


        commit 55151f580cddd597b7d2d8244fc457095c2f514b
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-12-03T08:34:28Z

        TAJO-1223: Wrong query verification against asterisk and more expressions in select list.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/279 TAJO-1223 : Wrong query verification against asterisk and more expression... ...s in select list. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1223 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/279.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #279 commit 55151f580cddd597b7d2d8244fc457095c2f514b Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-12-03T08:34:28Z TAJO-1223 : Wrong query verification against asterisk and more expressions in select list.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12684846/TAJO-1223.patch
        against master revision release-0.9.0-rc0-67-gea2dbf8.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 222 new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 360 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-plan.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/524//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/524//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/524//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/524//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/524//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684846/TAJO-1223.patch against master revision release-0.9.0-rc0-67-gea2dbf8. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 222 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 360 release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/524//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/524//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/524//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/524//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/524//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        +1 LGTM

        Show
        jhkim Jinho Kim added a comment - +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/279

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/279
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #478 (See https://builds.apache.org/job/Tajo-master-build/478/)
        TAJO-1223: Wrong query verification against asterisk and more expressions in select list. (hyunsik: rev 20d1f0145b47e6c478bb55c79d670926e66f137c)

        • tajo-core/src/test/resources/queries/TestInsertQuery/lineitem_year_month_ddl.sql
        • tajo-core/src/test/resources/results/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.result
        • tajo-core/src/test/resources/queries/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.sql
        • tajo-core/src/test/resources/queries/TestInsertQuery/load_to_lineitem_year_month.sql
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #478 (See https://builds.apache.org/job/Tajo-master-build/478/ ) TAJO-1223 : Wrong query verification against asterisk and more expressions in select list. (hyunsik: rev 20d1f0145b47e6c478bb55c79d670926e66f137c) tajo-core/src/test/resources/queries/TestInsertQuery/lineitem_year_month_ddl.sql tajo-core/src/test/resources/results/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.result tajo-core/src/test/resources/queries/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.sql tajo-core/src/test/resources/queries/TestInsertQuery/load_to_lineitem_year_month.sql tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #119 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/119/)
        TAJO-1223: Wrong query verification against asterisk and more expressions in select list. (hyunsik: rev 20d1f0145b47e6c478bb55c79d670926e66f137c)

        • tajo-core/src/test/resources/queries/TestInsertQuery/lineitem_year_month_ddl.sql
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-core/src/test/resources/queries/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.sql
        • tajo-core/src/test/resources/queries/TestInsertQuery/load_to_lineitem_year_month.sql
        • tajo-core/src/test/resources/results/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.result
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #119 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/119/ ) TAJO-1223 : Wrong query verification against asterisk and more expressions in select list. (hyunsik: rev 20d1f0145b47e6c478bb55c79d670926e66f137c) tajo-core/src/test/resources/queries/TestInsertQuery/lineitem_year_month_ddl.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-core/src/test/resources/queries/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.sql tajo-core/src/test/resources/queries/TestInsertQuery/load_to_lineitem_year_month.sql tajo-core/src/test/resources/results/TestInsertQuery/testInsertOverwriteWithAsteriskAndMore.result

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development