Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1220

Implement createStatement() and setEscapeProcessing() in JdbcConnection

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: JDBC Driver
    • Labels:
      None

      Description

      If using some sql workbench, implement JDBC function the following.

      • Statement createStatement(int resultSetType, int resultSetConcurrency)
      • void setEscapeProcessing(boolean enable)

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hys9958 opened a pull request:

        https://github.com/apache/tajo/pull/276

        TAJO-1220: Implement JDBC function for 'createStatement' and 'setEscapeP...

        Hi guys!

        • Statement createStatement(int resultSetType, int resultSetConcurrency)
        • Support 'CONCUR_READ_ONLY' only.
        • Not support 'TYPE_SCROLL_SENSITIVE'.
        • void setEscapeProcessing(boolean enable)
        • Tajo is not necessary the function. So do nothing.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hys9958/tajo tajo-1220

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/276.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #276


        commit ffd5aa0dd188d35214f9ea1edc792a4e77184b32
        Author: hys9958 <hanyounsu@gmail.com>
        Date: 2014-12-02T07:04:43Z

        TAJO-1220: Implement JDBC function for 'createStatement' and 'setEscapeProcessing'.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hys9958 opened a pull request: https://github.com/apache/tajo/pull/276 TAJO-1220 : Implement JDBC function for 'createStatement' and 'setEscapeP... Hi guys! Statement createStatement(int resultSetType, int resultSetConcurrency) Support 'CONCUR_READ_ONLY' only. Not support 'TYPE_SCROLL_SENSITIVE'. void setEscapeProcessing(boolean enable) Tajo is not necessary the function. So do nothing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hys9958/tajo tajo-1220 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/276.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #276 commit ffd5aa0dd188d35214f9ea1edc792a4e77184b32 Author: hys9958 <hanyounsu@gmail.com> Date: 2014-12-02T07:04:43Z TAJO-1220 : Implement JDBC function for 'createStatement' and 'setEscapeProcessing'.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I've slightly changed the issue title.

        Show
        hyunsik Hyunsik Choi added a comment - I've slightly changed the issue title.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/276#issuecomment-65363952

        +1
        In overall, the fix looks straightforward. I've slightly changed the comments and some codes. I'll commit it shortly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/276#issuecomment-65363952 +1 In overall, the fix looks straightforward. I've slightly changed the comments and some codes. I'll commit it shortly.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed the patch to master branch. Thank you for your contribution!

        Show
        hyunsik Hyunsik Choi added a comment - I just committed the patch to master branch. Thank you for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hys9958 closed the pull request at:

        https://github.com/apache/tajo/pull/276

        Show
        githubbot ASF GitHub Bot added a comment - Github user hys9958 closed the pull request at: https://github.com/apache/tajo/pull/276
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hys9958 commented on the pull request:

        https://github.com/apache/tajo/pull/276#issuecomment-65364879

        Thanks

        Show
        githubbot ASF GitHub Bot added a comment - Github user hys9958 commented on the pull request: https://github.com/apache/tajo/pull/276#issuecomment-65364879 Thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #477 (See https://builds.apache.org/job/Tajo-master-build/477/)
        TAJO-1220: Implement createStatement() and setEscapeProcessing() in JdbcConnection. (YeonSu Han via hyunsik) (hyunsik: rev ea2dbf82c04d609dac46abd322241a15ccf30956)

        • CHANGES
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #477 (See https://builds.apache.org/job/Tajo-master-build/477/ ) TAJO-1220 : Implement createStatement() and setEscapeProcessing() in JdbcConnection. (YeonSu Han via hyunsik) (hyunsik: rev ea2dbf82c04d609dac46abd322241a15ccf30956) CHANGES tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #118 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/118/)
        TAJO-1220: Implement createStatement() and setEscapeProcessing() in JdbcConnection. (YeonSu Han via hyunsik) (hyunsik: rev ea2dbf82c04d609dac46abd322241a15ccf30956)

        • CHANGES
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #118 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/118/ ) TAJO-1220 : Implement createStatement() and setEscapeProcessing() in JdbcConnection. (YeonSu Han via hyunsik) (hyunsik: rev ea2dbf82c04d609dac46abd322241a15ccf30956) CHANGES tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java

          People

          • Assignee:
            hys9958 YeonSu Han
            Reporter:
            hys9958 YeonSu Han
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development