Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1210

ByteBufLineReader does not handle the end of file, if newline is not appeared

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: Storage
    • Labels:
      None

      Description

      Sometimes, generated text file are not contains newline

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/272

        TAJO-1210: ByteBufLineReader does not handle the end of file, if newline...

        ... is not appeared.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1210

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/272.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #272


        commit eac676801d7c53aa99503e157bbec6f8812f6a06
        Author: jhkim <jhkim@apache.org>
        Date: 2014-11-28T08:00:11Z

        TAJO-1210: ByteBufLineReader does not handle the end of file, if newline is not appeared.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/272 TAJO-1210 : ByteBufLineReader does not handle the end of file, if newline... ... is not appeared. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1210 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/272.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #272 commit eac676801d7c53aa99503e157bbec6f8812f6a06 Author: jhkim <jhkim@apache.org> Date: 2014-11-28T08:00:11Z TAJO-1210 : ByteBufLineReader does not handle the end of file, if newline is not appeared.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/272#issuecomment-64978366

        +1

        The patch looks straightforward and the unit test looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/272#issuecomment-64978366 +1 The patch looks straightforward and the unit test looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/272

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/272
        Hide
        jhkim Jinho Kim added a comment -

        committed it!
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it! Thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #472 (See https://builds.apache.org/job/Tajo-master-build/472/)
        TAJO-1210: ByteBufLineReader does not handle the end of file, if newline is not appeared. (jinho) (jhkim: rev bf68b770e6abbb4c63d696e264a348bb1ddb5982)

        • CHANGES
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestLineReader.java
        • tajo-storage/src/test/resources/testVariousTypes.avsc
        • tajo-storage/src/test/resources/dataset/testLineText.txt
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/ByteBufLineReader.java
        • tajo-storage/pom.xml
        • tajo-storage/src/test/resources/dataset/testVariousTypes.avsc
        • tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #472 (See https://builds.apache.org/job/Tajo-master-build/472/ ) TAJO-1210 : ByteBufLineReader does not handle the end of file, if newline is not appeared. (jinho) (jhkim: rev bf68b770e6abbb4c63d696e264a348bb1ddb5982) CHANGES tajo-storage/src/test/java/org/apache/tajo/storage/TestLineReader.java tajo-storage/src/test/resources/testVariousTypes.avsc tajo-storage/src/test/resources/dataset/testLineText.txt tajo-storage/src/main/java/org/apache/tajo/storage/text/ByteBufLineReader.java tajo-storage/pom.xml tajo-storage/src/test/resources/dataset/testVariousTypes.avsc tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #113 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/113/)
        TAJO-1210: ByteBufLineReader does not handle the end of file, if newline is not appeared. (jinho) (jhkim: rev bf68b770e6abbb4c63d696e264a348bb1ddb5982)

        • tajo-storage/src/test/resources/testVariousTypes.avsc
        • tajo-storage/src/test/resources/dataset/testVariousTypes.avsc
        • CHANGES
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestLineReader.java
        • tajo-storage/src/test/resources/dataset/testLineText.txt
        • tajo-storage/pom.xml
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/ByteBufLineReader.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #113 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/113/ ) TAJO-1210 : ByteBufLineReader does not handle the end of file, if newline is not appeared. (jinho) (jhkim: rev bf68b770e6abbb4c63d696e264a348bb1ddb5982) tajo-storage/src/test/resources/testVariousTypes.avsc tajo-storage/src/test/resources/dataset/testVariousTypes.avsc CHANGES tajo-storage/src/test/java/org/apache/tajo/storage/TestLineReader.java tajo-storage/src/test/resources/dataset/testLineText.txt tajo-storage/pom.xml tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/src/main/java/org/apache/tajo/storage/text/ByteBufLineReader.java tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development