Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1205

Remove possible memory leak in TajoMaster

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.10.0
    • Component/s: Offheap
    • Labels:
      None

      Description

      A finishedQuery does not removed in finishedQueryMap.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/265

        TAJO-1205: Remove possible memory leak in TajoMaster

        In addition, I add the memory limitation in query executor of webUI

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1205

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/265.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #265


        commit 3e60142d338fd95a7b082998a6c75e1639ecf009
        Author: jhkim <jhkim@apache.org>
        Date: 2014-11-21T06:04:16Z

        TAJO-1205: Remove possible memory leak in TajoMaster


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/265 TAJO-1205 : Remove possible memory leak in TajoMaster In addition, I add the memory limitation in query executor of webUI You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1205 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/265.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #265 commit 3e60142d338fd95a7b082998a6c75e1639ecf009 Author: jhkim <jhkim@apache.org> Date: 2014-11-21T06:04:16Z TAJO-1205 : Remove possible memory leak in TajoMaster
        Hide
        hyunsik Hyunsik Choi added a comment -

        It seems to be an urgent issue. So, I just changed the priority.

        Show
        hyunsik Hyunsik Choi added a comment - It seems to be an urgent issue. So, I just changed the priority.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I'll finish the review soon.

        Show
        hyunsik Hyunsik Choi added a comment - I'll finish the review soon.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/265#issuecomment-63933012

        +1

        This work allows TajoMaster to use the persistent history instead of HashMap. The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/265#issuecomment-63933012 +1 This work allows TajoMaster to use the persistent history instead of HashMap. The patch looks good to me.
        Hide
        jhkim Jinho Kim added a comment -

        Thank you for your quick review!!

        Show
        jhkim Jinho Kim added a comment - Thank you for your quick review!!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #460 (See https://builds.apache.org/job/Tajo-master-build/460/)
        TAJO-1205: Remove possible memory leak in TajoMaster. (jinho) (jhkim: rev 80afe993b82d57582fbeab64d20199f4dfa3d9af)

        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/worker/TestHistory.java
        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java
        • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-core/src/main/resources/webapps/admin/index.jsp
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #460 (See https://builds.apache.org/job/Tajo-master-build/460/ ) TAJO-1205 : Remove possible memory leak in TajoMaster. (jinho) (jhkim: rev 80afe993b82d57582fbeab64d20199f4dfa3d9af) tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java CHANGES tajo-core/src/test/java/org/apache/tajo/worker/TestHistory.java tajo-core/src/main/resources/webapps/admin/query_executor.jsp tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/resources/webapps/admin/index.jsp
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #102 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/102/)
        TAJO-1205: Remove possible memory leak in TajoMaster. (jinho) (jhkim: rev 80afe993b82d57582fbeab64d20199f4dfa3d9af)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestHistory.java
        • CHANGES
        • tajo-core/src/main/resources/webapps/admin/index.jsp
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #102 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/102/ ) TAJO-1205 : Remove possible memory leak in TajoMaster. (jinho) (jhkim: rev 80afe993b82d57582fbeab64d20199f4dfa3d9af) tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/test/java/org/apache/tajo/worker/TestHistory.java CHANGES tajo-core/src/main/resources/webapps/admin/index.jsp tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java tajo-core/src/main/resources/webapps/admin/query_executor.jsp tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/265

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/265

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development