[TAJO-120] TestCase doesn't call ResultSet.close

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.2-incubating
• Fix Version/s: 0.2-incubating
• Component/s: SQL Shell
• Assignee: Hyoungjun Kim
• Reporter: Hyoungjun Kim
• Created: 06/Aug/13 12:10
• Updated: 05/Sep/13 05:31
• Resolved: 26/Aug/13 12:32

Description

Current implementation is

ResultSet res = tpch.execute("select 100 * sum(" +
        "case when p_type like 'PROMO%' then l_extendedprice else 0.0 end) / sum(l_extendedprice * (1 - l_discount)) "
        + "as promo_revenue from lineitem, part where l_partkey = p_partkey");

assertTrue(res.next());
assertEquals(33, res.getInt(1));

Changed implementation is

ResultSet res = tpch.execute("select 100 * sum(" +
        "case when p_type like 'PROMO%' then l_extendedprice else 0.0 end) / sum(l_extendedprice * (1 - l_discount)) "
        + "as promo_revenue from lineitem, part where l_partkey = p_partkey");

try {
  assertTrue(res.next());
  assertEquals(33, res.getInt(1));
} finally {
  res.close();
}

Issue Links

• relates to: TAJO-127 Implement Tajo Resource Manager