Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1195

Remove unused CachedDNSResolver Class

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Tools
    • Labels:
      None

      Description

      Tajo doesn't use CachedDNSResolver.java anymore.
      So I think it is better to remove this class for Readability.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/253

        TAJO-1195: Remove unused CachedDNSResolver Class

        Tajo doesn't use CachedDNSResolver.java anymore.
        So I think it is better to remove this class for Readability.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/remove_unused_class

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/253.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #253


        commit c91b1dc94db2c7a42909ed08fe21e85cd87618af
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2014-11-18T12:59:27Z

        Remove CachedDNSResolver.java


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/253 TAJO-1195 : Remove unused CachedDNSResolver Class Tajo doesn't use CachedDNSResolver.java anymore. So I think it is better to remove this class for Readability. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/remove_unused_class Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/253.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #253 commit c91b1dc94db2c7a42909ed08fe21e85cd87618af Author: clark.kang <clark.kang@kakao.com> Date: 2014-11-18T12:59:27Z Remove CachedDNSResolver.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/253#issuecomment-63598571

        Hi @charsyam

        +1

        Thanks for your contribution.
        I'll push it to the master branch.

        Cheers
        Jaehwa

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/253#issuecomment-63598571 Hi @charsyam +1 Thanks for your contribution. I'll push it to the master branch. Cheers Jaehwa
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #456 (See https://builds.apache.org/job/Tajo-master-build/456/)
        TAJO-1195: Remove unused CachedDNSResolver Class. (DaeMyung Kang via jaehwa) (blrunner: rev 67bdc71b17b54da731eaf01b9fac51ad8983353b)

        • tajo-core/src/main/java/org/apache/tajo/net/CachedDNSResolver.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #456 (See https://builds.apache.org/job/Tajo-master-build/456/ ) TAJO-1195 : Remove unused CachedDNSResolver Class. (DaeMyung Kang via jaehwa) (blrunner: rev 67bdc71b17b54da731eaf01b9fac51ad8983353b) tajo-core/src/main/java/org/apache/tajo/net/CachedDNSResolver.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #98 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/98/)
        TAJO-1195: Remove unused CachedDNSResolver Class. (DaeMyung Kang via jaehwa) (blrunner: rev 67bdc71b17b54da731eaf01b9fac51ad8983353b)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/net/CachedDNSResolver.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #98 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/98/ ) TAJO-1195 : Remove unused CachedDNSResolver Class. (DaeMyung Kang via jaehwa) (blrunner: rev 67bdc71b17b54da731eaf01b9fac51ad8983353b) CHANGES tajo-core/src/main/java/org/apache/tajo/net/CachedDNSResolver.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/253#issuecomment-63601825

        It seems to be committed to master branch.

        @charsyam could you close this issue?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/253#issuecomment-63601825 It seems to be committed to master branch. @charsyam could you close this issue?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam closed the pull request at:

        https://github.com/apache/tajo/pull/253

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam closed the pull request at: https://github.com/apache/tajo/pull/253
        Hide
        hyunsik Hyunsik Choi added a comment -

        Already committed. Fixing it as resolved.

        Show
        hyunsik Hyunsik Choi added a comment - Already committed. Fixing it as resolved.

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development