Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1194

'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: distributed query plan
    • Labels:
      None

      Description

      Background
      INSERT OVERWRITE INTO XXX SELECT ... FROM Y overwrites only the partitions which corresponds to the query results. If the query result is empty, all partitions should be removed.

      Problem
      The current implementation does not remove any partition if the query result is empty.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user blrunner opened a pull request:

          https://github.com/apache/tajo/pull/254

          TAJO-1194: 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/blrunner/tajo TAJO-1194

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/254.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #254


          commit 9d5f0239206106adaf114a90b8f60dd1c106a578
          Author: JaeHwa Jung <blrunner@apache.org>
          Date: 2014-11-19T03:51:51Z

          Initial Commit


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/254 TAJO-1194 : 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1194 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/254.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #254 commit 9d5f0239206106adaf114a90b8f60dd1c106a578 Author: JaeHwa Jung <blrunner@apache.org> Date: 2014-11-19T03:51:51Z Initial Commit
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/254#issuecomment-65165371

          Could you trigger TravisCI unit test again?

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/254#issuecomment-65165371 Could you trigger TravisCI unit test again?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/254#issuecomment-65362838

          LGTM +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/254#issuecomment-65362838 LGTM +1
          Hide
          blrunner Jaehwa Jung added a comment -

          I've committed it to master branch.

          Show
          blrunner Jaehwa Jung added a comment - I've committed it to master branch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #481 (See https://builds.apache.org/job/Tajo-master-build/481/)
          TAJO-1194: 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (jaehwa) (blrunner: rev f6da07b03587d2bce5ca4ac53d86eae3a8ba23c2)

          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #481 (See https://builds.apache.org/job/Tajo-master-build/481/ ) TAJO-1194 : 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (jaehwa) (blrunner: rev f6da07b03587d2bce5ca4ac53d86eae3a8ba23c2) CHANGES tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #122 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/122/)
          TAJO-1194: 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (jaehwa) (blrunner: rev f6da07b03587d2bce5ca4ac53d86eae3a8ba23c2)

          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          • CHANGES
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #122 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/122/ ) TAJO-1194 : 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (jaehwa) (blrunner: rev f6da07b03587d2bce5ca4ac53d86eae3a8ba23c2) tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #482 (See https://builds.apache.org/job/Tajo-master-build/482/)
          TAJO-1194: 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (missing code) (blrunner: rev 2a69bcc218a53eced0cdb9217de1fdd1837c0827)

          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #482 (See https://builds.apache.org/job/Tajo-master-build/482/ ) TAJO-1194 : 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (missing code) (blrunner: rev 2a69bcc218a53eced0cdb9217de1fdd1837c0827) tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #123 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/123/)
          TAJO-1194: 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (missing code) (blrunner: rev 2a69bcc218a53eced0cdb9217de1fdd1837c0827)

          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #123 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/123/ ) TAJO-1194 : 'INSERT OVERWRITE .. SELECT' does not remove existing data when result is empty. (missing code) (blrunner: rev 2a69bcc218a53eced0cdb9217de1fdd1837c0827) tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java

            People

            • Assignee:
              blrunner Jaehwa Jung
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development