Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1188

Fix testcase testTimestampConstructor in TestTimestampDatum

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      This is also timezone bug.
      but, before adding timezone info into tajo.
      I think it is better to fix testcase for this case.

      testTimestampConstructor in TestTimestampDatum will break the test because of timezone.

      it compares UTC date and jvm timezone date.
      so it needs to set timezone as UTC for Calendar.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/249

        TAJO-1188: Fix testcase testTimestampConstructor in TestTimestampDatum

        This is also timezone bug.
        but, before adding timezone info into tajo.
        I think it is better to fix testcase for this case.
        testTimestampConstructor in TestTimestampDatum will break the test because of timezone.
        it compares UTC date and jvm timezone date.
        so it needs to set timezone as UTC for Calendar.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/fix-test

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/249.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #249


        commit bbf203217ca966502a15cd6b72326b3b8a82624c
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2014-11-17T17:23:20Z

        fix testcases for timezone


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/249 TAJO-1188 : Fix testcase testTimestampConstructor in TestTimestampDatum This is also timezone bug. but, before adding timezone info into tajo. I think it is better to fix testcase for this case. testTimestampConstructor in TestTimestampDatum will break the test because of timezone. it compares UTC date and jvm timezone date. so it needs to set timezone as UTC for Calendar. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/fix-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit bbf203217ca966502a15cd6b72326b3b8a82624c Author: clark.kang <clark.kang@kakao.com> Date: 2014-11-17T17:23:20Z fix testcases for timezone
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/249#issuecomment-63934293

        +1

        This fix is reasonable. The test should be tested with UTC.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/249#issuecomment-63934293 +1 This fix is reasonable. The test should be tested with UTC.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed the patch to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - I just committed the patch to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/249#issuecomment-64326472

        Hi @charsyam,

        I just committed. But, I missed to include the github command 'closes #249', which forces github to automatically close this ticket. Could you close manually this issue?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/249#issuecomment-64326472 Hi @charsyam, I just committed. But, I missed to include the github command 'closes #249', which forces github to automatically close this ticket. Could you close manually this issue?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #463 (See https://builds.apache.org/job/Tajo-master-build/463/)
        TAJO-1188: Fix testcase testTimestampConstructor in TestTimestampDatum. (DaeMyung Kang via hyunsik) (hyunsik: rev 0c97fc0319b0f33c3a76f591d48cb52f1df92567)

        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #463 (See https://builds.apache.org/job/Tajo-master-build/463/ ) TAJO-1188 : Fix testcase testTimestampConstructor in TestTimestampDatum. (DaeMyung Kang via hyunsik) (hyunsik: rev 0c97fc0319b0f33c3a76f591d48cb52f1df92567) tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #105 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/105/)
        TAJO-1188: Fix testcase testTimestampConstructor in TestTimestampDatum. (DaeMyung Kang via hyunsik) (hyunsik: rev 0c97fc0319b0f33c3a76f591d48cb52f1df92567)

        • CHANGES
        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #105 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/105/ ) TAJO-1188 : Fix testcase testTimestampConstructor in TestTimestampDatum. (DaeMyung Kang via hyunsik) (hyunsik: rev 0c97fc0319b0f33c3a76f591d48cb52f1df92567) CHANGES tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam closed the pull request at:

        https://github.com/apache/tajo/pull/249

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam closed the pull request at: https://github.com/apache/tajo/pull/249

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development