Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1181

Avro schema URL should support various protocols.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.1
    • Fix Version/s: 0.10.0
    • Component/s: Storage
    • Labels:

      Description

      See the following source code:

      org.apache.tajo.storage.avro.AvroUtil.java
      String schemaURL = meta.getOption(StorageConstants.AVRO_SCHEMA_URL);
          Path schemaPath = new Path(schemaURL);
          FileSystem fs = schemaPath.getFileSystem(conf);
          FSDataInputStream inputStream = fs.open(schemaPath);
      

      Currently, Avro schema URL only support HDFS and S3. But, it does not support HTTP and others. HTTP-based schema is very usual in this field. We need to improve it to support HTTP.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/252

        TAJO-1181: Avro schema URL should support various protocols.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1181

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/252.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #252


        commit 2ab089c2cd0c1902351888aea1863405a30f4d3e
        Author: jhkim <jhkim@apache.org>
        Date: 2014-11-18T13:27:00Z

        TAJO-1181: Avro schema URL should support various protocols.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/252 TAJO-1181 : Avro schema URL should support various protocols. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1181 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #252 commit 2ab089c2cd0c1902351888aea1863405a30f4d3e Author: jhkim <jhkim@apache.org> Date: 2014-11-18T13:27:00Z TAJO-1181 : Avro schema URL should support various protocols.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/252#issuecomment-63666564

        ++1

        Excellent work! The newly added unit tests verify all cases.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/252#issuecomment-63666564 ++1 Excellent work! The newly added unit tests verify all cases.
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        thanks.

        Show
        jhkim Jinho Kim added a comment - committed it. thanks.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #459 (See https://builds.apache.org/job/Tajo-master-build/459/)
        TAJO-1181: Avro schema URL should support various protocols. (jinho) (jhkim: rev 965cbd90778e2c6872e04456e94a19dd2e4f27f5)

        • tajo-storage/src/main/java/org/apache/tajo/storage/avro/AvroUtil.java
        • tajo-storage/src/test/java/org/apache/tajo/HttpFileServer.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java
        • tajo-storage/src/test/java/org/apache/tajo/HttpFileServerPipelineFactory.java
        • tajo-storage/src/test/java/org/apache/tajo/HttpFileServerHandler.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #459 (See https://builds.apache.org/job/Tajo-master-build/459/ ) TAJO-1181 : Avro schema URL should support various protocols. (jinho) (jhkim: rev 965cbd90778e2c6872e04456e94a19dd2e4f27f5) tajo-storage/src/main/java/org/apache/tajo/storage/avro/AvroUtil.java tajo-storage/src/test/java/org/apache/tajo/HttpFileServer.java tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java tajo-storage/src/test/java/org/apache/tajo/HttpFileServerPipelineFactory.java tajo-storage/src/test/java/org/apache/tajo/HttpFileServerHandler.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #101 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/101/)
        TAJO-1181: Avro schema URL should support various protocols. (jinho) (jhkim: rev 965cbd90778e2c6872e04456e94a19dd2e4f27f5)

        • tajo-storage/src/test/java/org/apache/tajo/HttpFileServer.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/avro/AvroUtil.java
        • tajo-storage/src/test/java/org/apache/tajo/HttpFileServerPipelineFactory.java
        • CHANGES
        • tajo-storage/src/test/java/org/apache/tajo/HttpFileServerHandler.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #101 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/101/ ) TAJO-1181 : Avro schema URL should support various protocols. (jinho) (jhkim: rev 965cbd90778e2c6872e04456e94a19dd2e4f27f5) tajo-storage/src/test/java/org/apache/tajo/HttpFileServer.java tajo-storage/src/main/java/org/apache/tajo/storage/avro/AvroUtil.java tajo-storage/src/test/java/org/apache/tajo/HttpFileServerPipelineFactory.java CHANGES tajo-storage/src/test/java/org/apache/tajo/HttpFileServerHandler.java tajo-storage/src/test/java/org/apache/tajo/storage/avro/TestAvroUtil.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/252

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/252

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development