Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1174

remove unnessary codes for blobdatum

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      in blobdatum

      we don't need to call initFromBytes() in equals()
      because it just compare Byte array, not ByteBuffer.

      so it is better to remove unnessary codes.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam closed the pull request at:

        https://github.com/apache/tajo/pull/241

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam closed the pull request at: https://github.com/apache/tajo/pull/241
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/241#issuecomment-63182455

        @charsyam Could you close this issue? I missed to add 'close command' in the commit log. Thank you for your contribution.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/241#issuecomment-63182455 @charsyam Could you close this issue? I missed to add 'close command' in the commit log. Thank you for your contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #91 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/91/)
        TAJO-1174: remove unnessary codes for blobdatum (DaeMyung Kang via hyunsik) (hyunsik: rev 17cb3120ed08749719515f21b741ea9551f7857b)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #91 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/91/ ) TAJO-1174 : remove unnessary codes for blobdatum (DaeMyung Kang via hyunsik) (hyunsik: rev 17cb3120ed08749719515f21b741ea9551f7857b) CHANGES tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #449 (See https://builds.apache.org/job/Tajo-master-build/449/)
        TAJO-1174: remove unnessary codes for blobdatum (DaeMyung Kang via hyunsik) (hyunsik: rev 17cb3120ed08749719515f21b741ea9551f7857b)

        • tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #449 (See https://builds.apache.org/job/Tajo-master-build/449/ ) TAJO-1174 : remove unnessary codes for blobdatum (DaeMyung Kang via hyunsik) (hyunsik: rev 17cb3120ed08749719515f21b741ea9551f7857b) tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed to master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed to master branch. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/241#issuecomment-63169386

        +1
        The fix looks straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/241#issuecomment-63169386 +1 The fix looks straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/241

        TAJO-1174: remove unnessary codes for blobdatum

        in blobdatum
        we don't need to call initFromBytes() in equals()
        because it just compare Byte array, not ByteBuffer.
        so it is better to remove unnessary codes.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/remove_unnessary_code_for_blobdatum

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/241.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #241


        commit dea1d6ec7065fd8ae0d4497b9773e9b5faffdc21
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2014-11-13T15:50:05Z

        remove_unnessary_code_for_blobdatum


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/241 TAJO-1174 : remove unnessary codes for blobdatum in blobdatum we don't need to call initFromBytes() in equals() because it just compare Byte array, not ByteBuffer. so it is better to remove unnessary codes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/remove_unnessary_code_for_blobdatum Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #241 commit dea1d6ec7065fd8ae0d4497b9773e9b5faffdc21 Author: clark.kang <clark.kang@kakao.com> Date: 2014-11-13T15:50:05Z remove_unnessary_code_for_blobdatum

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development