Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1161

Remove joda time dependency from tajo-core

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Before 0.9.0, we had used jodatime for datetime types and functions. But, we already have our own datetime system. But, a few of some function like DateTimePartFromUnixTimestamp still uses jodatime. If we improve these functions, we can completely remove jodatime from our dependency.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/233

        TAJO-1161: Remove joda time dependency from tajo-core

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1161

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/233.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #233


        commit 6cfe4cdb65bfe9eb829d6c4fcaf737ab487471d7
        Author: Jihun Kang <ykrips@gmail.com>
        Date: 2014-11-10T09:27:27Z

        TAJO-1161: Remove joda time dependency from tajo-core


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/233 TAJO-1161 : Remove joda time dependency from tajo-core You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1161 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit 6cfe4cdb65bfe9eb829d6c4fcaf737ab487471d7 Author: Jihun Kang <ykrips@gmail.com> Date: 2014-11-10T09:27:27Z TAJO-1161 : Remove joda time dependency from tajo-core
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/233#issuecomment-62480883

        It has a trivial conflict in pom.xml, but I could merge easily the patch to the latest revision. I also verified 'mvn clean install'.

        The work is excellent. Here is my +1. I'll commit the patch if there is no objection by today.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/233#issuecomment-62480883 It has a trivial conflict in pom.xml, but I could merge easily the patch to the latest revision. I also verified 'mvn clean install'. The work is excellent. Here is my +1. I'll commit the patch if there is no objection by today.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/233#issuecomment-62513694

        I'll commit it shortly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/233#issuecomment-62513694 I'll commit it shortly.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. Thank you for your contribution!

        Show
        hyunsik Hyunsik Choi added a comment - committed. Thank you for your contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #444 (See https://builds.apache.org/job/Tajo-master-build/444/)
        TAJO-1161: Remove joda time dependency from tajo-core. (Jihun Kang via hyunsik) (hyunsik: rev 2b8d30ca2ca4fbf1dfda58f482c952441178390d)

        • tajo-rpc/pom.xml
        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DateTimePartFromUnixTimestamp.java
        • tajo-common/pom.xml
        • tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeFormat.java
        • tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeUtil.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java
        • CHANGES
        • tajo-project/pom.xml
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #444 (See https://builds.apache.org/job/Tajo-master-build/444/ ) TAJO-1161 : Remove joda time dependency from tajo-core. (Jihun Kang via hyunsik) (hyunsik: rev 2b8d30ca2ca4fbf1dfda58f482c952441178390d) tajo-rpc/pom.xml tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DateTimePartFromUnixTimestamp.java tajo-common/pom.xml tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeFormat.java tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeUtil.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java CHANGES tajo-project/pom.xml tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #86 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/86/)
        TAJO-1161: Remove joda time dependency from tajo-core. (Jihun Kang via hyunsik) (hyunsik: rev 2b8d30ca2ca4fbf1dfda58f482c952441178390d)

        • tajo-rpc/pom.xml
        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java
        • tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeUtil.java
        • CHANGES
        • tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeFormat.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        • tajo-common/pom.xml
        • tajo-project/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DateTimePartFromUnixTimestamp.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #86 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/86/ ) TAJO-1161 : Remove joda time dependency from tajo-core. (Jihun Kang via hyunsik) (hyunsik: rev 2b8d30ca2ca4fbf1dfda58f482c952441178390d) tajo-rpc/pom.xml tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeUtil.java CHANGES tajo-common/src/test/java/org/apache/tajo/util/TestDateTimeFormat.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-common/pom.xml tajo-project/pom.xml tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DateTimePartFromUnixTimestamp.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/233

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/233

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development