Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1154

TajoCli doesn't pause while running the non-forwarded query.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Java Client, TajoMaster
    • Labels:
      None

      Description

      If the number of rows in the table statistics is zero, non-forwarded query like the bellow doesn't pause.

      default> \d tpch100.lineitem
      
      table name: tpch100.lineitem
      table path: /tpch/100/lineitem
      store type: CSV
      number of rows: 0
      volume: 79.6 GB
      ...
      
      default> select * from tpch100.lineitem;
      
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/227

        TAJO-1154 - TajoCli doesn't pause while running the non-forwarded query.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-1154

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/227.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #227


        commit 584ed1e84c41c9f2ae2ef4dcdab465084b6d8631
        Author: HyoungJun Kim <babokim@babokim-macbook-pro.local>
        Date: 2014-11-05T10:58:38Z

        TAJO-1154 - TajoCli doesn't pause while running the non-forwarded query.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/227 TAJO-1154 - TajoCli doesn't pause while running the non-forwarded query. You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-1154 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/227.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #227 commit 584ed1e84c41c9f2ae2ef4dcdab465084b6d8631 Author: HyoungJun Kim <babokim@babokim-macbook-pro.local> Date: 2014-11-05T10:58:38Z TAJO-1154 - TajoCli doesn't pause while running the non-forwarded query.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/227#issuecomment-62286186

        +1

        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/227#issuecomment-62286186 +1 The patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/227

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/227
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed it to master branch. Thank you.

        Show
        hyunsik Hyunsik Choi added a comment - I just committed it to master branch. Thank you.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #438 (See https://builds.apache.org/job/Tajo-master-build/438/)
        TAJO-1154: TajoCli doesn't pause while running the non-forwarded query. (Hyoungjun Kim via hyunsik) (hyunsik: rev d65224293671501639772db2141a316752078d76)

        • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-core/src/test/resources/results/TestTajoCli/testNonForwardQueryPause.result
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
        • tajo-client/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #438 (See https://builds.apache.org/job/Tajo-master-build/438/ ) TAJO-1154 : TajoCli doesn't pause while running the non-forwarded query. (Hyoungjun Kim via hyunsik) (hyunsik: rev d65224293671501639772db2141a316752078d76) tajo-common/src/main/java/org/apache/tajo/TajoConstants.java CHANGES tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-core/src/test/resources/results/TestTajoCli/testNonForwardQueryPause.result tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java tajo-client/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #80 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/80/)
        TAJO-1154: TajoCli doesn't pause while running the non-forwarded query. (Hyoungjun Kim via hyunsik) (hyunsik: rev d65224293671501639772db2141a316752078d76)

        • CHANGES
        • tajo-core/src/test/resources/results/TestTajoCli/testNonForwardQueryPause.result
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-client/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
        • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #80 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/80/ ) TAJO-1154 : TajoCli doesn't pause while running the non-forwarded query. (Hyoungjun Kim via hyunsik) (hyunsik: rev d65224293671501639772db2141a316752078d76) CHANGES tajo-core/src/test/resources/results/TestTajoCli/testNonForwardQueryPause.result tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-client/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-client/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-common/src/main/java/org/apache/tajo/TajoConstants.java

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development