Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1150

Some weird methods in QueryClientImpl should be fixed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Java Client
    • Labels:
      None

      Description

      Some methods in QueryClientImpl class such as getSessionVariable, existSessionVariable and getAllSessionVariables are calling themselves.

      It must fall in infinite recursive loop.

      It should be fixed to call proper methods.

        Activity

        Hide
        eminency Jongyoung Park added a comment -

        Fixing was merged by commit a23443570b92333e5d0e337576db68a842caef5f

        Show
        eminency Jongyoung Park added a comment - Fixing was merged by commit a23443570b92333e5d0e337576db68a842caef5f
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #434 (See https://builds.apache.org/job/Tajo-master-build/434/)
        TAJO-1150: Some weird methods in QueryClientImpl should be fixed. (Jongyoung Park via hyunsik) (hyunsik: rev a23443570b92333e5d0e337576db68a842caef5f)

        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #434 (See https://builds.apache.org/job/Tajo-master-build/434/ ) TAJO-1150 : Some weird methods in QueryClientImpl should be fixed. (Jongyoung Park via hyunsik) (hyunsik: rev a23443570b92333e5d0e337576db68a842caef5f) tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #76 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/76/)
        TAJO-1150: Some weird methods in QueryClientImpl should be fixed. (Jongyoung Park via hyunsik) (hyunsik: rev a23443570b92333e5d0e337576db68a842caef5f)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #76 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/76/ ) TAJO-1150 : Some weird methods in QueryClientImpl should be fixed. (Jongyoung Park via hyunsik) (hyunsik: rev a23443570b92333e5d0e337576db68a842caef5f) CHANGES tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/223

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/223
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/223#issuecomment-61568022

        +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/223#issuecomment-61568022 +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eminency opened a pull request:

        https://github.com/apache/tajo/pull/223

        TAJO-1150: Some weird methods in QueryClientImpl should be fixed

        Fixed

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eminency/tajo TAJO-1150

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/223.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #223


        commit 320c2e39b3359349c870749b6a1e212f285fcc3f
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2014-11-02T17:04:26Z

        Calling itself cases are fixed to call connection's methods


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/223 TAJO-1150 : Some weird methods in QueryClientImpl should be fixed Fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1150 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit 320c2e39b3359349c870749b6a1e212f285fcc3f Author: Jongyoung Park <eminency@gmail.com> Date: 2014-11-02T17:04:26Z Calling itself cases are fixed to call connection's methods

          People

          • Assignee:
            eminency Jongyoung Park
            Reporter:
            eminency Jongyoung Park
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development