Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1128

Implement a select box for database at web interface

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:

      Description

      Currently, Tajo supports query execution function at web interface. But we can't select database for executing query. Thus, we need to implement a select box for select database. For reference, there is a select box for database at catalog navigation page of web interface.

        Activity

        Hide
        eminency Jongyoung Park added a comment -

        May I handle this?
        If it is ok, please assign it to me.

        Show
        eminency Jongyoung Park added a comment - May I handle this? If it is ok, please assign it to me.
        Hide
        blrunner Jaehwa Jung added a comment -
        Show
        blrunner Jaehwa Jung added a comment - Jongyoung Park Sure~
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eminency opened a pull request:

        https://github.com/apache/tajo/pull/222

        TAJO-1128: Implement a select box for database at web interface

        Added a select box and code is modified appropriately.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eminency/tajo TAJO-1128

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/222.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #222


        commit a6202ad55c56664ab8f9bd19cc74ca52437f9757
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2014-11-02T16:29:36Z

        Added database parameter in QueryRunner

        commit df38b474430fe0f6f41ea86435a204961f395356
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2014-11-02T16:37:47Z

        Layout refined

        commit 25f42b6eeb36272196633aaab6611731760c7d16
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2014-11-02T16:41:49Z

        Merge commit 'aa5e3b683120a8b1841c523232b7a8a28371e7c9' into TAJO-1128


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/222 TAJO-1128 : Implement a select box for database at web interface Added a select box and code is modified appropriately. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1128 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #222 commit a6202ad55c56664ab8f9bd19cc74ca52437f9757 Author: Jongyoung Park <eminency@gmail.com> Date: 2014-11-02T16:29:36Z Added database parameter in QueryRunner commit df38b474430fe0f6f41ea86435a204961f395356 Author: Jongyoung Park <eminency@gmail.com> Date: 2014-11-02T16:37:47Z Layout refined commit 25f42b6eeb36272196633aaab6611731760c7d16 Author: Jongyoung Park <eminency@gmail.com> Date: 2014-11-02T16:41:49Z Merge commit 'aa5e3b683120a8b1841c523232b7a8a28371e7c9' into TAJO-1128
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/222#issuecomment-62362702

        +1

        The patch looks good to me. I also tested WEB UI. It works well.

        Aside from this issue, non-forward queries do not work. We need to fix it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/222#issuecomment-62362702 +1 The patch looks good to me. I also tested WEB UI. It works well. Aside from this issue, non-forward queries do not work. We need to fix it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #441 (See https://builds.apache.org/job/Tajo-master-build/441/)
        TAJO-1128: Implement a select box for database at web interface. (Jongyoung Park via hyunsik) (hyunsik: rev a3e5bdd69833b87b666c1db567dbf464d84d35f7)

        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #441 (See https://builds.apache.org/job/Tajo-master-build/441/ ) TAJO-1128 : Implement a select box for database at web interface. (Jongyoung Park via hyunsik) (hyunsik: rev a3e5bdd69833b87b666c1db567dbf464d84d35f7) tajo-core/src/main/resources/webapps/admin/query_executor.jsp tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #83 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/83/)
        TAJO-1128: Implement a select box for database at web interface. (Jongyoung Park via hyunsik) (hyunsik: rev a3e5bdd69833b87b666c1db567dbf464d84d35f7)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #83 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/83/ ) TAJO-1128 : Implement a select box for database at web interface. (Jongyoung Park via hyunsik) (hyunsik: rev a3e5bdd69833b87b666c1db567dbf464d84d35f7) CHANGES tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/222

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/222

          People

          • Assignee:
            eminency Jongyoung Park
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development