Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1105

Add thread which detects JVM pauses like HADOOP's

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Worker
    • Labels:
      None

      Description

      Often times we found worker hangs. it caused by a long JVM pause
      This will make GC pauses obvious in logs.

      https://issues.apache.org/jira/browse/HADOOP-9618
      https://issues.apache.org/jira/browse/HBASE-9630

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/191

        TAJO-1105: Add thread which detects JVM pauses like HADOOP's

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1105

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/191.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #191


        commit 403c183ce59c69cb50c8328db206db67dc59ccee
        Author: jhkim <jhkim@apache.org>
        Date: 2014-10-08T06:53:01Z

        TAJO-1105: Add thread which detects JVM pauses like HADOOP's


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/191 TAJO-1105 : Add thread which detects JVM pauses like HADOOP's You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1105 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/191.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #191 commit 403c183ce59c69cb50c8328db206db67dc59ccee Author: jhkim <jhkim@apache.org> Date: 2014-10-08T06:53:01Z TAJO-1105 : Add thread which detects JVM pauses like HADOOP's
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/191#issuecomment-58391404

        +1

        It seems to borrow Hadoop's implementation. It looks good to me. I think that it can be merged to master before 0.9.0 release.

        Before committing it, Could you add one comment line to record that we borrow this class from Hadoop? It would be useful for other guys to maintain the code in the future.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/191#issuecomment-58391404 +1 It seems to borrow Hadoop's implementation. It looks good to me. I think that it can be merged to master before 0.9.0 release. Before committing it, Could you add one comment line to record that we borrow this class from Hadoop? It would be useful for other guys to maintain the code in the future.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/191

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/191
        Hide
        jhkim Jinho Kim added a comment -

        reflected your comments.
        Thank you!

        Show
        jhkim Jinho Kim added a comment - reflected your comments. Thank you!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #405 (See https://builds.apache.org/job/Tajo-master-build/405/)
        TAJO-1105: Add thread which detects JVM pauses like HADOOP's. (jinho) (jhkim: rev 140083bfbaf6dafb330eebbc1c7f7447c5292c1e)

        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/util/JvmPauseMonitor.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #405 (See https://builds.apache.org/job/Tajo-master-build/405/ ) TAJO-1105 : Add thread which detects JVM pauses like HADOOP's. (jinho) (jhkim: rev 140083bfbaf6dafb330eebbc1c7f7447c5292c1e) tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/util/JvmPauseMonitor.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #47 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/47/)
        TAJO-1105: Add thread which detects JVM pauses like HADOOP's. (jinho) (jhkim: rev 140083bfbaf6dafb330eebbc1c7f7447c5292c1e)

        • tajo-core/src/main/java/org/apache/tajo/util/JvmPauseMonitor.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #47 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/47/ ) TAJO-1105 : Add thread which detects JVM pauses like HADOOP's. (jinho) (jhkim: rev 140083bfbaf6dafb330eebbc1c7f7447c5292c1e) tajo-core/src/main/java/org/apache/tajo/util/JvmPauseMonitor.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/)
        TAJO-1105: Add thread which detects JVM pauses like HADOOP's. (jinho) (jhkim: rev 140083bfbaf6dafb330eebbc1c7f7447c5292c1e)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/src/main/java/org/apache/tajo/util/JvmPauseMonitor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/ ) TAJO-1105 : Add thread which detects JVM pauses like HADOOP's. (jinho) (jhkim: rev 140083bfbaf6dafb330eebbc1c7f7447c5292c1e) CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/util/JvmPauseMonitor.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development