Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1104

Using asterisk with GROUP BY causes NPE.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      'SELECT * FROM LINEITEM GROUP BY X' causes NPE in LogicalPlanPreprocessor. We should fix it.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/187

        TAJO-1104: Using asterisk with GROUP BY causes NPE.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1104

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/187.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #187


        commit c0de5455df3d7fdce7fa4c39ddd7c20623614e6f
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-10-07T21:44:49Z

        TAJO-1104: Using asterisk with GROUP BY causes NPE.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/187 TAJO-1104 : Using asterisk with GROUP BY causes NPE. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1104 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #187 commit c0de5455df3d7fdce7fa4c39ddd7c20623614e6f Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-10-07T21:44:49Z TAJO-1104 : Using asterisk with GROUP BY causes NPE.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/187#issuecomment-58268495

        This patch includes some refactoring to move query validation methods to QueryTestCaseBase. In addition, it includes a bug fix for TAJO-1098.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/187#issuecomment-58268495 This patch includes some refactoring to move query validation methods to QueryTestCaseBase. In addition, it includes a bug fix for TAJO-1098 .
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/187#issuecomment-58301849

        +1

        Thanks @hyunsik.
        The patch looks good to me and 'mvn clean install' finished successfully.
        Push it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/187#issuecomment-58301849 +1 Thanks @hyunsik. The patch looks good to me and 'mvn clean install' finished successfully. Push it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/187

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/187
        Hide
        hyunsik Hyunsik Choi added a comment -

        Thank you for the quick review. I just committed the patch to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - Thank you for the quick review. I just committed the patch to master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #400 (See https://builds.apache.org/job/Tajo-master-build/400/)
        TAJO-1104: Using asterisk with GROUP BY causes NPE. (hyunsik: rev 8967d113571fe72131433e39753e41c35abe2297)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_2.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/valid_groupby_1.sql
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/valid_limit_1.sql
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/invalid_casewhen_1.sql
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/invalid_limit_1.sql
        • CHANGES
        • tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_1.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #400 (See https://builds.apache.org/job/Tajo-master-build/400/ ) TAJO-1104 : Using asterisk with GROUP BY causes NPE. (hyunsik: rev 8967d113571fe72131433e39753e41c35abe2297) tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_2.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java tajo-core/src/test/resources/queries/TestQueryValidation/valid_groupby_1.sql tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java tajo-core/src/test/resources/queries/TestQueryValidation/valid_limit_1.sql tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/test/resources/queries/TestQueryValidation/invalid_casewhen_1.sql tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core/src/test/resources/queries/TestQueryValidation/invalid_limit_1.sql CHANGES tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_1.sql
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #42 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/42/)
        TAJO-1104: Using asterisk with GROUP BY causes NPE. (hyunsik: rev 8967d113571fe72131433e39753e41c35abe2297)

        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/valid_limit_1.sql
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/invalid_casewhen_1.sql
        • tajo-core/src/test/resources/queries/TestQueryValidation/valid_groupby_1.sql
        • tajo-core/src/test/resources/queries/TestQueryValidation/invalid_limit_1.sql
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_1.sql
        • tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_2.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #42 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/42/ ) TAJO-1104 : Using asterisk with GROUP BY causes NPE. (hyunsik: rev 8967d113571fe72131433e39753e41c35abe2297) tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/test/resources/queries/TestQueryValidation/valid_limit_1.sql CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java tajo-core/src/test/resources/queries/TestQueryValidation/invalid_casewhen_1.sql tajo-core/src/test/resources/queries/TestQueryValidation/valid_groupby_1.sql tajo-core/src/test/resources/queries/TestQueryValidation/invalid_limit_1.sql tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_1.sql tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_2.sql
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/)
        TAJO-1104: Using asterisk with GROUP BY causes NPE. (hyunsik: rev 8967d113571fe72131433e39753e41c35abe2297)

        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/invalid_limit_1.sql
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/valid_limit_1.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_2.sql
        • tajo-core/src/test/resources/queries/TestQueryValidation/valid_groupby_1.sql
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java
        • tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_1.sql
        • CHANGES
        • tajo-core/src/test/resources/queries/TestQueryValidation/invalid_casewhen_1.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/ ) TAJO-1104 : Using asterisk with GROUP BY causes NPE. (hyunsik: rev 8967d113571fe72131433e39753e41c35abe2297) tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core/src/test/resources/queries/TestQueryValidation/invalid_limit_1.sql tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/test/resources/queries/TestQueryValidation/valid_limit_1.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_2.sql tajo-core/src/test/resources/queries/TestQueryValidation/valid_groupby_1.sql tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java tajo-core/src/test/resources/queries/TestQueryValidation/error_groupby_1.sql CHANGES tajo-core/src/test/resources/queries/TestQueryValidation/invalid_casewhen_1.sql

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development