Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1101

Broadcast join with a zero-length file table returns wrong result data.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      If a table has several data files and some files are empty, Broadcast join with that table returns wrong data.

      select * from customer_large a
       left outer join nation_multifile b on a.c_nationkey = b.n_nationkey
       where b.n_nationkey is null
      

      The above query should return empty rows but return many rows with null n_nationkey value.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user babokim opened a pull request:

          https://github.com/apache/tajo/pull/184

          TAJO-1101: Broadcast join with a zero-length file table returns wrong result data.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/babokim/tajo TAJO-1101

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/184.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #184


          commit 5140517486cd634f1640d61f350e86c63090ebaa
          Author: HyoungJun Kim <babokim@babokim-macbook-pro.local>
          Date: 2014-10-07T10:38:49Z

          TAJO-1101: Broadcast join with a zero-length file table returns wrong result data.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/184 TAJO-1101 : Broadcast join with a zero-length file table returns wrong result data. You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-1101 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit 5140517486cd634f1640d61f350e86c63090ebaa Author: HyoungJun Kim <babokim@babokim-macbook-pro.local> Date: 2014-10-07T10:38:49Z TAJO-1101 : Broadcast join with a zero-length file table returns wrong result data.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/184#issuecomment-58218432

          +1

          The patch looks straightforward and the unit test looks nice to me. Ship it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/184#issuecomment-58218432 +1 The patch looks straightforward and the unit test looks nice to me. Ship it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user babokim commented on the pull request:

          https://github.com/apache/tajo/pull/184#issuecomment-58282622

          @hyunsik Thanks for your review. I'll commit soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/184#issuecomment-58282622 @hyunsik Thanks for your review. I'll commit soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/184

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/184
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #394 (See https://builds.apache.org/job/Tajo-master-build/394/)
          TAJO-1101: Broadcast join with a zero-length file table returns wrong result data. (babokim: rev 2eba8aa30e1266e15ad918e4b150259bff6b31df)

          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
          • CHANGES
          • tajo-core/src/test/resources/queries/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.sql
          • tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java
          • tajo-core/src/test/resources/results/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.result
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #394 (See https://builds.apache.org/job/Tajo-master-build/394/ ) TAJO-1101 : Broadcast join with a zero-length file table returns wrong result data. (babokim: rev 2eba8aa30e1266e15ad918e4b150259bff6b31df) tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java CHANGES tajo-core/src/test/resources/queries/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.sql tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java tajo-core/src/test/resources/results/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.result
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-CODEGEN-build #36 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/36/)
          TAJO-1101: Broadcast join with a zero-length file table returns wrong result data. (babokim: rev 2eba8aa30e1266e15ad918e4b150259bff6b31df)

          • tajo-core/src/test/resources/queries/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.sql
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
          • tajo-core/src/test/resources/results/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.result
          • tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #36 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/36/ ) TAJO-1101 : Broadcast join with a zero-length file table returns wrong result data. (babokim: rev 2eba8aa30e1266e15ad918e4b150259bff6b31df) tajo-core/src/test/resources/queries/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java tajo-core/src/test/resources/results/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.result tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/)
          TAJO-1101: Broadcast join with a zero-length file table returns wrong result data. (babokim: rev 2eba8aa30e1266e15ad918e4b150259bff6b31df)

          • tajo-core/src/test/resources/queries/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.sql
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java
          • tajo-core/src/test/resources/results/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.result
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/ ) TAJO-1101 : Broadcast join with a zero-length file table returns wrong result data. (babokim: rev 2eba8aa30e1266e15ad918e4b150259bff6b31df) tajo-core/src/test/resources/queries/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java tajo-core/src/test/resources/results/TestJoinBroadcast/testMultipleBroadcastDataFileWithZeroLength.result CHANGES

            People

            • Assignee:
              hjkim Hyoungjun Kim
              Reporter:
              hjkim Hyoungjun Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development