Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1070

BSTIndexScanExec should not seek a negative offset

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Physical Operator
    • Labels:
      None

      Description

      Recent hadoop filesystem apis defined strictly. So we should fix it correctly.
      https://issues.apache.org/jira/browse/HADOOP-9361

      It cause by unnecessary seek to -1

      java.io.EOFException: Cannot seek to a negative offset
      	at org.apache.hadoop.fs.FSInputChecker.seek(FSInputChecker.java:399)
      	at org.apache.hadoop.fs.FSDataInputStream.seek(FSDataInputStream.java:62)
      	at org.apache.hadoop.fs.ChecksumFileSystem$FSDataBoundedInputStream.seek(ChecksumFileSystem.java:325)
      	at org.apache.tajo.storage.CSVFile$CSVScanner.seek(CSVFile.java:544)
      	at org.apache.tajo.engine.planner.physical.BSTIndexScanExec.next(BSTIndexScanExec.java:119)
      	at org.apache.tajo.engine.planner.physical.TestBSTIndexExec.testEqual(TestBSTIndexExec.java:184)
      

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-block_iteration-branch-build #5 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/5/)
          TAJO-1070: BSTIndexScanExec should not seek a negative offset. (jinho) (jhkim: rev 55bfa680bfac102e90a73c3f9c7436fabf85688e)

          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #5 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/5/ ) TAJO-1070 : BSTIndexScanExec should not seek a negative offset. (jinho) (jhkim: rev 55bfa680bfac102e90a73c3f9c7436fabf85688e) tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-CODEGEN-build #17 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/17/)
          TAJO-1070: BSTIndexScanExec should not seek a negative offset. (jinho) (jhkim: rev 55bfa680bfac102e90a73c3f9c7436fabf85688e)

          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #17 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/17/ ) TAJO-1070 : BSTIndexScanExec should not seek a negative offset. (jinho) (jhkim: rev 55bfa680bfac102e90a73c3f9c7436fabf85688e) CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #375 (See https://builds.apache.org/job/Tajo-master-build/375/)
          TAJO-1070: BSTIndexScanExec should not seek a negative offset. (jinho) (jhkim: rev 55bfa680bfac102e90a73c3f9c7436fabf85688e)

          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #375 (See https://builds.apache.org/job/Tajo-master-build/375/ ) TAJO-1070 : BSTIndexScanExec should not seek a negative offset. (jinho) (jhkim: rev 55bfa680bfac102e90a73c3f9c7436fabf85688e) CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
          Hide
          jhkim Jinho Kim added a comment -

          committed.
          Thank you for the your review!

          Show
          jhkim Jinho Kim added a comment - committed. Thank you for the your review!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/159

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/159
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/159#issuecomment-56759434

          +1
          The patch looks good to me. Ship it!

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/159#issuecomment-56759434 +1 The patch looks good to me. Ship it!
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jinossy opened a pull request:

          https://github.com/apache/tajo/pull/159

          TAJO-1070: BSTIndexScanExec should not seek a negative offset

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jinossy/tajo TAJO-1070

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/159.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #159


          commit 1d0f5844f14a03636988ecf609634be418ac87c8
          Author: jhkim <jhkim@apache.org>
          Date: 2014-09-24T05:09:39Z

          TAJO-1070: BSTIndexScanExec should not seek a negative offset


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/159 TAJO-1070 : BSTIndexScanExec should not seek a negative offset You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1070 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/159.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #159 commit 1d0f5844f14a03636988ecf609634be418ac87c8 Author: jhkim <jhkim@apache.org> Date: 2014-09-24T05:09:39Z TAJO-1070 : BSTIndexScanExec should not seek a negative offset

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development