Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      See the doc:
      http://tajo.apache.org/docs/current/sql_language/queries.html

      This doc is incomplete, and we need to fill this doc.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/)
        TAJO-1068: Add SQL Query documentation. (hyunsik: rev 2d4b0847ff13dced41d47fd740b6c699bba0c945)

        • tajo-docs/src/main/sphinx/sql_language/data_model.rst
        • CHANGES
        • tajo-docs/src/main/sphinx/sql_language/queries.rst
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/ ) TAJO-1068 : Add SQL Query documentation. (hyunsik: rev 2d4b0847ff13dced41d47fd740b6c699bba0c945) tajo-docs/src/main/sphinx/sql_language/data_model.rst CHANGES tajo-docs/src/main/sphinx/sql_language/queries.rst
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #24 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/24/)
        TAJO-1068: Add SQL Query documentation. (hyunsik: rev 2d4b0847ff13dced41d47fd740b6c699bba0c945)

        • tajo-docs/src/main/sphinx/sql_language/queries.rst
        • tajo-docs/src/main/sphinx/sql_language/data_model.rst
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #24 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/24/ ) TAJO-1068 : Add SQL Query documentation. (hyunsik: rev 2d4b0847ff13dced41d47fd740b6c699bba0c945) tajo-docs/src/main/sphinx/sql_language/queries.rst tajo-docs/src/main/sphinx/sql_language/data_model.rst CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #382 (See https://builds.apache.org/job/Tajo-master-build/382/)
        TAJO-1068: Add SQL Query documentation. (hyunsik: rev 2d4b0847ff13dced41d47fd740b6c699bba0c945)

        • CHANGES
        • tajo-docs/src/main/sphinx/sql_language/queries.rst
        • tajo-docs/src/main/sphinx/sql_language/data_model.rst
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #382 (See https://builds.apache.org/job/Tajo-master-build/382/ ) TAJO-1068 : Add SQL Query documentation. (hyunsik: rev 2d4b0847ff13dced41d47fd740b6c699bba0c945) CHANGES tajo-docs/src/main/sphinx/sql_language/queries.rst tajo-docs/src/main/sphinx/sql_language/data_model.rst
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - I just committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/155

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/155
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-57562937

        Thank you @hsaputra for the quick review! I'll commit it shortly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-57562937 Thank you @hsaputra for the quick review! I'll commit it shortly.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-57562816

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-57562816 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-57546289

        Hi @mhthanh and @hsaputra,

        Thank you all for your revision. I reflected your comments and updated the patch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-57546289 Hi @mhthanh and @hsaputra, Thank you all for your revision. I reflected your comments and updated the patch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/155#discussion_r18195877

        — Diff: tajo-docs/src/main/sphinx/sql_language/queries.rst —
        @@ -23,16 +23,234 @@ Overview
        From Clause
        =====================

        +Synopsis
        +
        +.. code-block:: sql
        +
        + [FROM <table reference> [[AS] <table alias name>] [, ...]]
        +
        +
        +The ``FROM`` clause specifies one or more other tables given in a comma-separated table reference list.
        +A table reference can be a relation name , or a subquery, a table join, or complex combinations of them.
        +
        +----------------------
        +Table and Table Aliase
        +----------------------
        +
        +A temporary name can be given to tables and complex table references to be used
        +for references to the derived table in the rest of the query. This is called a table alias.
        +
        +To create a a table alias, please use ``AS``:
        +
        +.. code-block:: sql
        +
        + FROM table_reference AS alias
        +
        +or
        +
        +.. code-block:: sql
        +
        + FROM table_reference alias
        +
        +The ``AS`` keyword can be omitted, and Alias can be any identifier.
        +
        +A typical application of table aliases is to give short names to a long table references. For example:
        +
        +.. code-block:: sql
        +
        + SELECT * FROM long_table_name_1234 s JOIN another_long_table_name_5678 a ON s.id = a.num;
        +
        +-------------
        +Joined Tables
        +-------------
        +
        +Tajo supports all kinds of join types.
        +
        +Join Type
        — End diff –

        "Join Types" instead of "Join Type" to be consistent with the rest of the doc.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on a diff in the pull request: https://github.com/apache/tajo/pull/155#discussion_r18195877 — Diff: tajo-docs/src/main/sphinx/sql_language/queries.rst — @@ -23,16 +23,234 @@ Overview From Clause ===================== + Synopsis + +.. code-block:: sql + + [FROM <table reference> [ [AS] <table alias name>] [, ...] ] + + +The ``FROM`` clause specifies one or more other tables given in a comma-separated table reference list. +A table reference can be a relation name , or a subquery, a table join, or complex combinations of them. + +---------------------- +Table and Table Aliase +---------------------- + +A temporary name can be given to tables and complex table references to be used +for references to the derived table in the rest of the query. This is called a table alias. + +To create a a table alias, please use ``AS``: + +.. code-block:: sql + + FROM table_reference AS alias + +or + +.. code-block:: sql + + FROM table_reference alias + +The ``AS`` keyword can be omitted, and Alias can be any identifier. + +A typical application of table aliases is to give short names to a long table references. For example: + +.. code-block:: sql + + SELECT * FROM long_table_name_1234 s JOIN another_long_table_name_5678 a ON s.id = a.num; + +------------- +Joined Tables +------------- + +Tajo supports all kinds of join types. + +Join Type — End diff – "Join Types" instead of "Join Type" to be consistent with the rest of the doc.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/155#discussion_r18195858

        — Diff: tajo-docs/src/main/sphinx/sql_language/queries.rst —
        @@ -23,16 +23,234 @@ Overview
        From Clause
        =====================

        +Synopsis
        +
        +.. code-block:: sql
        +
        + [FROM <table reference> [[AS] <table alias name>] [, ...]]
        +
        +
        +The ``FROM`` clause specifies one or more other tables given in a comma-separated table reference list.
        +A table reference can be a relation name , or a subquery, a table join, or complex combinations of them.
        +
        +----------------------
        +Table and Table Aliase
        — End diff –

        `Aliases` ?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on a diff in the pull request: https://github.com/apache/tajo/pull/155#discussion_r18195858 — Diff: tajo-docs/src/main/sphinx/sql_language/queries.rst — @@ -23,16 +23,234 @@ Overview From Clause ===================== + Synopsis + +.. code-block:: sql + + [FROM <table reference> [ [AS] <table alias name>] [, ...] ] + + +The ``FROM`` clause specifies one or more other tables given in a comma-separated table reference list. +A table reference can be a relation name , or a subquery, a table join, or complex combinations of them. + +---------------------- +Table and Table Aliase — End diff – `Aliases` ?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-57253055

        Hi @mhthanh,

        I greatly appreciate your review and contributions. Thank you for fixing the errors. I'll reflect all your comments.

        You are right for Line 240. I'll fix it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-57253055 Hi @mhthanh, I greatly appreciate your review and contributions. Thank you for fixing the errors. I'll reflect all your comments. You are right for Line 240. I'll fix it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user mhthanh commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-57116441

        Overall, the patch looks good to me and I think that it will be useful for Tajo users.
        Besides, there are a few typos (all in "queries.rst") as follows.
        + Line 37: "Aliase" -> "Aliases"
        + Line 57: "a long table references" -> "long table references"
        + Line 79: "Catesian product" -> "Cartesian product"
        + Line 193: "an descending order" -> "a descending order"
        + Line 240: "any expressions and aggregation functions are allowed in ``ORDER BY`` clause" -> this makes me confused. Does it mean "all expressions and aggregation functions are allowed in ``ORDER BY`` clause" ?

        Show
        githubbot ASF GitHub Bot added a comment - Github user mhthanh commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-57116441 Overall, the patch looks good to me and I think that it will be useful for Tajo users. Besides, there are a few typos (all in "queries.rst") as follows. + Line 37: "Aliase" -> "Aliases" + Line 57: "a long table references" -> "long table references" + Line 79: "Catesian product" -> "Cartesian product" + Line 193: "an descending order" -> "a descending order" + Line 240: "any expressions and aggregation functions are allowed in ``ORDER BY`` clause" -> this makes me confused. Does it mean "all expressions and aggregation functions are allowed in ``ORDER BY`` clause" ?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-56980096

        @mhthanh Thanks a lot!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-56980096 @mhthanh Thanks a lot!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user mhthanh commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-56936506

        If nobody reviews your doc in the weekend, I will review it next Monday

        Show
        githubbot ASF GitHub Bot added a comment - Github user mhthanh commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-56936506 If nobody reviews your doc in the weekend, I will review it next Monday
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/155#issuecomment-56921130

        I've updated the explanation of the groupby clause. Could you anyone review this?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/155#issuecomment-56921130 I've updated the explanation of the groupby clause. Could you anyone review this?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/155

        TAJO-1068: Add SQL Query documentation.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1068

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/155.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #155


        commit aead20b6e1a94ffe540772ec97b85765fd5808e6
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-09-24T01:29:07Z

        TAJO-1068: Add SQL Query documentation.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/155 TAJO-1068 : Add SQL Query documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1068 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit aead20b6e1a94ffe540772ec97b85765fd5808e6 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-09-24T01:29:07Z TAJO-1068 : Add SQL Query documentation.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development