Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      Current tajo version missed hadoop version.
      http://tajo.apache.org/docs/current/getting_started/building.html

      So, lots of tajo beginners easily failed to run their tajo cluster. Thus, we need to add the hadoop version to the documentation. In addition, we need to add more useful informations to it.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-block_iteration-branch-build #12 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/12/)
          TAJO-1061: Update build documentation. (jaehwa) (blrunner: rev 52e554390fa2b953304ee38006d74beac488f5c0)

          • tajo-docs/src/main/sphinx/getting_started/building.rst
          • CHANGES
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-block_iteration-branch-build #12 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/12/ ) TAJO-1061 : Update build documentation. (jaehwa) (blrunner: rev 52e554390fa2b953304ee38006d74beac488f5c0) tajo-docs/src/main/sphinx/getting_started/building.rst CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-CODEGEN-build #19 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/19/)
          TAJO-1061: Update build documentation. (jaehwa) (blrunner: rev 52e554390fa2b953304ee38006d74beac488f5c0)

          • tajo-docs/src/main/sphinx/getting_started/building.rst
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #19 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/19/ ) TAJO-1061 : Update build documentation. (jaehwa) (blrunner: rev 52e554390fa2b953304ee38006d74beac488f5c0) tajo-docs/src/main/sphinx/getting_started/building.rst CHANGES
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #377 (See https://builds.apache.org/job/Tajo-master-build/377/)
          TAJO-1061: Update build documentation. (jaehwa) (blrunner: rev 52e554390fa2b953304ee38006d74beac488f5c0)

          • CHANGES
          • tajo-docs/src/main/sphinx/getting_started/building.rst
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #377 (See https://builds.apache.org/job/Tajo-master-build/377/ ) TAJO-1061 : Update build documentation. (jaehwa) (blrunner: rev 52e554390fa2b953304ee38006d74beac488f5c0) CHANGES tajo-docs/src/main/sphinx/getting_started/building.rst
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/157

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/157
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/157#issuecomment-56920965

          Thanks guys.
          I'll push it ASAP.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/157#issuecomment-56920965 Thanks guys. I'll push it ASAP.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/157#issuecomment-56917509

          +1 LGTM!

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/157#issuecomment-56917509 +1 LGTM!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/157#issuecomment-56861228

          Hi @hyunsik

          Thank you for your review. I've just updated it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/157#issuecomment-56861228 Hi @hyunsik Thank you for your review. I've just updated it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/157#discussion_r18010199

          — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst —
          @@ -11,9 +11,15 @@ You can compile source code and get a binary archive as follows:
          .. code-block:: bash

          $ cd tajo-x.y.z

          • $ mvn clean install -DskipTests -Pdist -Dtar
            + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz
            $ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz

          +.. note::
          +
          + If you don't specify the hadoop version, tajo cluster may not run correctly. Thus, we highly recommend that you specify your hadoop version with maven build command, for example, as follows.
          — End diff –

          I think that the following is better.
          ```
          buid command.

          Example:
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/157#discussion_r18010199 — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst — @@ -11,9 +11,15 @@ You can compile source code and get a binary archive as follows: .. code-block:: bash $ cd tajo-x.y.z $ mvn clean install -DskipTests -Pdist -Dtar + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz $ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz +.. note:: + + If you don't specify the hadoop version, tajo cluster may not run correctly. Thus, we highly recommend that you specify your hadoop version with maven build command, for example, as follows. — End diff – I think that the following is better. ``` buid command. Example: ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/157#discussion_r18010195

          — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst —
          @@ -11,9 +11,15 @@ You can compile source code and get a binary archive as follows:
          .. code-block:: bash

          $ cd tajo-x.y.z

          • $ mvn clean install -DskipTests -Pdist -Dtar
            + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz
              • End diff –

          Because xyz is already used for Tajo version, It would be better to use other notation.

          For consistency, please refer to my comment in https://github.com/apache/tajo/pull/158.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/157#discussion_r18010195 — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst — @@ -11,9 +11,15 @@ You can compile source code and get a binary archive as follows: .. code-block:: bash $ cd tajo-x.y.z $ mvn clean install -DskipTests -Pdist -Dtar + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz End diff – Because xyz is already used for Tajo version, It would be better to use other notation. For consistency, please refer to my comment in https://github.com/apache/tajo/pull/158 .
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/157#discussion_r17951958

          — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst —
          @@ -11,9 +11,14 @@ You can compile source code and get a binary archive as follows:
          .. code-block:: bash

          $ cd tajo-x.y.z

          • $ mvn clean install -DskipTests -Pdist -Dtar
            + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz
            $ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz

          +.. note::
          +
          + If you doesn't specify the hadoop version, tajo cluster may not run correctly. Thus, You must specify your hadoop version with maven build command as follows.
          — End diff –

          Thank you for your review.
          I've just updated the patch.
          For reference, tajo will bump to hadoop 2.5.1 version ADN.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on a diff in the pull request: https://github.com/apache/tajo/pull/157#discussion_r17951958 — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst — @@ -11,9 +11,14 @@ You can compile source code and get a binary archive as follows: .. code-block:: bash $ cd tajo-x.y.z $ mvn clean install -DskipTests -Pdist -Dtar + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz $ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz +.. note:: + + If you doesn't specify the hadoop version, tajo cluster may not run correctly. Thus, You must specify your hadoop version with maven build command as follows. — End diff – Thank you for your review. I've just updated the patch. For reference, tajo will bump to hadoop 2.5.1 version ADN.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mhthanh commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/157#discussion_r17951049

          — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst —
          @@ -11,9 +11,14 @@ You can compile source code and get a binary archive as follows:
          .. code-block:: bash

          $ cd tajo-x.y.z

          • $ mvn clean install -DskipTests -Pdist -Dtar
            + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz
            $ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz

          +.. note::
          +
          + If you doesn't specify the hadoop version, tajo cluster may not run correctly. Thus, You must specify your hadoop version with maven build command as follows.
          — End diff –

          I think there are some typos:
          + "If you doesn't" -> "If you don't"
          + "Thus, You must" -> "Thus, you must"

          Beside, version "2.5.1" is not mandatory. It is just an example. Specifying a hadoop version is also not mandatory. Tajo can also work correctly at least in my system even though I do not specify a hadoop version. So, instead of saying "Thus, you must specify your hadoop version with maven build command as follows", I would like to suggest to write "Thus, we highly recommend that you specify your hadoop version with maven build command, for example, as follows"

          Show
          githubbot ASF GitHub Bot added a comment - Github user mhthanh commented on a diff in the pull request: https://github.com/apache/tajo/pull/157#discussion_r17951049 — Diff: tajo-docs/src/main/sphinx/getting_started/building.rst — @@ -11,9 +11,14 @@ You can compile source code and get a binary archive as follows: .. code-block:: bash $ cd tajo-x.y.z $ mvn clean install -DskipTests -Pdist -Dtar + $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz $ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz +.. note:: + + If you doesn't specify the hadoop version, tajo cluster may not run correctly. Thus, You must specify your hadoop version with maven build command as follows. — End diff – I think there are some typos: + "If you doesn't" -> "If you don't" + "Thus, You must" -> "Thus, you must" Beside, version "2.5.1" is not mandatory. It is just an example. Specifying a hadoop version is also not mandatory. Tajo can also work correctly at least in my system even though I do not specify a hadoop version. So, instead of saying "Thus, you must specify your hadoop version with maven build command as follows", I would like to suggest to write "Thus, we highly recommend that you specify your hadoop version with maven build command, for example, as follows"
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user blrunner opened a pull request:

          https://github.com/apache/tajo/pull/157

          TAJO-1061: Update build documentation

          TAJO-1061: Update build documentation

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/blrunner/tajo TAJO-1061

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/157.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #157


          commit 7c98709f0fcb06dfb675acae3d6489a6126f55b5
          Author: jinossy <jinossy@gmail.com>
          Date: 2014-08-06T08:43:35Z

          TAJO-995: HiveMetaStoreClient wrapper should retry the connection

          commit 415d0867ae4a4543f47360294bead1fc7f41e292
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-08-10T06:07:24Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit 7a7b4fd26f61df89cacdb4fc41faf9c2abe456b2
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-08-11T02:28:48Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit 45f5ed3adba931f4706f26dda1d3c03240ee11d3
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-08-11T05:40:25Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit aa01e83859ef553ac4eb90c1678e3bc6be20c6c9
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-08-18T09:56:24Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit b33a94509c1a007b56785435c8e16640ffde91b7
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-09-04T02:14:19Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit 05c892448113db40daef54d2e06dad463dbae9c8
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-09-11T02:33:54Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit 42a6c4ebeebe36aad6f7dc5f92c83baee398c85e
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-09-11T03:25:05Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit 52a942136c549f197d6d1c3d1a13717e6f14a83f
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-09-24T01:26:36Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

          commit 01c24235310b17af4c186b37abf24892b270c289
          Author: Jaehwa Jung <blrunner@apache.org>
          Date: 2014-09-24T01:47:26Z

          TAJO-1061: Update build documentation


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/157 TAJO-1061 : Update build documentation TAJO-1061 : Update build documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1061 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit 7c98709f0fcb06dfb675acae3d6489a6126f55b5 Author: jinossy <jinossy@gmail.com> Date: 2014-08-06T08:43:35Z TAJO-995 : HiveMetaStoreClient wrapper should retry the connection commit 415d0867ae4a4543f47360294bead1fc7f41e292 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-08-10T06:07:24Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit 7a7b4fd26f61df89cacdb4fc41faf9c2abe456b2 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-08-11T02:28:48Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit 45f5ed3adba931f4706f26dda1d3c03240ee11d3 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-08-11T05:40:25Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit aa01e83859ef553ac4eb90c1678e3bc6be20c6c9 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-08-18T09:56:24Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit b33a94509c1a007b56785435c8e16640ffde91b7 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-09-04T02:14:19Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit 05c892448113db40daef54d2e06dad463dbae9c8 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-09-11T02:33:54Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit 42a6c4ebeebe36aad6f7dc5f92c83baee398c85e Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-09-11T03:25:05Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit 52a942136c549f197d6d1c3d1a13717e6f14a83f Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-09-24T01:26:36Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo commit 01c24235310b17af4c186b37abf24892b270c289 Author: Jaehwa Jung <blrunner@apache.org> Date: 2014-09-24T01:47:26Z TAJO-1061 : Update build documentation
          Hide
          hyunsik Hyunsik Choi added a comment -

          Mai Hai Thanh Thank you for liking them. I've converted this issue to a sub task of TAJO-1052.

          Show
          hyunsik Hyunsik Choi added a comment - Mai Hai Thanh Thank you for liking them. I've converted this issue to a sub task of TAJO-1052 .
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12670593/TAJO-1061.patch
          against master revision 7510f88.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 104 release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/508//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/508//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/508//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12670593/TAJO-1061.patch against master revision 7510f88. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 104 release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/508//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/508//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/508//console This message is automatically generated.
          Hide
          blrunner Jaehwa Jung added a comment -

          I uploaded the patch for this issue.

          Show
          blrunner Jaehwa Jung added a comment - I uploaded the patch for this issue.

            People

            • Assignee:
              blrunner Jaehwa Jung
              Reporter:
              blrunner Jaehwa Jung
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development