Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1050

RPC client does not retry during connecting

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Java Client, RPC, Worker
    • Labels:
      None

      Description

      If client try to connect before server bring up, client rpc will be failure.

        Issue Links

          Activity

          Hide
          jhkim Jinho Kim added a comment -

          Jihun Kang was upload the two patch, it would be better to seperate.
          and I've added test case and related codes. please refer to TAJO-1025

          Show
          jhkim Jinho Kim added a comment - Jihun Kang was upload the two patch, it would be better to seperate. and I've added test case and related codes. please refer to TAJO-1025
          Hide
          jhkim Jinho Kim added a comment -

          Jihun Kang Could you check the patch ?
          https://reviews.apache.org/r/25821

          Show
          jhkim Jinho Kim added a comment - Jihun Kang Could you check the patch ? https://reviews.apache.org/r/25821
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12669939/TAJO-1050.patch
          against master revision 1cff979.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 210 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 104 release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-core tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/499//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/499//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/499//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/499//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/499//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12669939/TAJO-1050.patch against master revision 1cff979. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 210 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 104 release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-core tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/499//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/499//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/499//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/499//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/499//console This message is automatically generated.
          Hide
          ykrips Jihun Kang added a comment -

          Jinho Kim, I agree with your modifications. This patch fairly looks fine and is applicable to all the rpc clients.

          Show
          ykrips Jihun Kang added a comment - Jinho Kim , I agree with your modifications. This patch fairly looks fine and is applicable to all the rpc clients.
          Hide
          jhkim Jinho Kim added a comment -

          Here is my +1. I'll commit soon.
          Thank you for your contribution.

          Show
          jhkim Jinho Kim added a comment - Here is my +1. I'll commit soon. Thank you for your contribution.
          Hide
          jhkim Jinho Kim added a comment -

          committed it

          Show
          jhkim Jinho Kim added a comment - committed it
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #366 (See https://builds.apache.org/job/Tajo-master-build/366/)
          TAJO-1050: RPC client does not retry during connecting. (Jihun Kang via jinho) (jhkim: rev 5b31fc4207ef1de2418cafbc6d3e714fa03849d0)

          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • CHANGES
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #366 (See https://builds.apache.org/job/Tajo-master-build/366/ ) TAJO-1050 : RPC client does not retry during connecting. (Jihun Kang via jinho) (jhkim: rev 5b31fc4207ef1de2418cafbc6d3e714fa03849d0) tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java CHANGES tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-CODEGEN-build #8 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/8/)
          TAJO-1050: RPC client does not retry during connecting. (Jihun Kang via jinho) (jhkim: rev 5b31fc4207ef1de2418cafbc6d3e714fa03849d0)

          • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • CHANGES
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #8 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/8/ ) TAJO-1050 : RPC client does not retry during connecting. (Jihun Kang via jinho) (jhkim: rev 5b31fc4207ef1de2418cafbc6d3e714fa03849d0) tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java CHANGES tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-block_iteration-branch-build #4 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/4/)
          TAJO-1050: RPC client does not retry during connecting. (Jihun Kang via jinho) (jhkim: rev 5b31fc4207ef1de2418cafbc6d3e714fa03849d0)

          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #4 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/4/ ) TAJO-1050 : RPC client does not retry during connecting. (Jihun Kang via jinho) (jhkim: rev 5b31fc4207ef1de2418cafbc6d3e714fa03849d0) tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java CHANGES

            People

            • Assignee:
              ykrips Jihun Kang
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development