Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1048

Missed use of session variables in GlobalPlanner

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: distributed query plan
    • Labels:
      None

      Description

      We use OverridableConf in order to override configs by session variables. But, there are some missed configs which do not use OverridableConf. This patch fixes the bug.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-block_iteration-branch-build #3 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/3/)
        TAJO-1048: Missed use of session variables in GlobalPlanner. (hyunsik: rev 745131ee996b8d468479145de2069c4d34d6ffa0)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #3 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/3/ ) TAJO-1048 : Missed use of session variables in GlobalPlanner. (hyunsik: rev 745131ee996b8d468479145de2069c4d34d6ffa0) CHANGES tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #3 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/3/)
        TAJO-1048: Missed use of session variables in GlobalPlanner. (hyunsik: rev 745131ee996b8d468479145de2069c4d34d6ffa0)

        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #3 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/3/ ) TAJO-1048 : Missed use of session variables in GlobalPlanner. (hyunsik: rev 745131ee996b8d468479145de2069c4d34d6ffa0) tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #361 (See https://builds.apache.org/job/Tajo-master-build/361/)
        TAJO-1048: Missed use of session variables in GlobalPlanner. (hyunsik: rev 745131ee996b8d468479145de2069c4d34d6ffa0)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #361 (See https://builds.apache.org/job/Tajo-master-build/361/ ) TAJO-1048 : Missed use of session variables in GlobalPlanner. (hyunsik: rev 745131ee996b8d468479145de2069c4d34d6ffa0) CHANGES tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/146

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/146
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/146#issuecomment-55915674

        Looks great! Ship it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/146#issuecomment-55915674 Looks great! Ship it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/146#issuecomment-55915147

        Thanks for the quick review. I fixed groupby too. Please check it again

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/146#issuecomment-55915147 Thanks for the quick review. I fixed groupby too. Please check it again
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/146#issuecomment-55913298

        +1
        The fix is straightforward. Ship it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/146#issuecomment-55913298 +1 The fix is straightforward. Ship it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/146

        TAJO-1048: Missed use of session variables in GlobalPlanner.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1048

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/146.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #146


        commit 97610bcb2af5253cae4cb30d62deb09b01ccdc83
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-09-17T15:20:46Z

        TAJO-1048: Missed use of session variables in GlobalPlanner.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/146 TAJO-1048 : Missed use of session variables in GlobalPlanner. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1048 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/146.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #146 commit 97610bcb2af5253cae4cb30d62deb09b01ccdc83 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-09-17T15:20:46Z TAJO-1048 : Missed use of session variables in GlobalPlanner.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development